16b2b84d84
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - The heartbeat runtime, agent import path, and agent configuration defaults determine whether work is dispatched safely and predictably. > - Several accumulated fixes all touched agent execution recovery, wake routing, import behavior, and runtime concurrency defaults. > - Those changes need to land together so the heartbeat service and agent creation defaults stay internally consistent. > - This pull request groups the runtime/governance changes from the split branch into one standalone branch. > - The benefit is safer recovery for stranded runs, bounded high-volume reads, imported-agent approval correctness, skill-template support, and a clearer default concurrency policy. ## What Changed - Fixed stranded continuation recovery so successful automatic retries are requeued instead of incorrectly blocking the issue. - Bounded high-volume issue/log reads across issue, heartbeat, agent, project, and workspace paths. - Fixed imported-agent approval and instruction-path permission handling. - Quarantined seeded worktree execution state during worktree provisioning. - Queued approval follow-up wakes and hardened SQL_ASCII heartbeat output handling. - Added reusable agent instruction templates for hiring flows. - Set the default max concurrent agent runs to five and updated related UI/tests/docs. ## Verification - `pnpm install --frozen-lockfile` - `pnpm exec vitest run server/src/__tests__/company-portability.test.ts server/src/__tests__/heartbeat-process-recovery.test.ts server/src/__tests__/heartbeat-comment-wake-batching.test.ts server/src/__tests__/heartbeat-list.test.ts server/src/__tests__/issues-service.test.ts server/src/__tests__/agent-permissions-routes.test.ts packages/adapter-utils/src/server-utils.test.ts ui/src/lib/new-agent-runtime-config.test.ts` - Split integration check: merged this branch first, followed by the other [PAP-1614](/PAP/issues/PAP-1614) branches, with no merge conflicts. - Confirmed this branch does not include `pnpm-lock.yaml`. ## Risks - Medium risk: touches heartbeat recovery, queueing, and issue list bounds in central runtime paths. - Imported-agent and concurrency default behavior changes may affect existing automation that assumes one-at-a-time default runs. - No database migrations are included. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5.4 tool-enabled coding model, agentic code-editing/runtime with local shell and GitHub CLI access; exact context window and reasoning mode are not exposed by the Paperclip harness. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
227 lines
6.9 KiB
TypeScript
227 lines
6.9 KiB
TypeScript
import { randomUUID } from "node:crypto";
|
|
import { afterAll, afterEach, beforeAll, describe, expect, it } from "vitest";
|
|
import { agents, companies, createDb, heartbeatRuns } from "@paperclipai/db";
|
|
import {
|
|
getEmbeddedPostgresTestSupport,
|
|
startEmbeddedPostgresTestDatabase,
|
|
} from "./helpers/embedded-postgres.js";
|
|
import { boundHeartbeatRunEventPayloadForStorage, heartbeatService } from "../services/heartbeat.ts";
|
|
|
|
const embeddedPostgresSupport = await getEmbeddedPostgresTestSupport();
|
|
const describeEmbeddedPostgres = embeddedPostgresSupport.supported ? describe : describe.skip;
|
|
|
|
if (!embeddedPostgresSupport.supported) {
|
|
console.warn(
|
|
`Skipping embedded Postgres heartbeat list tests on this host: ${embeddedPostgresSupport.reason ?? "unsupported environment"}`,
|
|
);
|
|
}
|
|
|
|
describeEmbeddedPostgres("heartbeat list", () => {
|
|
let db!: ReturnType<typeof createDb>;
|
|
let tempDb: Awaited<ReturnType<typeof startEmbeddedPostgresTestDatabase>> | null = null;
|
|
|
|
beforeAll(async () => {
|
|
tempDb = await startEmbeddedPostgresTestDatabase("paperclip-heartbeat-list-");
|
|
db = createDb(tempDb.connectionString);
|
|
}, 20_000);
|
|
|
|
afterEach(async () => {
|
|
await db.delete(heartbeatRuns);
|
|
await db.delete(agents);
|
|
await db.delete(companies);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await tempDb?.cleanup();
|
|
});
|
|
|
|
it("returns runs even when the linked db schema lacks processGroupId", async () => {
|
|
const companyId = randomUUID();
|
|
const agentId = randomUUID();
|
|
const runId = randomUUID();
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Paperclip",
|
|
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await db.insert(agents).values({
|
|
id: agentId,
|
|
companyId,
|
|
name: "CodexCoder",
|
|
role: "engineer",
|
|
status: "running",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
});
|
|
|
|
await db.insert(heartbeatRuns).values({
|
|
id: runId,
|
|
companyId,
|
|
agentId,
|
|
invocationSource: "assignment",
|
|
status: "running",
|
|
livenessState: "advanced",
|
|
livenessReason: "run produced action evidence",
|
|
continuationAttempt: 1,
|
|
lastUsefulActionAt: new Date("2026-04-18T12:00:00Z"),
|
|
nextAction: "continue implementation",
|
|
contextSnapshot: { issueId: randomUUID() },
|
|
});
|
|
|
|
const originalDescriptor = Object.getOwnPropertyDescriptor(heartbeatRuns, "processGroupId");
|
|
Object.defineProperty(heartbeatRuns, "processGroupId", {
|
|
value: undefined,
|
|
configurable: true,
|
|
writable: true,
|
|
});
|
|
|
|
try {
|
|
const runs = await heartbeatService(db).list(companyId, agentId, 5);
|
|
expect(runs).toHaveLength(1);
|
|
expect(runs[0]?.id).toBe(runId);
|
|
expect(runs[0]?.processGroupId ?? null).toBeNull();
|
|
expect(runs[0]).toMatchObject({
|
|
livenessState: "advanced",
|
|
livenessReason: "run produced action evidence",
|
|
continuationAttempt: 1,
|
|
nextAction: "continue implementation",
|
|
});
|
|
expect(runs[0]?.lastUsefulActionAt).toEqual(new Date("2026-04-18T12:00:00Z"));
|
|
} finally {
|
|
if (originalDescriptor) {
|
|
Object.defineProperty(heartbeatRuns, "processGroupId", originalDescriptor);
|
|
} else {
|
|
delete (heartbeatRuns as Record<string, unknown>).processGroupId;
|
|
}
|
|
}
|
|
});
|
|
|
|
it("returns small result json payloads unchanged from getRun", async () => {
|
|
const companyId = randomUUID();
|
|
const agentId = randomUUID();
|
|
const runId = randomUUID();
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Paperclip",
|
|
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await db.insert(agents).values({
|
|
id: agentId,
|
|
companyId,
|
|
name: "CodexCoder",
|
|
role: "engineer",
|
|
status: "running",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
});
|
|
|
|
await db.insert(heartbeatRuns).values({
|
|
id: runId,
|
|
companyId,
|
|
agentId,
|
|
invocationSource: "assignment",
|
|
status: "succeeded",
|
|
resultJson: {
|
|
summary: "done",
|
|
structured: { ok: true },
|
|
},
|
|
});
|
|
|
|
const run = await heartbeatService(db).getRun(runId);
|
|
|
|
expect(run?.resultJson).toEqual({
|
|
summary: "done",
|
|
structured: { ok: true },
|
|
});
|
|
});
|
|
|
|
it("bounds oversized legacy result json payloads on getRun", async () => {
|
|
const companyId = randomUUID();
|
|
const agentId = randomUUID();
|
|
const runId = randomUUID();
|
|
const oversizedStdout = Array.from({ length: 8_000 }, (_, index) =>
|
|
`${index.toString(16).padStart(4, "0")}-${randomUUID()}`,
|
|
).join("|");
|
|
const oversizedNestedPayload = Array.from({ length: 6_000 }, (_, index) =>
|
|
`${index.toString(16).padStart(4, "0")}:${randomUUID()}`,
|
|
).join("|");
|
|
|
|
await db.insert(companies).values({
|
|
id: companyId,
|
|
name: "Paperclip",
|
|
issuePrefix: `T${companyId.replace(/-/g, "").slice(0, 6).toUpperCase()}`,
|
|
requireBoardApprovalForNewAgents: false,
|
|
});
|
|
|
|
await db.insert(agents).values({
|
|
id: agentId,
|
|
companyId,
|
|
name: "CodexCoder",
|
|
role: "engineer",
|
|
status: "running",
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
runtimeConfig: {},
|
|
permissions: {},
|
|
});
|
|
|
|
await db.insert(heartbeatRuns).values({
|
|
id: runId,
|
|
companyId,
|
|
agentId,
|
|
invocationSource: "assignment",
|
|
status: "succeeded",
|
|
resultJson: {
|
|
summary: "completed",
|
|
stdout: oversizedStdout,
|
|
nestedHuge: { payload: oversizedNestedPayload },
|
|
},
|
|
});
|
|
|
|
const run = await heartbeatService(db).getRun(runId);
|
|
const result = run?.resultJson as Record<string, unknown> | null;
|
|
|
|
expect(result).toMatchObject({
|
|
summary: "completed",
|
|
truncated: true,
|
|
truncationReason: "oversized_result_json",
|
|
stdoutTruncated: true,
|
|
});
|
|
expect(typeof result?.stdout).toBe("string");
|
|
expect((result?.stdout as string).length).toBeLessThan(oversizedStdout.length);
|
|
expect(result).not.toHaveProperty("nestedHuge");
|
|
});
|
|
});
|
|
|
|
describe("heartbeat run event payload bounding", () => {
|
|
it("truncates oversized adapter metadata before storage", () => {
|
|
const payload = boundHeartbeatRunEventPayloadForStorage({
|
|
adapterType: "codex_local",
|
|
prompt: "x".repeat(40_000),
|
|
context: {
|
|
issueId: "issue-1",
|
|
memory: "y".repeat(40_000),
|
|
},
|
|
});
|
|
|
|
expect(payload.adapterType).toBe("codex_local");
|
|
expect(typeof payload.prompt).toBe("string");
|
|
expect((payload.prompt as string).length).toBeLessThan(20_000);
|
|
expect(payload.prompt).toContain("[truncated");
|
|
expect(payload.context).toMatchObject({
|
|
issueId: "issue-1",
|
|
});
|
|
expect(JSON.stringify(payload).length).toBeLessThan(45_000);
|
|
});
|
|
});
|