5071c4c776
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - Operators need to inspect what agents changed inside execution and project workspaces. > - The existing workspace detail views did not provide a first-party rich diff surface for staged, unstaged, head, renamed, binary, oversized, and untracked changes. > - The plugin system is the intended extension point for optional rich UI surfaces. > - This pull request adds a workspace diff plugin plus host services and shared contracts so Changes tabs can render workspace diffs through plugin slots. > - The diff-renderer dependency should stay owned by the plugin package rather than the core UI app. > - The dependency surface must stay aligned with repository PR policy, including intentionally omitting `pnpm-lock.yaml` from the PR. > - The benefit is a more reviewable workspace surface without hard-coding the renderer into every page. ## What Changed - Added `@paperclipai/plugin-workspace-diff`, including diff normalization, plugin manifest/worker/UI entrypoints, and focused plugin tests. - Kept `@pierre/diffs` scoped to `@paperclipai/plugin-workspace-diff`; removed the core UI lab diff-renderer surface and direct UI package dependency. - Added shared workspace diff types and validators, plus plugin SDK surface for workspace diff host services. - Added server workspace diff service support and route coverage for execution/project workspace diff flows. - Wired Execution Workspace and Project Workspace Changes tabs to load the diff plugin, including loading/error fallback behavior. - Added UI tests and fixtures for the Changes tabs and plugin bridge behavior. - Added the new plugin package manifest to the Docker deps stage so PR policy can validate dependency coverage. - Addressed review hardening around empty untracked patches, workspace path exposure, project workspace read capability checks, and default base refs. ## Verification - `pnpm --filter @paperclipai/plugin-workspace-diff test` - `pnpm exec vitest run packages/shared/src/validators/workspace-diff.test.ts server/src/__tests__/workspace-diff-service.test.ts ui/src/pages/ProjectWorkspaceDetail.test.tsx ui/src/pages/ExecutionWorkspaceDetail.test.tsx` - `pnpm exec vitest run ui/src/plugins/bridge.test.ts server/src/__tests__/workspace-runtime-routes-authz.test.ts` - `pnpm --filter @paperclipai/shared typecheck` - `pnpm --filter @paperclipai/plugin-workspace-diff typecheck` - `pnpm --filter @paperclipai/server typecheck` - `pnpm --filter @paperclipai/ui typecheck` - `node ./scripts/check-docker-deps-stage.mjs` - Browser screenshot captured from the local worktree dev server: https://files.catbox.moe/ofdpsp.png - Confirmed branch is rebased onto `public-gh/master`, `.github/workflows/pr.yml` is not included in the PR diff, `ui/package.json` is not included in the PR diff, and `pnpm-lock.yaml` is not included in the PR diff. ## Risks - Medium UI integration risk: the Changes tab depends on the plugin slot and host diff service path. - Medium dependency risk: this adds `@pierre/diffs` in the plugin package, but `pnpm-lock.yaml` is intentionally omitted per packaging instructions because repository automation manages lockfile updates. - Current CI blocker: downstream frozen installs fail until the repository policy path for new plugin package dependencies is chosen. - Diff rendering edge cases are covered for common working-tree and head diff states, but very large repositories may still expose performance limits. - No migrations are included. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 class coding model, tool-enabled local execution environment. Exact context window was not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
145 lines
4.9 KiB
TypeScript
145 lines
4.9 KiB
TypeScript
import { z } from "@paperclipai/plugin-sdk";
|
|
|
|
export const workspaceDiffViewSchema = z.enum(["working-tree", "head"]);
|
|
|
|
export const workspaceDiffFileStatusSchema = z.enum([
|
|
"added",
|
|
"modified",
|
|
"deleted",
|
|
"renamed",
|
|
"copied",
|
|
"type_changed",
|
|
"untracked",
|
|
"unknown",
|
|
]);
|
|
|
|
export const workspaceDiffPatchKindSchema = z.enum(["staged", "unstaged", "head", "untracked"]);
|
|
|
|
export const workspaceDiffWarningCodeSchema = z.enum([
|
|
"base_ref_missing",
|
|
"base_ref_invalid",
|
|
"binary_file",
|
|
"file_count_truncated",
|
|
"file_oversized",
|
|
"git_command_failed",
|
|
"missing_cwd",
|
|
"non_git_workspace",
|
|
"patch_truncated",
|
|
"path_filter_invalid",
|
|
"symlink_target_outside_workspace",
|
|
"workspace_path_invalid",
|
|
]);
|
|
|
|
const queryBooleanSchema = z
|
|
.union([z.boolean(), z.enum(["true", "false"])])
|
|
.transform((value) => value === true || value === "true");
|
|
|
|
function normalizePathQuery(value: unknown): string[] {
|
|
if (value == null) return [];
|
|
const values = Array.isArray(value) ? value : [value];
|
|
return values.flatMap((entry) => {
|
|
if (typeof entry !== "string") return [];
|
|
return entry
|
|
.split(",")
|
|
.map((filePath) => filePath.trim())
|
|
.filter(Boolean);
|
|
});
|
|
}
|
|
|
|
export const workspaceDiffQuerySchema = z
|
|
.object({
|
|
view: workspaceDiffViewSchema.optional().default("working-tree"),
|
|
baseRef: z.string().trim().min(1).max(240).optional().nullable(),
|
|
includeUntracked: queryBooleanSchema.optional().default(true),
|
|
path: z.union([z.string(), z.array(z.string())]).optional(),
|
|
paths: z.union([z.string(), z.array(z.string())]).optional(),
|
|
})
|
|
.passthrough()
|
|
.transform((value) => ({
|
|
view: value.view,
|
|
baseRef: value.baseRef?.trim() || null,
|
|
includeUntracked: value.includeUntracked,
|
|
paths: normalizePathQuery(value.paths ?? value.path),
|
|
}));
|
|
|
|
export const workspaceDiffWarningSchema = z.object({
|
|
code: workspaceDiffWarningCodeSchema,
|
|
message: z.string(),
|
|
path: z.string().nullable(),
|
|
}).strict();
|
|
|
|
export const workspaceDiffCapsSchema = z.object({
|
|
maxFiles: z.number().int().positive(),
|
|
maxFileBytes: z.number().int().positive(),
|
|
maxPatchBytes: z.number().int().positive(),
|
|
maxTotalPatchBytes: z.number().int().positive(),
|
|
}).strict();
|
|
|
|
export const workspaceDiffFilePatchSchema = z.object({
|
|
kind: workspaceDiffPatchKindSchema,
|
|
patch: z.string().nullable(),
|
|
additions: z.number().int().nonnegative(),
|
|
deletions: z.number().int().nonnegative(),
|
|
binary: z.boolean(),
|
|
oversized: z.boolean(),
|
|
truncated: z.boolean(),
|
|
warnings: z.array(workspaceDiffWarningSchema),
|
|
}).strict();
|
|
|
|
export const workspaceDiffFileSchema = z.object({
|
|
path: z.string(),
|
|
oldPath: z.string().nullable(),
|
|
status: workspaceDiffFileStatusSchema,
|
|
staged: z.boolean(),
|
|
unstaged: z.boolean(),
|
|
untracked: z.boolean(),
|
|
binary: z.boolean(),
|
|
oversized: z.boolean(),
|
|
truncated: z.boolean(),
|
|
additions: z.number().int().nonnegative(),
|
|
deletions: z.number().int().nonnegative(),
|
|
sizeBytes: z.number().int().nonnegative().nullable(),
|
|
patches: z.array(workspaceDiffFilePatchSchema),
|
|
warnings: z.array(workspaceDiffWarningSchema),
|
|
}).strict();
|
|
|
|
export const workspaceDiffStatsSchema = z.object({
|
|
fileCount: z.number().int().nonnegative(),
|
|
stagedFileCount: z.number().int().nonnegative(),
|
|
unstagedFileCount: z.number().int().nonnegative(),
|
|
untrackedFileCount: z.number().int().nonnegative(),
|
|
binaryFileCount: z.number().int().nonnegative(),
|
|
oversizedFileCount: z.number().int().nonnegative(),
|
|
truncatedFileCount: z.number().int().nonnegative(),
|
|
additions: z.number().int().nonnegative(),
|
|
deletions: z.number().int().nonnegative(),
|
|
}).strict();
|
|
|
|
export const workspaceDiffResponseSchema = z.object({
|
|
workspaceId: z.string(),
|
|
companyId: z.string(),
|
|
view: workspaceDiffViewSchema,
|
|
baseRef: z.string().nullable(),
|
|
defaultBaseRef: z.string().nullable(),
|
|
headSha: z.string().nullable(),
|
|
includeUntracked: z.boolean(),
|
|
paths: z.array(z.string()),
|
|
files: z.array(workspaceDiffFileSchema),
|
|
stats: workspaceDiffStatsSchema,
|
|
warnings: z.array(workspaceDiffWarningSchema),
|
|
caps: workspaceDiffCapsSchema,
|
|
truncated: z.boolean(),
|
|
}).strict();
|
|
|
|
export type WorkspaceDiffView = z.infer<typeof workspaceDiffViewSchema>;
|
|
export type WorkspaceDiffFileStatus = z.infer<typeof workspaceDiffFileStatusSchema>;
|
|
export type WorkspaceDiffPatchKind = z.infer<typeof workspaceDiffPatchKindSchema>;
|
|
export type WorkspaceDiffWarningCode = z.infer<typeof workspaceDiffWarningCodeSchema>;
|
|
export type WorkspaceDiffQueryOptions = z.infer<typeof workspaceDiffQuerySchema>;
|
|
export type WorkspaceDiffWarning = z.infer<typeof workspaceDiffWarningSchema>;
|
|
export type WorkspaceDiffCaps = z.infer<typeof workspaceDiffCapsSchema>;
|
|
export type WorkspaceDiffFilePatch = z.infer<typeof workspaceDiffFilePatchSchema>;
|
|
export type WorkspaceDiffFile = z.infer<typeof workspaceDiffFileSchema>;
|
|
export type WorkspaceDiffStats = z.infer<typeof workspaceDiffStatsSchema>;
|
|
export type WorkspaceDiffResponse = z.infer<typeof workspaceDiffResponseSchema>;
|