7ad225a198
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Issue detail is where operators coordinate review, approvals, and follow-up work with active runs > - That thread UI needs to surface blockers, descendants, review handoffs, and reply ergonomics clearly enough for humans to guide agent work > - Several small gaps in the issue-thread flow were making review and navigation clunkier than necessary > - This pull request improves the reply composer, descendant/blocker presentation, interaction folding, and review-request handoff plumbing together as one cohesive issue-thread workflow slice > - The benefit is a cleaner operator review loop without changing the broader task model ## What Changed - restored and refined the floating reply composer behavior in the issue thread - folded expired confirmation interactions and improved post-submit thread scrolling behavior - surfaced descendant issue context and inline blocker/paused-assignee notices on the issue detail view - tightened large-board first paint behavior in `IssuesList` - added loose review-request handoffs through the issue execution-policy/update path and covered them with tests ## Verification - `pnpm vitest run ui/src/pages/IssueDetail.test.tsx` - `pnpm vitest run server/src/__tests__/issues-service.test.ts server/src/__tests__/issue-execution-policy.test.ts` - `pnpm exec vitest run --project @paperclipai/ui ui/src/components/IssueChatThread.test.tsx ui/src/components/IssueProperties.test.tsx ui/src/components/IssuesList.test.tsx ui/src/lib/issue-tree.test.ts ui/src/api/issues.test.ts` - `pnpm exec vitest run --project @paperclipai/adapter-utils packages/adapter-utils/src/server-utils.test.ts` - `pnpm exec vitest run --project @paperclipai/server server/src/__tests__/issue-comment-reopen-routes.test.ts -t "coerces executor handoff patches into workflow-controlled review wakes|wakes the return assignee with execution_changes_requested"` - `pnpm exec vitest run --project @paperclipai/server server/src/__tests__/issue-execution-policy.test.ts server/src/__tests__/issues-service.test.ts` ## Visual Evidence - UI layout changes are covered by the focused issue-thread component and issue-detail tests listed above. Browser screenshots were not attachable from this automated greploop environment, so reviewers should use the running preview for final visual confirmation. ## Risks - Moderate UI-flow risk: these changes touch the issue detail experience in multiple spots, so regressions would most likely show up as thread-layout quirks or incorrect review-handoff behavior > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex GPT-5-based coding agent with tool use and code execution in the Codex CLI environment ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots or documented the visual verification path - [ ] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
161 lines
5.4 KiB
TypeScript
161 lines
5.4 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import type { Issue } from "@paperclipai/shared";
|
|
import { buildIssueTree, countDescendants, filterIssueDescendants } from "./issue-tree";
|
|
|
|
function makeIssue(id: string, parentId: string | null = null): Issue {
|
|
return {
|
|
id,
|
|
identifier: id.toUpperCase(),
|
|
companyId: "company-1",
|
|
projectId: null,
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId,
|
|
title: `Issue ${id}`,
|
|
description: null,
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: null,
|
|
issueNumber: 1,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
createdAt: new Date("2026-01-01T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-01-01T00:00:00.000Z"),
|
|
labels: [],
|
|
labelIds: [],
|
|
myLastTouchAt: null,
|
|
lastExternalCommentAt: null,
|
|
isUnreadForMe: false,
|
|
};
|
|
}
|
|
|
|
describe("buildIssueTree", () => {
|
|
it("returns all items as roots when no parent-child relationships exist", () => {
|
|
const items = [makeIssue("a"), makeIssue("b"), makeIssue("c")];
|
|
const { roots, childMap } = buildIssueTree(items);
|
|
expect(roots.map((r) => r.id)).toEqual(["a", "b", "c"]);
|
|
expect(childMap.size).toBe(0);
|
|
});
|
|
|
|
it("places children under their parent and excludes them from roots", () => {
|
|
const parent = makeIssue("parent");
|
|
const child1 = makeIssue("child1", "parent");
|
|
const child2 = makeIssue("child2", "parent");
|
|
const { roots, childMap } = buildIssueTree([parent, child1, child2]);
|
|
expect(roots.map((r) => r.id)).toEqual(["parent"]);
|
|
expect(childMap.get("parent")?.map((c) => c.id)).toEqual(["child1", "child2"]);
|
|
});
|
|
|
|
it("handles multiple levels of nesting", () => {
|
|
const grandparent = makeIssue("gp");
|
|
const parent = makeIssue("p", "gp");
|
|
const child = makeIssue("c", "p");
|
|
const { roots, childMap } = buildIssueTree([grandparent, parent, child]);
|
|
expect(roots.map((r) => r.id)).toEqual(["gp"]);
|
|
expect(childMap.get("gp")?.map((i) => i.id)).toEqual(["p"]);
|
|
expect(childMap.get("p")?.map((i) => i.id)).toEqual(["c"]);
|
|
});
|
|
|
|
it("promotes orphaned sub-tasks (parent not in list) to root level", () => {
|
|
// child references a parent that is not in the items array (e.g. filtered out)
|
|
const child = makeIssue("child", "missing-parent");
|
|
const unrelated = makeIssue("unrelated");
|
|
const { roots, childMap } = buildIssueTree([child, unrelated]);
|
|
expect(roots.map((r) => r.id)).toEqual(["child", "unrelated"]);
|
|
expect(childMap.size).toBe(0);
|
|
});
|
|
|
|
it("returns empty roots and empty childMap for an empty list", () => {
|
|
const { roots, childMap } = buildIssueTree([]);
|
|
expect(roots).toEqual([]);
|
|
expect(childMap.size).toBe(0);
|
|
});
|
|
|
|
it("preserves list order within roots and within children", () => {
|
|
const p1 = makeIssue("p1");
|
|
const p2 = makeIssue("p2");
|
|
const c1 = makeIssue("c1", "p1");
|
|
const c2 = makeIssue("c2", "p1");
|
|
const { roots, childMap } = buildIssueTree([p1, c1, p2, c2]);
|
|
expect(roots.map((r) => r.id)).toEqual(["p1", "p2"]);
|
|
expect(childMap.get("p1")?.map((c) => c.id)).toEqual(["c1", "c2"]);
|
|
});
|
|
});
|
|
|
|
describe("countDescendants", () => {
|
|
it("returns 0 for a leaf node", () => {
|
|
const { childMap } = buildIssueTree([makeIssue("a")]);
|
|
expect(countDescendants("a", childMap)).toBe(0);
|
|
});
|
|
|
|
it("returns direct child count for a single-level parent", () => {
|
|
const { childMap } = buildIssueTree([
|
|
makeIssue("p"),
|
|
makeIssue("c1", "p"),
|
|
makeIssue("c2", "p"),
|
|
]);
|
|
expect(countDescendants("p", childMap)).toBe(2);
|
|
});
|
|
|
|
it("counts all descendants across multiple levels", () => {
|
|
// P → C → G1, G2 (P has 3 total descendants: C, G1, G2)
|
|
const { childMap } = buildIssueTree([
|
|
makeIssue("p"),
|
|
makeIssue("c", "p"),
|
|
makeIssue("g1", "c"),
|
|
makeIssue("g2", "c"),
|
|
]);
|
|
expect(countDescendants("p", childMap)).toBe(3);
|
|
});
|
|
|
|
it("returns 0 for an id not in the childMap", () => {
|
|
const { childMap } = buildIssueTree([makeIssue("a"), makeIssue("b")]);
|
|
expect(countDescendants("nonexistent", childMap)).toBe(0);
|
|
});
|
|
});
|
|
|
|
describe("filterIssueDescendants", () => {
|
|
it("returns only children and deeper descendants of the requested root", () => {
|
|
const root = makeIssue("root");
|
|
const child = makeIssue("child", "root");
|
|
const grandchild = makeIssue("grandchild", "child");
|
|
const unrelatedParent = makeIssue("other");
|
|
const unrelatedChild = makeIssue("other-child", "other");
|
|
|
|
expect(filterIssueDescendants("root", [
|
|
root,
|
|
child,
|
|
grandchild,
|
|
unrelatedParent,
|
|
unrelatedChild,
|
|
]).map((issue) => issue.id)).toEqual(["child", "grandchild"]);
|
|
});
|
|
|
|
it("handles stale broad issue-list responses without requiring the root in the list", () => {
|
|
const child = makeIssue("child", "root");
|
|
const grandchild = makeIssue("grandchild", "child");
|
|
const globalIssue = makeIssue("global");
|
|
|
|
expect(filterIssueDescendants("root", [
|
|
globalIssue,
|
|
child,
|
|
grandchild,
|
|
]).map((issue) => issue.id)).toEqual(["child", "grandchild"]);
|
|
});
|
|
});
|