7f893ac4ec
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Reliable execution depends on heartbeat routing, issue lifecycle semantics, telemetry, and a fast enough local verification loop to keep regressions visible > - The remaining commits on this branch were mostly server/runtime correctness fixes plus test and documentation follow-ups in that area > - Those changes are logically separate from the UI-focused issue-detail and workspace/navigation branches even when they touch overlapping issue APIs > - This pull request groups the execution reliability, heartbeat, telemetry, and tooling changes into one standalone branch > - The benefit is a focused review of the control-plane correctness work, including the follow-up fix that restored the implicit comment-reopen helpers after branch splitting ## What Changed - Hardened issue/heartbeat execution behavior, including self-review stage skipping, deferred mention wakes during active execution, stranded execution recovery, active-run scoping, assignee resolution, and blocked-to-todo wake resumption - Reduced noisy polling/logging overhead by trimming issue run payloads, compacting persisted run logs, silencing high-volume request logs, and capping heartbeat-run queries in dashboard/inbox surfaces - Expanded telemetry and status semantics with adapter/model fields on task completion plus clearer status guidance in docs/onboarding material - Updated test infrastructure and verification defaults with faster route-test module isolation, cheaper default `pnpm test`, e2e isolation from local state, and repo verification follow-ups - Included docs/release housekeeping from the branch and added a small follow-up commit restoring the implicit comment-reopen helpers that were dropped during branch reconstruction ## Verification - `pnpm vitest run server/src/__tests__/issue-comment-reopen-routes.test.ts server/src/__tests__/issue-telemetry-routes.test.ts` - `pnpm vitest run server/src/__tests__/http-log-policy.test.ts server/src/__tests__/heartbeat-run-log.test.ts server/src/__tests__/health.test.ts` - `server/src/__tests__/activity-service.test.ts`, `server/src/__tests__/heartbeat-comment-wake-batching.test.ts`, and `server/src/__tests__/heartbeat-process-recovery.test.ts` were attempted on this host but the embedded Postgres harness reported init-script/data-dir problems and skipped or failed to start, so they are noted as environment-limited ## Risks - Medium: this branch changes core issue/heartbeat routing and reopen/wakeup behavior, so regressions would affect agent execution flow rather than isolated UI polish - Because it also updates verification infrastructure, reviewers should pay attention to whether the new tests are asserting the right failure modes and not just reshaping harness behavior ## Model Used - OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact deployed model ID is not exposed in this environment), reasoning enabled, tool use and local code execution enabled ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [ ] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
218 lines
6.3 KiB
TypeScript
218 lines
6.3 KiB
TypeScript
import express from "express";
|
|
import request from "supertest";
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
const mockWakeup = vi.hoisted(() => vi.fn(async () => undefined));
|
|
const mockIssueService = vi.hoisted(() => ({
|
|
getAncestors: vi.fn(),
|
|
getById: vi.fn(),
|
|
getByIdentifier: vi.fn(async () => null),
|
|
getComment: vi.fn(),
|
|
getCommentCursor: vi.fn(),
|
|
getRelationSummaries: vi.fn(),
|
|
update: vi.fn(),
|
|
listWakeableBlockedDependents: vi.fn(),
|
|
getWakeableParentAfterChildCompletion: vi.fn(),
|
|
findMentionedAgents: vi.fn(async () => []),
|
|
}));
|
|
|
|
vi.mock("../services/index.js", () => ({
|
|
accessService: () => ({
|
|
canUser: vi.fn(),
|
|
hasPermission: vi.fn(),
|
|
}),
|
|
agentService: () => ({
|
|
getById: vi.fn(),
|
|
}),
|
|
documentService: () => ({
|
|
getIssueDocumentPayload: vi.fn(async () => ({})),
|
|
}),
|
|
executionWorkspaceService: () => ({
|
|
getById: vi.fn(),
|
|
}),
|
|
feedbackService: () => ({}),
|
|
goalService: () => ({
|
|
getById: vi.fn(),
|
|
getDefaultCompanyGoal: vi.fn(),
|
|
}),
|
|
heartbeatService: () => ({
|
|
wakeup: mockWakeup,
|
|
reportRunActivity: vi.fn(async () => undefined),
|
|
}),
|
|
instanceSettingsService: () => ({
|
|
get: vi.fn(),
|
|
listCompanyIds: vi.fn(),
|
|
}),
|
|
issueApprovalService: () => ({}),
|
|
issueService: () => mockIssueService,
|
|
logActivity: vi.fn(async () => undefined),
|
|
projectService: () => ({
|
|
getById: vi.fn(),
|
|
listByIds: vi.fn(async () => []),
|
|
}),
|
|
routineService: () => ({
|
|
syncRunStatusForIssue: vi.fn(async () => undefined),
|
|
}),
|
|
workProductService: () => ({
|
|
listForIssue: vi.fn(async () => []),
|
|
}),
|
|
}));
|
|
|
|
async function createApp() {
|
|
const [{ issueRoutes }, { errorHandler }] = await Promise.all([
|
|
vi.importActual<typeof import("../routes/issues.js")>("../routes/issues.js"),
|
|
vi.importActual<typeof import("../middleware/index.js")>("../middleware/index.js"),
|
|
]);
|
|
const app = express();
|
|
app.use(express.json());
|
|
app.use((req, _res, next) => {
|
|
(req as any).actor = {
|
|
type: "board",
|
|
userId: "local-board",
|
|
companyIds: ["company-1"],
|
|
source: "local_implicit",
|
|
isInstanceAdmin: false,
|
|
};
|
|
next();
|
|
});
|
|
app.use("/api", issueRoutes({} as any, {} as any));
|
|
app.use(errorHandler);
|
|
return app;
|
|
}
|
|
|
|
describe("issue dependency wakeups in issue routes", () => {
|
|
beforeEach(() => {
|
|
vi.resetModules();
|
|
vi.doUnmock("../routes/issues.js");
|
|
vi.doUnmock("../routes/authz.js");
|
|
vi.doUnmock("../middleware/index.js");
|
|
vi.resetAllMocks();
|
|
mockIssueService.getAncestors.mockResolvedValue([]);
|
|
mockIssueService.getComment.mockResolvedValue(null);
|
|
mockIssueService.getCommentCursor.mockResolvedValue({
|
|
totalComments: 0,
|
|
latestCommentId: null,
|
|
latestCommentAt: null,
|
|
});
|
|
mockIssueService.getRelationSummaries.mockResolvedValue({ blockedBy: [], blocks: [] });
|
|
mockIssueService.listWakeableBlockedDependents.mockResolvedValue([]);
|
|
mockIssueService.getWakeableParentAfterChildCompletion.mockResolvedValue(null);
|
|
});
|
|
|
|
it("wakes dependents when the final blocker transitions to done", async () => {
|
|
mockIssueService.getById.mockResolvedValue({
|
|
id: "issue-1",
|
|
companyId: "company-1",
|
|
identifier: "PAP-100",
|
|
title: "Finish blocker",
|
|
description: null,
|
|
status: "blocked",
|
|
priority: "medium",
|
|
parentId: null,
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: null,
|
|
executionWorkspaceId: null,
|
|
labels: [],
|
|
labelIds: [],
|
|
});
|
|
mockIssueService.update.mockResolvedValue({
|
|
id: "issue-1",
|
|
companyId: "company-1",
|
|
identifier: "PAP-100",
|
|
title: "Finish blocker",
|
|
description: null,
|
|
status: "done",
|
|
priority: "medium",
|
|
parentId: null,
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: null,
|
|
executionWorkspaceId: null,
|
|
labels: [],
|
|
labelIds: [],
|
|
});
|
|
mockIssueService.listWakeableBlockedDependents.mockResolvedValue([
|
|
{
|
|
id: "issue-2",
|
|
assigneeAgentId: "agent-2",
|
|
blockerIssueIds: ["issue-1", "issue-3"],
|
|
},
|
|
]);
|
|
|
|
const res = await request(await createApp()).patch("/api/issues/issue-1").send({ status: "done" });
|
|
expect(res.status).toBe(200);
|
|
await vi.waitFor(() => {
|
|
expect(mockWakeup).toHaveBeenCalledWith(
|
|
"agent-2",
|
|
expect.objectContaining({
|
|
reason: "issue_blockers_resolved",
|
|
payload: expect.objectContaining({
|
|
issueId: "issue-2",
|
|
resolvedBlockerIssueId: "issue-1",
|
|
}),
|
|
}),
|
|
);
|
|
});
|
|
});
|
|
|
|
it("wakes the parent when all direct children become terminal", async () => {
|
|
mockIssueService.getById.mockResolvedValue({
|
|
id: "child-1",
|
|
companyId: "company-1",
|
|
identifier: "PAP-101",
|
|
title: "Last child",
|
|
description: null,
|
|
status: "in_progress",
|
|
priority: "medium",
|
|
parentId: "parent-1",
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: null,
|
|
executionWorkspaceId: null,
|
|
labels: [],
|
|
labelIds: [],
|
|
});
|
|
mockIssueService.update.mockResolvedValue({
|
|
id: "child-1",
|
|
companyId: "company-1",
|
|
identifier: "PAP-101",
|
|
title: "Last child",
|
|
description: null,
|
|
status: "done",
|
|
priority: "medium",
|
|
parentId: "parent-1",
|
|
assigneeAgentId: "agent-1",
|
|
assigneeUserId: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: null,
|
|
executionWorkspaceId: null,
|
|
labels: [],
|
|
labelIds: [],
|
|
});
|
|
mockIssueService.getWakeableParentAfterChildCompletion.mockResolvedValue({
|
|
id: "parent-1",
|
|
assigneeAgentId: "agent-9",
|
|
childIssueIds: ["child-0", "child-1"],
|
|
});
|
|
|
|
const res = await request(await createApp()).patch("/api/issues/child-1").send({ status: "done" });
|
|
expect(res.status).toBe(200);
|
|
await vi.waitFor(() => {
|
|
expect(mockWakeup).toHaveBeenCalledWith(
|
|
"agent-9",
|
|
expect.objectContaining({
|
|
reason: "issue_children_completed",
|
|
payload: expect.objectContaining({
|
|
issueId: "parent-1",
|
|
completedChildIssueId: "child-1",
|
|
}),
|
|
}),
|
|
);
|
|
});
|
|
});
|
|
});
|