bb7d040894
> **Stacked PR (part 4 of 7).** Depends on: - PR #5114 - PR #5115 - PR #5116 > Diff against `master` includes commits from earlier PRs in the stack — the new commit in this PR is the topmost one. ## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - When creating an OpenCode-local agent, Paperclip currently validates > `adapterConfig.model` against the *Paperclip host's* `opencode models` output > - SSH testing surfaced that this blocks creating an OpenCode agent for an SSH > environment: the model that exists on the SSH target isn't visible to the > host, so creation fails with "OpenCode requires `adapterConfig.model` in > provider/model format" even when the operator picked a real remote model > - The initial direction was environment-aware model discovery; the final > decision was to keep OpenCode on the same explicit-model pattern as other > adapters (default + curated list + manual override) and stop blocking > creation on host-side discovery > - This PR does both: the adapter-models endpoint now accepts `environmentId` and > probes against the target environment, and the create-time hard gate is > replaced by `requireOpenCodeModelId` which validates `provider/model` *format* > without requiring host-local discovery. Test/run-time still surfaces real > auth/availability problems > - The benefit is that operators can create OpenCode agents for remote > environments without out-of-band setup, and the model picker in the UI > reflects the actually-targeted environment ## What Changed - Added `requireOpenCodeModelId(input)` in `opencode-local/src/server/models.ts`, exported it from the adapter index - `ensureOpenCodeModelConfiguredAndAvailable` now delegates the format check to `requireOpenCodeModelId` - `agentsApi.adapterModels(companyId, adapterType, { environmentId })` now accepts an environment ID and passes it as a query parameter - `queryKeys.agents.adapterModels` now keys on `(companyId, adapterType, environmentId)` - `server/src/routes/agents.ts` reads and validates the new query parameter, forwarding it to the adapter's model probe - `AgentConfigForm.tsx` and `OnboardingWizard.tsx` build the model query key from the currently selected default environment ID and disable autodetect for `opencode_local` (model selection is explicit) - `NewAgent.tsx` simplified — no longer special-cases OpenCode autodetect - `company-portability.ts` no longer needs OpenCode-specific autodetect handling - Tests added/updated: `adapter-model-refresh-routes.test.ts`, `adapter-models.test.ts`, `agent-permissions-routes.test.ts`, `opencode-local/src/server/models.test.ts` ## Verification - `pnpm --filter @paperclipai/server test -- adapter-models adapter-model-refresh agent-permissions` - `pnpm --filter @paperclipai/adapter-opencode-local test` - `pnpm --filter @paperclipai/ui test -- AgentConfigForm OnboardingWizard NewAgent` - Manual QA in browser: 1. Boot Paperclip on Tailscale-bound port (so it's reachable from another machine), create an OpenCode-local agent, switch the default environment between two installed sandboxes, and confirm the model list refreshes per-environment 2. Submit with a malformed `provider/model` string and verify the new `requireOpenCodeModelId` error surfaces - Before/after screenshots attached for `AgentConfigForm` model picker ## Risks - Behavioural shift: switching default environment now triggers a model refetch. Should be cheap but introduces a new UI loading state for OpenCode users. - Removing dynamic autodetect for OpenCode: if any user configured an agent without specifying `model` and relied on autodetect populating it, that agent will now fail at submit time. Mitigation: validation error is explicit and actionable. - New query string parameter on `/api/companies/:id/adapter-models` — older clients that omit it still work (parameter is optional and defaults to null). ## Model Used - OpenAI GPT-5.4 (reasoning effort: high) via Codex CLI - Provider: OpenAI - Used to author the code changes in this PR ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [ ] I have updated relevant documentation to reflect my changes — N/A - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge
353 lines
13 KiB
TypeScript
353 lines
13 KiB
TypeScript
import { useState, useEffect, useCallback } from "react";
|
|
import { useQuery, useMutation, useQueryClient } from "@tanstack/react-query";
|
|
import { useNavigate, useSearchParams } from "@/lib/router";
|
|
import { useCompany } from "../context/CompanyContext";
|
|
import { useBreadcrumbs } from "../context/BreadcrumbContext";
|
|
import { agentsApi } from "../api/agents";
|
|
import { companySkillsApi } from "../api/companySkills";
|
|
import { queryKeys } from "../lib/queryKeys";
|
|
import { AGENT_ROLES, type AdapterEnvironmentTestResult } from "@paperclipai/shared";
|
|
import { Button } from "@/components/ui/button";
|
|
import { Checkbox } from "@/components/ui/checkbox";
|
|
import {
|
|
Popover,
|
|
PopoverContent,
|
|
PopoverTrigger,
|
|
} from "@/components/ui/popover";
|
|
import { Shield } from "lucide-react";
|
|
import { cn, agentUrl } from "../lib/utils";
|
|
import { roleLabels } from "../components/agent-config-primitives";
|
|
import {
|
|
AgentConfigForm,
|
|
AdapterEnvironmentResult,
|
|
type CreateConfigValues,
|
|
} from "../components/AgentConfigForm";
|
|
import { defaultCreateValues } from "../components/agent-config-defaults";
|
|
import { getUIAdapter, listUIAdapters } from "../adapters";
|
|
import { useDisabledAdaptersSync } from "../adapters/use-disabled-adapters";
|
|
import { isValidAdapterType } from "../adapters/metadata";
|
|
import { ReportsToPicker } from "../components/ReportsToPicker";
|
|
import { buildNewAgentHirePayload } from "../lib/new-agent-hire-payload";
|
|
import {
|
|
DEFAULT_CODEX_LOCAL_BYPASS_APPROVALS_AND_SANDBOX,
|
|
DEFAULT_CODEX_LOCAL_MODEL,
|
|
} from "@paperclipai/adapter-codex-local";
|
|
import { DEFAULT_CURSOR_LOCAL_MODEL } from "@paperclipai/adapter-cursor-local";
|
|
import { DEFAULT_GEMINI_LOCAL_MODEL } from "@paperclipai/adapter-gemini-local";
|
|
import { DEFAULT_OPENCODE_LOCAL_MODEL, isValidOpenCodeModelId } from "@paperclipai/adapter-opencode-local";
|
|
|
|
function createValuesForAdapterType(
|
|
adapterType: CreateConfigValues["adapterType"],
|
|
): CreateConfigValues {
|
|
const { adapterType: _discard, ...defaults } = defaultCreateValues;
|
|
const nextValues: CreateConfigValues = { ...defaults, adapterType };
|
|
if (adapterType === "codex_local") {
|
|
nextValues.model = DEFAULT_CODEX_LOCAL_MODEL;
|
|
nextValues.dangerouslyBypassSandbox =
|
|
DEFAULT_CODEX_LOCAL_BYPASS_APPROVALS_AND_SANDBOX;
|
|
} else if (adapterType === "gemini_local") {
|
|
nextValues.model = DEFAULT_GEMINI_LOCAL_MODEL;
|
|
} else if (adapterType === "cursor") {
|
|
nextValues.model = DEFAULT_CURSOR_LOCAL_MODEL;
|
|
} else if (adapterType === "opencode_local") {
|
|
nextValues.model = DEFAULT_OPENCODE_LOCAL_MODEL;
|
|
}
|
|
return nextValues;
|
|
}
|
|
|
|
export function NewAgent() {
|
|
const { selectedCompanyId } = useCompany();
|
|
const { setBreadcrumbs } = useBreadcrumbs();
|
|
const queryClient = useQueryClient();
|
|
const navigate = useNavigate();
|
|
const [searchParams] = useSearchParams();
|
|
const presetAdapterType = searchParams.get("adapterType");
|
|
|
|
const [name, setName] = useState("");
|
|
const [title, setTitle] = useState("");
|
|
const [role, setRole] = useState("general");
|
|
const [reportsTo, setReportsTo] = useState<string | null>(null);
|
|
const [configValues, setConfigValues] = useState<CreateConfigValues>(defaultCreateValues);
|
|
const [selectedSkillKeys, setSelectedSkillKeys] = useState<string[]>([]);
|
|
const [roleOpen, setRoleOpen] = useState(false);
|
|
const [formError, setFormError] = useState<string | null>(null);
|
|
const [testAgentAction, setTestAgentAction] = useState<(() => void) | null>(null);
|
|
const [testAgentState, setTestAgentState] = useState({ disabled: true, pending: false });
|
|
const [testAgentFeedback, setTestAgentFeedback] = useState<{
|
|
errorMessage: string | null;
|
|
result: AdapterEnvironmentTestResult | null;
|
|
}>({
|
|
errorMessage: null,
|
|
result: null,
|
|
});
|
|
|
|
const { data: agents } = useQuery({
|
|
queryKey: queryKeys.agents.list(selectedCompanyId!),
|
|
queryFn: () => agentsApi.list(selectedCompanyId!),
|
|
enabled: !!selectedCompanyId,
|
|
});
|
|
|
|
const { data: companySkills } = useQuery({
|
|
queryKey: queryKeys.companySkills.list(selectedCompanyId ?? ""),
|
|
queryFn: () => companySkillsApi.list(selectedCompanyId!),
|
|
enabled: Boolean(selectedCompanyId),
|
|
});
|
|
|
|
const isFirstAgent = !agents || agents.length === 0;
|
|
const effectiveRole = isFirstAgent ? "ceo" : role;
|
|
|
|
useEffect(() => {
|
|
setBreadcrumbs([
|
|
{ label: "Agents", href: "/agents" },
|
|
{ label: "New Agent" },
|
|
]);
|
|
}, [setBreadcrumbs]);
|
|
|
|
useEffect(() => {
|
|
if (isFirstAgent) {
|
|
if (!name) setName("CEO");
|
|
if (!title) setTitle("CEO");
|
|
}
|
|
}, [isFirstAgent]); // eslint-disable-line react-hooks/exhaustive-deps
|
|
|
|
useEffect(() => {
|
|
const requested = presetAdapterType;
|
|
if (!requested) return;
|
|
if (!isValidAdapterType(requested)) return;
|
|
setConfigValues((prev) => {
|
|
if (prev.adapterType === requested) return prev;
|
|
return createValuesForAdapterType(requested as CreateConfigValues["adapterType"]);
|
|
});
|
|
}, [presetAdapterType]);
|
|
|
|
const createAgent = useMutation({
|
|
mutationFn: (data: Record<string, unknown>) =>
|
|
agentsApi.hire(selectedCompanyId!, data),
|
|
onSuccess: (result) => {
|
|
queryClient.invalidateQueries({ queryKey: queryKeys.agents.list(selectedCompanyId!) });
|
|
queryClient.invalidateQueries({ queryKey: queryKeys.approvals.list(selectedCompanyId!) });
|
|
navigate(agentUrl(result.agent));
|
|
},
|
|
onError: (error) => {
|
|
setFormError(error instanceof Error ? error.message : "Failed to create agent");
|
|
},
|
|
});
|
|
|
|
function buildAdapterConfig() {
|
|
const adapter = getUIAdapter(configValues.adapterType);
|
|
return adapter.buildAdapterConfig(configValues);
|
|
}
|
|
|
|
function handleSubmit() {
|
|
if (!selectedCompanyId || !name.trim()) return;
|
|
setFormError(null);
|
|
if (configValues.adapterType === "opencode_local") {
|
|
if (!isValidOpenCodeModelId(configValues.model)) {
|
|
setFormError("OpenCode requires an explicit model in provider/model format.");
|
|
return;
|
|
}
|
|
}
|
|
createAgent.mutate(
|
|
buildNewAgentHirePayload({
|
|
name,
|
|
effectiveRole,
|
|
title,
|
|
reportsTo,
|
|
selectedSkillKeys,
|
|
configValues,
|
|
adapterConfig: buildAdapterConfig(),
|
|
}),
|
|
);
|
|
}
|
|
|
|
const availableSkills = (companySkills ?? []).filter((skill) => !skill.key.startsWith("paperclipai/paperclip/"));
|
|
|
|
function toggleSkill(key: string, checked: boolean) {
|
|
setSelectedSkillKeys((prev) => {
|
|
if (checked) {
|
|
return prev.includes(key) ? prev : [...prev, key];
|
|
}
|
|
return prev.filter((value) => value !== key);
|
|
});
|
|
}
|
|
|
|
const handleTestAgentActionChange = useCallback((fn: (() => void) | null) => {
|
|
setTestAgentAction(() => fn);
|
|
}, []);
|
|
|
|
const handleTestAgentStateChange = useCallback((state: { disabled: boolean; pending: boolean }) => {
|
|
setTestAgentState(state);
|
|
}, []);
|
|
|
|
const handleTestAgentFeedbackChange = useCallback((feedback: {
|
|
errorMessage: string | null;
|
|
result: AdapterEnvironmentTestResult | null;
|
|
}) => {
|
|
setTestAgentFeedback(feedback);
|
|
}, []);
|
|
|
|
return (
|
|
<div className="mx-auto max-w-2xl space-y-6">
|
|
<div>
|
|
<h1 className="text-lg font-semibold">New Agent</h1>
|
|
<p className="text-sm text-muted-foreground mt-1">
|
|
Advanced agent configuration
|
|
</p>
|
|
</div>
|
|
|
|
<div className="border border-border">
|
|
{/* Name */}
|
|
<div className="px-4 pt-4 pb-2">
|
|
<input
|
|
className="w-full text-lg font-semibold bg-transparent outline-none placeholder:text-muted-foreground/50"
|
|
placeholder="Agent name"
|
|
value={name}
|
|
onChange={(e) => setName(e.target.value)}
|
|
autoFocus
|
|
/>
|
|
</div>
|
|
|
|
{/* Title */}
|
|
<div className="px-4 pb-2">
|
|
<input
|
|
className="w-full bg-transparent outline-none text-sm text-muted-foreground placeholder:text-muted-foreground/40"
|
|
placeholder="Title (e.g. VP of Engineering)"
|
|
value={title}
|
|
onChange={(e) => setTitle(e.target.value)}
|
|
/>
|
|
</div>
|
|
|
|
{/* Property chips: Role + Reports To */}
|
|
<div className="flex items-center gap-1.5 px-4 py-2 border-t border-border flex-wrap">
|
|
<Popover open={roleOpen} onOpenChange={setRoleOpen}>
|
|
<PopoverTrigger asChild>
|
|
<button
|
|
className={cn(
|
|
"inline-flex items-center gap-1.5 rounded-md border border-border px-2 py-1 text-xs hover:bg-accent/50 transition-colors",
|
|
isFirstAgent && "opacity-60 cursor-not-allowed"
|
|
)}
|
|
disabled={isFirstAgent}
|
|
>
|
|
<Shield className="h-3 w-3 text-muted-foreground" />
|
|
{roleLabels[effectiveRole] ?? effectiveRole}
|
|
</button>
|
|
</PopoverTrigger>
|
|
<PopoverContent className="w-36 p-1" align="start">
|
|
{AGENT_ROLES.map((r) => (
|
|
<button
|
|
key={r}
|
|
className={cn(
|
|
"flex items-center gap-2 w-full px-2 py-1.5 text-xs rounded hover:bg-accent/50",
|
|
r === role && "bg-accent"
|
|
)}
|
|
onClick={() => { setRole(r); setRoleOpen(false); }}
|
|
>
|
|
{roleLabels[r] ?? r}
|
|
</button>
|
|
))}
|
|
</PopoverContent>
|
|
</Popover>
|
|
|
|
<ReportsToPicker
|
|
agents={agents ?? []}
|
|
value={reportsTo}
|
|
onChange={setReportsTo}
|
|
disabled={isFirstAgent}
|
|
/>
|
|
</div>
|
|
|
|
{/* Shared config form */}
|
|
<AgentConfigForm
|
|
mode="create"
|
|
values={configValues}
|
|
onChange={(patch) => setConfigValues((prev) => ({ ...prev, ...patch }))}
|
|
onTestActionChange={handleTestAgentActionChange}
|
|
onTestActionStateChange={handleTestAgentStateChange}
|
|
onTestFeedbackChange={handleTestAgentFeedbackChange}
|
|
/>
|
|
|
|
<div className="border-t border-border px-4 py-4">
|
|
<div className="space-y-3">
|
|
<div>
|
|
<h2 className="text-sm font-medium">Company skills</h2>
|
|
<p className="mt-1 text-xs text-muted-foreground">
|
|
Optional skills from the company library. Built-in Paperclip runtime skills are added automatically.
|
|
</p>
|
|
</div>
|
|
{availableSkills.length === 0 ? (
|
|
<p className="text-xs text-muted-foreground">
|
|
No optional company skills installed yet.
|
|
</p>
|
|
) : (
|
|
<div className="space-y-3">
|
|
{availableSkills.map((skill) => {
|
|
const inputId = `skill-${skill.id}`;
|
|
const checked = selectedSkillKeys.includes(skill.key);
|
|
return (
|
|
<div key={skill.id} className="flex items-start gap-3">
|
|
<Checkbox
|
|
id={inputId}
|
|
checked={checked}
|
|
onCheckedChange={(next) => toggleSkill(skill.key, next === true)}
|
|
/>
|
|
<label htmlFor={inputId} className="grid gap-1 leading-none">
|
|
<span className="text-sm font-medium">{skill.name}</span>
|
|
<span className="text-xs text-muted-foreground">
|
|
{skill.description ?? skill.key}
|
|
</span>
|
|
</label>
|
|
</div>
|
|
);
|
|
})}
|
|
</div>
|
|
)}
|
|
</div>
|
|
</div>
|
|
|
|
{/* Footer */}
|
|
<div className="border-t border-border px-4 py-3">
|
|
{isFirstAgent && (
|
|
<p className="text-xs text-muted-foreground mb-2">This will be the CEO</p>
|
|
)}
|
|
{formError && (
|
|
<p className="text-xs text-destructive mb-2">{formError}</p>
|
|
)}
|
|
<div className="space-y-3">
|
|
{testAgentFeedback.errorMessage && (
|
|
<div className="rounded-md border border-destructive/30 bg-destructive/10 px-3 py-2 text-xs text-destructive">
|
|
{testAgentFeedback.errorMessage}
|
|
</div>
|
|
)}
|
|
{testAgentFeedback.result && (
|
|
<AdapterEnvironmentResult result={testAgentFeedback.result} />
|
|
)}
|
|
<div className="flex items-center justify-between gap-2">
|
|
<Button variant="outline" size="sm" onClick={() => navigate("/agents")}>
|
|
Cancel
|
|
</Button>
|
|
<div className="flex items-center gap-2">
|
|
<Button
|
|
type="button"
|
|
variant="outline"
|
|
size="sm"
|
|
disabled={testAgentState.disabled}
|
|
onClick={() => testAgentAction?.()}
|
|
>
|
|
{testAgentState.pending ? "Testing..." : "Test Agent"}
|
|
</Button>
|
|
<Button
|
|
size="sm"
|
|
disabled={!name.trim() || createAgent.isPending}
|
|
onClick={handleSubmit}
|
|
>
|
|
{createAgent.isPending ? "Creating…" : "Create agent"}
|
|
</Button>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|