548721248e
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - Board users and agents collaborate on issue-scoped documents such as plans and revisions need to be trustworthy because they are the audit trail for those artifacts. > - The issue document UI now supports revision history and restore, so the UI has to distinguish the current revision from historical revisions correctly even while multiple queries are refreshing. > - In `PAPA-72`, the newest content could appear under an older revision label because the current document snapshot and the revision-history query could temporarily disagree after an edit. > - That made the UI treat the newest revision like a historical restore target, which is the opposite of the intended behavior. > - This pull request derives one authoritative revision view from both sources, sorts revisions newest-first, and keeps the freshest revision marked current. > - The benefit is that revision history stays stable and trustworthy immediately after edits instead of briefly presenting the newest content as an older revision. ## What Changed - Added a `document-revisions` helper that merges the current document snapshot with fetched revision history into one normalized revision state. - Updated `IssueDocumentsSection` to render from that normalized state instead of trusting either query in isolation. - Added focused tests covering the current-revision selection and ordering behavior. ## Verification - `pnpm -r typecheck` - `pnpm build` - Targeted revision tests passed locally. - Manual reviewer check: - Open an issue document with revision history. - Edit and save the document. - Immediately open the revision selector. - Confirm the newest revision remains marked current and older revisions remain the restore targets. ## Risks - Low risk. The change is isolated to issue document revision presentation in the UI. - Main risk is merging the current snapshot with fetched history incorrectly for edge cases, which is why the helper has focused unit coverage. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [ ] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge
584 lines
17 KiB
TypeScript
584 lines
17 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act } from "react";
|
|
import type { ComponentProps } from "react";
|
|
import { createRoot } from "react-dom/client";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import type { DocumentRevision, Issue, IssueDocument } from "@paperclipai/shared";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { IssueDocumentsSection } from "./IssueDocumentsSection";
|
|
import { queryKeys } from "../lib/queryKeys";
|
|
|
|
const mockIssuesApi = vi.hoisted(() => ({
|
|
listDocuments: vi.fn(),
|
|
listDocumentRevisions: vi.fn(),
|
|
restoreDocumentRevision: vi.fn(),
|
|
upsertDocument: vi.fn(),
|
|
deleteDocument: vi.fn(),
|
|
getDocument: vi.fn(),
|
|
}));
|
|
|
|
const markdownEditorMockState = vi.hoisted(() => ({
|
|
emitMountEmptyChange: false,
|
|
}));
|
|
|
|
vi.mock("../api/issues", () => ({
|
|
issuesApi: mockIssuesApi,
|
|
}));
|
|
|
|
vi.mock("../hooks/useAutosaveIndicator", () => ({
|
|
useAutosaveIndicator: () => ({
|
|
state: "idle",
|
|
markDirty: vi.fn(),
|
|
reset: vi.fn(),
|
|
runSave: async (save: () => Promise<unknown>) => save(),
|
|
}),
|
|
}));
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
useLocation: () => ({ hash: "" }),
|
|
}));
|
|
|
|
vi.mock("./MarkdownBody", () => ({
|
|
MarkdownBody: ({ children, className }: { children: string; className?: string }) => (
|
|
<div className={className}>{children}</div>
|
|
),
|
|
}));
|
|
|
|
vi.mock("./MarkdownEditor", async () => {
|
|
const React = await import("react");
|
|
|
|
return {
|
|
MarkdownEditor: ({ value, onChange, placeholder, contentClassName }: {
|
|
value: string;
|
|
onChange?: (value: string) => void;
|
|
placeholder?: string;
|
|
contentClassName?: string;
|
|
}) => {
|
|
React.useEffect(() => {
|
|
if (!markdownEditorMockState.emitMountEmptyChange) return;
|
|
onChange?.("");
|
|
}, []);
|
|
|
|
return (
|
|
<div className={contentClassName} data-testid="markdown-editor">
|
|
{value || placeholder || ""}
|
|
</div>
|
|
);
|
|
},
|
|
};
|
|
});
|
|
|
|
vi.mock("@/components/ui/button", () => ({
|
|
Button: ({ children, onClick, type = "button", ...props }: ComponentProps<"button">) => (
|
|
<button type={type} onClick={onClick} {...props}>{children}</button>
|
|
),
|
|
}));
|
|
|
|
vi.mock("@/components/ui/input", () => ({
|
|
Input: (props: ComponentProps<"input">) => <input {...props} />,
|
|
}));
|
|
|
|
vi.mock("@/components/ui/dropdown-menu", async () => {
|
|
return {
|
|
DropdownMenu: ({ children }: { children: React.ReactNode }) => <div>{children}</div>,
|
|
DropdownMenuTrigger: ({ children }: { children: React.ReactNode }) => <>{children}</>,
|
|
DropdownMenuContent: ({ children }: { children: React.ReactNode }) => <div>{children}</div>,
|
|
DropdownMenuItem: ({ children, onClick, onSelect, disabled }: {
|
|
children: React.ReactNode;
|
|
onClick?: () => void;
|
|
onSelect?: () => void;
|
|
disabled?: boolean;
|
|
}) => (
|
|
<button
|
|
type="button"
|
|
disabled={disabled}
|
|
onClick={() => {
|
|
onSelect?.();
|
|
onClick?.();
|
|
}}
|
|
>
|
|
{children}
|
|
</button>
|
|
),
|
|
DropdownMenuLabel: ({ children }: { children: React.ReactNode }) => <div>{children}</div>,
|
|
DropdownMenuRadioGroup: ({ children }: { children: React.ReactNode }) => <div>{children}</div>,
|
|
DropdownMenuRadioItem: ({ children, onSelect, disabled }: {
|
|
children: React.ReactNode;
|
|
onSelect?: () => void;
|
|
disabled?: boolean;
|
|
}) => (
|
|
<button type="button" disabled={disabled} onClick={() => onSelect?.()}>
|
|
{children}
|
|
</button>
|
|
),
|
|
DropdownMenuSeparator: () => <hr />,
|
|
};
|
|
});
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
const localStorageEntries = new Map<string, string>();
|
|
|
|
function ensureLocalStorageMock() {
|
|
if (
|
|
typeof window.localStorage?.getItem === "function"
|
|
&& typeof window.localStorage?.setItem === "function"
|
|
&& typeof window.localStorage?.removeItem === "function"
|
|
&& typeof window.localStorage?.clear === "function"
|
|
) {
|
|
return;
|
|
}
|
|
|
|
Object.defineProperty(window, "localStorage", {
|
|
configurable: true,
|
|
value: {
|
|
getItem: (key: string) => localStorageEntries.get(key) ?? null,
|
|
setItem: (key: string, value: string) => {
|
|
localStorageEntries.set(key, value);
|
|
},
|
|
removeItem: (key: string) => {
|
|
localStorageEntries.delete(key);
|
|
},
|
|
clear: () => {
|
|
localStorageEntries.clear();
|
|
},
|
|
},
|
|
});
|
|
}
|
|
|
|
function deferred<T>() {
|
|
let resolve!: (value: T) => void;
|
|
const promise = new Promise<T>((res) => {
|
|
resolve = res;
|
|
});
|
|
return { promise, resolve };
|
|
}
|
|
|
|
async function flush() {
|
|
await act(async () => {
|
|
await new Promise((resolve) => setTimeout(resolve, 0));
|
|
});
|
|
}
|
|
|
|
function createIssueDocument(overrides: Partial<IssueDocument> = {}): IssueDocument {
|
|
return {
|
|
id: "document-1",
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
key: "plan",
|
|
title: "Plan",
|
|
format: "markdown",
|
|
body: "",
|
|
latestRevisionId: "revision-4",
|
|
latestRevisionNumber: 4,
|
|
createdByAgentId: null,
|
|
createdByUserId: "user-1",
|
|
updatedByAgentId: null,
|
|
updatedByUserId: "user-1",
|
|
createdAt: new Date("2026-03-31T12:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-31T12:05:00.000Z"),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function createRevision(overrides: Partial<DocumentRevision> = {}): DocumentRevision {
|
|
return {
|
|
id: "revision-3",
|
|
companyId: "company-1",
|
|
documentId: "document-1",
|
|
issueId: "issue-1",
|
|
key: "plan",
|
|
revisionNumber: 3,
|
|
title: "Plan",
|
|
format: "markdown",
|
|
body: "Restored plan body",
|
|
changeSummary: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "user-1",
|
|
createdAt: new Date("2026-03-31T11:00:00.000Z"),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function createIssue(): Issue {
|
|
return {
|
|
id: "issue-1",
|
|
identifier: "PAP-807",
|
|
companyId: "company-1",
|
|
projectId: null,
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId: null,
|
|
title: "Plan rendering",
|
|
description: null,
|
|
status: "in_progress",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: "user-1",
|
|
issueNumber: 807,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
labels: [],
|
|
labelIds: [],
|
|
planDocument: createIssueDocument(),
|
|
documentSummaries: [createIssueDocument()],
|
|
legacyPlanDocument: null,
|
|
createdAt: new Date("2026-03-31T12:00:00.000Z"),
|
|
updatedAt: new Date("2026-03-31T12:05:00.000Z"),
|
|
};
|
|
}
|
|
|
|
describe("IssueDocumentsSection", () => {
|
|
let container: HTMLDivElement;
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
ensureLocalStorageMock();
|
|
window.localStorage.clear();
|
|
vi.clearAllMocks();
|
|
markdownEditorMockState.emitMountEmptyChange = false;
|
|
});
|
|
|
|
afterEach(() => {
|
|
container.remove();
|
|
});
|
|
|
|
it("shows the restored document body immediately after a revision restore", async () => {
|
|
const blankLatestDocument = createIssueDocument({
|
|
body: "",
|
|
latestRevisionId: "revision-4",
|
|
latestRevisionNumber: 4,
|
|
});
|
|
const restoredDocument = createIssueDocument({
|
|
body: "Restored plan body",
|
|
latestRevisionId: "revision-5",
|
|
latestRevisionNumber: 5,
|
|
updatedAt: new Date("2026-03-31T12:06:00.000Z"),
|
|
});
|
|
const pendingDocuments = deferred<IssueDocument[]>();
|
|
const issue = createIssue();
|
|
const root = createRoot(container);
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: {
|
|
queries: {
|
|
retry: false,
|
|
},
|
|
mutations: {
|
|
retry: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
mockIssuesApi.listDocuments
|
|
.mockResolvedValueOnce([blankLatestDocument])
|
|
.mockImplementation(() => pendingDocuments.promise);
|
|
mockIssuesApi.restoreDocumentRevision.mockResolvedValue(restoredDocument);
|
|
queryClient.setQueryData(
|
|
queryKeys.issues.documentRevisions(issue.id, "plan"),
|
|
[
|
|
createRevision({ id: "revision-4", revisionNumber: 4, body: "", createdAt: new Date("2026-03-31T12:05:00.000Z") }),
|
|
createRevision(),
|
|
],
|
|
);
|
|
|
|
await act(async () => {
|
|
root.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<IssueDocumentsSection issue={issue} canDeleteDocuments={false} />
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
await flush();
|
|
await flush();
|
|
|
|
expect(container.textContent).not.toContain("Restored plan body");
|
|
|
|
const revisionButtons = Array.from(container.querySelectorAll("button"));
|
|
const historicalRevisionButton = revisionButtons.find((button) => button.textContent?.includes("rev 3"));
|
|
expect(historicalRevisionButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
historicalRevisionButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(container.textContent).toContain("Viewing revision 3");
|
|
expect(container.textContent).toContain("Restored plan body");
|
|
|
|
const restoreButton = Array.from(container.querySelectorAll("button"))
|
|
.find((button) => button.textContent?.includes("Restore this revision"));
|
|
expect(restoreButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
restoreButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(mockIssuesApi.restoreDocumentRevision).toHaveBeenCalledWith("issue-1", "plan", "revision-3");
|
|
expect(container.textContent).toContain("Restored plan body");
|
|
expect(container.textContent).not.toContain("Viewing revision 3");
|
|
|
|
pendingDocuments.resolve([restoredDocument]);
|
|
await flush();
|
|
await act(async () => {
|
|
root.unmount();
|
|
});
|
|
queryClient.clear();
|
|
});
|
|
|
|
it("returns from a historical preview when the current revision only exists in derived state", async () => {
|
|
const currentDocument = createIssueDocument({
|
|
body: "Current plan body",
|
|
latestRevisionId: "revision-4",
|
|
latestRevisionNumber: 4,
|
|
updatedAt: new Date("2026-03-31T12:05:00.000Z"),
|
|
});
|
|
const issue = createIssue();
|
|
const root = createRoot(container);
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: {
|
|
queries: {
|
|
retry: false,
|
|
},
|
|
mutations: {
|
|
retry: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
mockIssuesApi.listDocuments.mockResolvedValue([currentDocument]);
|
|
queryClient.setQueryData(
|
|
queryKeys.issues.documentRevisions(issue.id, "plan"),
|
|
[
|
|
createRevision({
|
|
id: "revision-3",
|
|
revisionNumber: 3,
|
|
body: "Historical plan body",
|
|
createdAt: new Date("2026-03-31T11:00:00.000Z"),
|
|
}),
|
|
],
|
|
);
|
|
|
|
await act(async () => {
|
|
root.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<IssueDocumentsSection issue={issue} canDeleteDocuments={false} />
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
await flush();
|
|
await flush();
|
|
|
|
expect(container.textContent).toContain("Current plan body");
|
|
|
|
const revisionButtons = Array.from(container.querySelectorAll("button"));
|
|
const historicalRevisionButton = revisionButtons.find((button) => button.textContent?.includes("rev 3"));
|
|
expect(historicalRevisionButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
historicalRevisionButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(container.textContent).toContain("Viewing revision 3");
|
|
expect(container.textContent).toContain("Historical plan body");
|
|
|
|
const currentRevisionButton = Array.from(container.querySelectorAll("button"))
|
|
.find((button) => button.textContent?.includes("rev 4"));
|
|
expect(currentRevisionButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
currentRevisionButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(container.textContent).not.toContain("Viewing revision 3");
|
|
expect(container.textContent).toContain("Current plan body");
|
|
|
|
await act(async () => {
|
|
root.unmount();
|
|
});
|
|
queryClient.clear();
|
|
});
|
|
|
|
it("returns from a historical preview when fetched history is newer than the document summary", async () => {
|
|
const staleDocument = createIssueDocument({
|
|
body: "Original plan body",
|
|
latestRevisionId: "revision-2",
|
|
latestRevisionNumber: 2,
|
|
updatedAt: new Date("2026-03-31T12:00:00.000Z"),
|
|
});
|
|
const issue = createIssue();
|
|
const root = createRoot(container);
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: {
|
|
queries: {
|
|
retry: false,
|
|
},
|
|
mutations: {
|
|
retry: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
mockIssuesApi.listDocuments.mockResolvedValue([staleDocument]);
|
|
queryClient.setQueryData(
|
|
queryKeys.issues.documentRevisions(issue.id, "plan"),
|
|
[
|
|
createRevision({
|
|
id: "revision-3",
|
|
revisionNumber: 3,
|
|
body: "Current plan body",
|
|
createdAt: new Date("2026-03-31T12:05:00.000Z"),
|
|
}),
|
|
createRevision({
|
|
id: "revision-2",
|
|
revisionNumber: 2,
|
|
body: "Original plan body",
|
|
createdAt: new Date("2026-03-31T12:00:00.000Z"),
|
|
}),
|
|
],
|
|
);
|
|
|
|
await act(async () => {
|
|
root.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<IssueDocumentsSection issue={issue} canDeleteDocuments={false} />
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
await flush();
|
|
await flush();
|
|
|
|
expect(container.textContent).toContain("Current plan body");
|
|
|
|
const revisionButtons = Array.from(container.querySelectorAll("button"));
|
|
const historicalRevisionButton = revisionButtons.find((button) => button.textContent?.includes("rev 2"));
|
|
expect(historicalRevisionButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
historicalRevisionButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(container.textContent).toContain("Viewing revision 2");
|
|
expect(container.textContent).toContain("Original plan body");
|
|
|
|
const currentRevisionButton = Array.from(container.querySelectorAll("button"))
|
|
.find((button) => button.textContent?.includes("rev 3"));
|
|
expect(currentRevisionButton).toBeTruthy();
|
|
|
|
await act(async () => {
|
|
currentRevisionButton?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(container.textContent).not.toContain("Viewing revision 2");
|
|
expect(container.textContent).toContain("Current plan body");
|
|
|
|
await act(async () => {
|
|
root.unmount();
|
|
});
|
|
queryClient.clear();
|
|
});
|
|
|
|
it("ignores mount-time editor change noise before a document is actively being edited", async () => {
|
|
markdownEditorMockState.emitMountEmptyChange = true;
|
|
|
|
const document = createIssueDocument({
|
|
body: "Loaded plan body",
|
|
});
|
|
const issue = createIssue();
|
|
const root = createRoot(container);
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: {
|
|
queries: {
|
|
retry: false,
|
|
},
|
|
mutations: {
|
|
retry: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
mockIssuesApi.listDocuments.mockResolvedValue([document]);
|
|
|
|
await act(async () => {
|
|
root.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<IssueDocumentsSection issue={issue} canDeleteDocuments={false} />
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
|
|
await flush();
|
|
await flush();
|
|
|
|
expect(container.textContent).toContain("Loaded plan body");
|
|
expect(container.textContent).not.toContain("Markdown body");
|
|
|
|
await act(async () => {
|
|
root.unmount();
|
|
});
|
|
queryClient.clear();
|
|
});
|
|
|
|
it("wraps the documents header actions so mobile layouts do not overflow", async () => {
|
|
const issue = createIssue();
|
|
const root = createRoot(container);
|
|
const queryClient = new QueryClient({
|
|
defaultOptions: {
|
|
queries: {
|
|
retry: false,
|
|
},
|
|
mutations: {
|
|
retry: false,
|
|
},
|
|
},
|
|
});
|
|
|
|
mockIssuesApi.listDocuments.mockResolvedValue([createIssueDocument()]);
|
|
|
|
await act(async () => {
|
|
root.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<IssueDocumentsSection
|
|
issue={issue}
|
|
canDeleteDocuments={false}
|
|
extraActions={(
|
|
<>
|
|
<button type="button">Upload</button>
|
|
<button type="button">Sub-issue</button>
|
|
</>
|
|
)}
|
|
/>
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
|
|
await flush();
|
|
await flush();
|
|
|
|
const heading = container.querySelector("h3");
|
|
expect(heading).toBeTruthy();
|
|
expect(heading?.parentElement?.className).toContain("flex-wrap");
|
|
expect(heading?.nextElementSibling?.className).toContain("flex-wrap");
|
|
|
|
await act(async () => {
|
|
root.unmount();
|
|
});
|
|
queryClient.clear();
|
|
});
|
|
});
|