forked from farhoodlabs/paperclip
[codex] Add multilingual issue preservation coverage (#6069)
## Thinking Path > - Paperclip orchestrates AI agents for autonomous companies. > - Agents and board operators coordinate through company-scoped issues, comments, documents, and heartbeat wake payloads. > - Chinese, Japanese, and Hindi text needs to survive the full issue lifecycle without normalization or prompt serialization damage. > - The riskiest paths are board issue creation, server issue/comment/document round-tripping, and scoped wake prompt rendering. > - This pull request adds focused regression coverage across those surfaces. > - The benefit is higher confidence that multilingual operators and agents can create, search, comment on, complete, and wake on issues using non-Latin text. ## What Changed - Added adapter-utils wake payload and prompt rendering coverage for Chinese, Japanese, and Hindi issue/comment text. - Added UI New Issue dialog coverage proving multilingual title and description text is submitted unchanged. - Added server route coverage that round-trips multilingual issue text through create, search, comments, documents, completion comments, and heartbeat context. - Addressed Greptile feedback by using a typed storage mock and splitting the server route integration path into smaller ordered assertions. ## Verification - `pnpm exec vitest run packages/adapter-utils/src/server-utils.test.ts ui/src/components/NewIssueDialog.test.tsx server/src/__tests__/multilingual-issues-routes.test.ts` - Result: 3 test files passed, 51 tests passed. ## Risks - Low risk: this PR adds regression coverage only and does not change runtime behavior. - The new server test uses embedded Postgres support and skips on unsupported hosts using the existing helper pattern. - No migrations are included. - No `pnpm-lock.yaml` changes are included. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected - check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 based coding agent, with shell, git, Vitest, and GitHub connector/CLI tool use. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge
This commit is contained in:
Dotta
@@ -0,0 +1,182 @@
|
||||
import { randomUUID } from "node:crypto";
|
||||
import express from "express";
|
||||
import request from "supertest";
|
||||
import { afterAll, beforeAll, describe, expect, it, vi } from "vitest";
|
||||
import { companies, createDb } from "@paperclipai/db";
|
||||
import {
|
||||
getEmbeddedPostgresTestSupport,
|
||||
startEmbeddedPostgresTestDatabase,
|
||||
} from "./helpers/embedded-postgres.js";
|
||||
import { errorHandler } from "../middleware/index.js";
|
||||
import { issueRoutes } from "../routes/issues.js";
|
||||
import type { StorageService } from "../storage/types.js";
|
||||
|
||||
const embeddedPostgresSupport = await getEmbeddedPostgresTestSupport();
|
||||
const describeEmbeddedPostgres = embeddedPostgresSupport.supported ? describe.sequential : describe.skip;
|
||||
|
||||
if (!embeddedPostgresSupport.supported) {
|
||||
console.warn(
|
||||
`Skipping embedded Postgres multilingual issue route tests on this host: ${embeddedPostgresSupport.reason ?? "unsupported environment"}`,
|
||||
);
|
||||
}
|
||||
|
||||
describeEmbeddedPostgres("multilingual issue routes", () => {
|
||||
let db!: ReturnType<typeof createDb>;
|
||||
let tempDb: Awaited<ReturnType<typeof startEmbeddedPostgresTestDatabase>> | null = null;
|
||||
let app!: ReturnType<typeof createApp>;
|
||||
let companyId!: string;
|
||||
|
||||
const title = "验证中文任务";
|
||||
const description = [
|
||||
"请用中文回复并保留上下文。",
|
||||
"日本語: 次の手順を書いてください。",
|
||||
"हिन्दी: कृपया स्थिति बताएं।",
|
||||
].join("\n");
|
||||
const firstReply = [
|
||||
"结果: 中文响应保留。",
|
||||
"日本語の返信も保持。",
|
||||
"हिन्दी उत्तर भी सुरक्षित है।",
|
||||
].join("\n");
|
||||
const completionNote = [
|
||||
"完成: 已验证中文。",
|
||||
"日本語: 完了しました。",
|
||||
"हिन्दी: सत्यापन पूरा हुआ।",
|
||||
].join("\n");
|
||||
const documentBody = [
|
||||
"# QA notes",
|
||||
"",
|
||||
"- 中文: 可以创建、读取、搜索、评论。",
|
||||
"- 日本語: ドキュメント本文を保持します。",
|
||||
"- हिन्दी: दस्तावेज़ पाठ सुरक्षित रहता है।",
|
||||
].join("\n");
|
||||
|
||||
beforeAll(async () => {
|
||||
tempDb = await startEmbeddedPostgresTestDatabase("paperclip-multilingual-issues-");
|
||||
db = createDb(tempDb.connectionString);
|
||||
companyId = randomUUID();
|
||||
app = createApp(companyId);
|
||||
|
||||
await db.insert(companies).values({
|
||||
id: companyId,
|
||||
name: "Multilingual tenant",
|
||||
issuePrefix: "LNG",
|
||||
requireBoardApprovalForNewAgents: false,
|
||||
});
|
||||
}, 20_000);
|
||||
|
||||
afterAll(async () => {
|
||||
await tempDb?.cleanup();
|
||||
});
|
||||
|
||||
function createStorage(): StorageService {
|
||||
return {
|
||||
provider: "local_disk",
|
||||
putFile: vi.fn(async () => {
|
||||
throw new Error("Unexpected storage.putFile call in multilingual issue route test");
|
||||
}),
|
||||
getObject: vi.fn(async () => {
|
||||
throw new Error("Unexpected storage.getObject call in multilingual issue route test");
|
||||
}),
|
||||
headObject: vi.fn(async () => ({ exists: false })),
|
||||
deleteObject: vi.fn(async () => undefined),
|
||||
};
|
||||
}
|
||||
|
||||
function createApp(companyId: string) {
|
||||
const app = express();
|
||||
app.use(express.json());
|
||||
app.use((req, _res, next) => {
|
||||
(req as any).actor = {
|
||||
type: "board",
|
||||
userId: "cloud-user-1",
|
||||
companyIds: [companyId],
|
||||
memberships: [{ companyId, membershipRole: "owner", status: "active" }],
|
||||
source: "cloud_tenant",
|
||||
isInstanceAdmin: true,
|
||||
};
|
||||
next();
|
||||
});
|
||||
app.use("/api", issueRoutes(db, createStorage()));
|
||||
app.use(errorHandler);
|
||||
return app;
|
||||
}
|
||||
|
||||
it("creates an issue with multilingual title and description", async () => {
|
||||
const createRes = await request(app)
|
||||
.post(`/api/companies/${companyId}/issues`)
|
||||
.send({
|
||||
title,
|
||||
description,
|
||||
status: "todo",
|
||||
priority: "medium",
|
||||
});
|
||||
|
||||
expect(createRes.status, JSON.stringify(createRes.body)).toBe(201);
|
||||
expect(createRes.body).toMatchObject({
|
||||
title,
|
||||
description,
|
||||
status: "todo",
|
||||
priority: "medium",
|
||||
identifier: "LNG-1",
|
||||
});
|
||||
});
|
||||
|
||||
it("reads the multilingual title and description unchanged", async () => {
|
||||
const getRes = await request(app).get("/api/issues/LNG-1");
|
||||
expect(getRes.status, JSON.stringify(getRes.body)).toBe(200);
|
||||
expect(getRes.body.title).toBe(title);
|
||||
expect(getRes.body.description).toBe(description);
|
||||
});
|
||||
|
||||
it("finds the issue by Chinese search text", async () => {
|
||||
const searchRes = await request(app).get(`/api/companies/${companyId}/issues`).query({ q: "中文" });
|
||||
expect(searchRes.status, JSON.stringify(searchRes.body)).toBe(200);
|
||||
expect(searchRes.body.map((issue: { identifier: string }) => issue.identifier)).toContain("LNG-1");
|
||||
});
|
||||
|
||||
it("preserves multilingual comment bodies", async () => {
|
||||
const commentRes = await request(app)
|
||||
.post("/api/issues/LNG-1/comments")
|
||||
.send({ body: firstReply });
|
||||
expect(commentRes.status, JSON.stringify(commentRes.body)).toBe(201);
|
||||
expect(commentRes.body.body).toBe(firstReply);
|
||||
});
|
||||
|
||||
it("preserves multilingual document bodies", async () => {
|
||||
const documentRes = await request(app)
|
||||
.put("/api/issues/LNG-1/documents/qa-notes")
|
||||
.send({
|
||||
title: "Multilingual QA",
|
||||
format: "markdown",
|
||||
body: documentBody,
|
||||
});
|
||||
expect(documentRes.status, JSON.stringify(documentRes.body)).toBe(201);
|
||||
expect(documentRes.body.body).toBe(documentBody);
|
||||
});
|
||||
|
||||
it("preserves multilingual completion comments", async () => {
|
||||
const completeRes = await request(app)
|
||||
.patch("/api/issues/LNG-1")
|
||||
.send({ status: "done", comment: completionNote });
|
||||
expect(completeRes.status, JSON.stringify(completeRes.body)).toBe(200);
|
||||
expect(completeRes.body.status).toBe("done");
|
||||
expect(completeRes.body.comment.body).toBe(completionNote);
|
||||
});
|
||||
|
||||
it("lists multilingual comments in write order", async () => {
|
||||
const commentsRes = await request(app).get("/api/issues/LNG-1/comments").query({ order: "asc" });
|
||||
expect(commentsRes.status, JSON.stringify(commentsRes.body)).toBe(200);
|
||||
expect(commentsRes.body.map((comment: { body: string }) => comment.body)).toEqual([
|
||||
firstReply,
|
||||
completionNote,
|
||||
]);
|
||||
});
|
||||
|
||||
it("exposes multilingual issue text in heartbeat context", async () => {
|
||||
const heartbeatContextRes = await request(app).get("/api/issues/LNG-1/heartbeat-context");
|
||||
expect(heartbeatContextRes.status, JSON.stringify(heartbeatContextRes.body)).toBe(200);
|
||||
expect(heartbeatContextRes.body.issue.title).toBe(title);
|
||||
expect(heartbeatContextRes.body.issue.description).toBe(description);
|
||||
expect(heartbeatContextRes.body.commentCursor.totalComments).toBe(2);
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user