gb_flea/paperclip
1
0
Fork 0
forked from farhoodlabs/paperclip
Code Pull Requests Activity

fix(skills): use acceptedSkills instead of listFull; cross-source slug check

Browse Source 
- Replace redundant listFull() call with acceptedSkills to avoid extra DB round-trip
- Check slug conflicts against full acceptedSkills list instead of just same-source skills
- Call upsertAcceptedSkill after persisting to keep in-memory list current

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Chris Farhood
2026-04-11 07:31:27 -04:00
parent e454277d10
commit a1343ea4f5
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
server/src/services/company-skills.ts
+6 -3
View File
@@ -2017,7 +2017,7 @@ export function companySkillService(db: Db) {
} }
// Re-scan GitHub/sks_sh sources to pick up newly added skills // Re-scan GitHub/sks_sh sources to pick up newly added skills
const existingSkills = await listFull(companyId); const existingSkills = acceptedSkills;
const sourceByLocator = new Map<string, CompanySkill[]>(); const sourceByLocator = new Map<string, CompanySkill[]>();
for (const skill of existingSkills) { for (const skill of existingSkills) {
if (skill.sourceType !== "github" && skill.sourceType !== "skills_sh") continue; if (skill.sourceType !== "github" && skill.sourceType !== "skills_sh") continue;
@@ -2030,12 +2030,15 @@ export function companySkillService(db: Db) {
try { try {
const result = await readUrlSkillImports(companyId, sourceLocator, null); const result = await readUrlSkillImports(companyId, sourceLocator, null);
for (const nextSkill of result.skills) { for (const nextSkill of result.skills) {
const existing = skillsAtSource.find((s) => s.slug === nextSkill.slug); const existing = acceptedSkills.find((s) => s.slug === nextSkill.slug);
if (!existing) { if (!existing) {
// New skill discovered — derive key and upsert // New skill discovered — derive key and upsert
nextSkill.key = deriveCanonicalSkillKey(companyId, nextSkill); nextSkill.key = deriveCanonicalSkillKey(companyId, nextSkill);
const persisted = (await upsertImportedSkills(companyId, [nextSkill]))[0]; const persisted = (await upsertImportedSkills(companyId, [nextSkill]))[0];
if (persisted) imported.push(persisted); if (persisted) {
imported.push(persisted);
upsertAcceptedSkill(persisted);
}
} }
} }
} catch { } catch {