forked from farhoodlabs/paperclip
Guard assigned backlog liveness (#5428)
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - The issue graph and liveness recovery system decide whether assigned work is executable or parked > - Assigned issues created without an explicit status could silently land in backlog, making parents look blocked with no productive wake path > - The server, shared validators, recovery analysis, and UI all need to agree on that execution semantic > - This pull request makes assigned issue creation default to `todo`, flags assigned backlog blockers, and surfaces the state in the board > - The benefit is that parked assigned work becomes intentional and visible instead of creating silent liveness stalls ## What Changed - Adds contract tests for assigned issue creation defaults. - Defaults assigned issue creation to `todo` when status is omitted while preserving explicit `backlog` parking. - Exposes `resolveCreateIssueStatusDefault` through shared validators. - Teaches liveness/blocker attention paths to distinguish assigned backlog blockers. - Adds UI notices, row/header badges, and issue detail safeguards for assigned backlog blockers. - Adds Storybook fixtures and execution-semantics documentation for the assigned-backlog behavior. ## Verification - `pnpm run preflight:workspace-links && pnpm exec vitest run packages/shared/src/validators/issue.test.ts server/src/__tests__/issue-assigned-backlog-contract-routes.test.ts server/src/__tests__/issue-blocker-attention.test.ts server/src/__tests__/issue-liveness.test.ts server/src/__tests__/heartbeat-issue-liveness-escalation.test.ts ui/src/components/IssueAssignedBacklogNotice.test.tsx ui/src/components/IssueRow.test.tsx` — 50 passed, 23 skipped. - Skipped tests were embedded Postgres suites on this host with the repo skip message: `Postgres init script exited with code null. Please check the logs for extra info. The data directory might already exist.` - Pairwise merge check against the issue-controls PR branch completed without conflicts via `git merge --no-commit --no-ff` in a temporary worktree. - Screenshots for assigned-backlog UI states: [light](docs/pr-screenshots/pr-5428/assigned-backlog-light.png), [dark](docs/pr-screenshots/pr-5428/assigned-backlog-dark.png). - Follow-up checks: `pnpm --filter /ui typecheck`; `pnpm --filter /mcp-server build`; `pnpm --filter /mcp-server test`; `pnpm exec vitest run packages/shared/src/validators/issue.test.ts`; focused UI component tests. - Remote PR checks on head `6300b3c`: policy, verify, serialized server shards 1/4-4/4, Canary Dry Run, e2e, Greptile Review, and Snyk all passed. ## Risks - Medium: changes status defaulting for assigned issue creation when the caller omits status. Explicit `backlog` remains supported, and server/shared tests cover both paths. - Medium: liveness classification changes can affect blocker attention labels; focused service and UI tests cover the new assigned-backlog state. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent, GPT-5 model family (`gpt-5`), tool-enabled Paperclip heartbeat environment. Context window and internal reasoning mode are not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
This commit is contained in:
@@ -87,6 +87,32 @@ describe("paperclip MCP tools", () => {
|
||||
});
|
||||
});
|
||||
|
||||
it("allows create issue requests to omit status so the API applies assignee defaults", async () => {
|
||||
const fetchMock = vi.fn().mockResolvedValue(
|
||||
mockJsonResponse({ id: "issue-1", status: "todo" }),
|
||||
);
|
||||
vi.stubGlobal("fetch", fetchMock);
|
||||
|
||||
const tool = getTool("paperclipCreateIssue");
|
||||
await tool.execute({
|
||||
title: "Assigned follow-up",
|
||||
assigneeAgentId: "22222222-2222-2222-2222-222222222222",
|
||||
});
|
||||
|
||||
const [url, init] = fetchMock.mock.calls[0] as [string, RequestInit];
|
||||
expect(String(url)).toBe(
|
||||
"http://localhost:3100/api/companies/11111111-1111-1111-1111-111111111111/issues",
|
||||
);
|
||||
expect(init.method).toBe("POST");
|
||||
expect(JSON.parse(String(init.body))).toEqual({
|
||||
title: "Assigned follow-up",
|
||||
workMode: "standard",
|
||||
priority: "medium",
|
||||
assigneeAgentId: "22222222-2222-2222-2222-222222222222",
|
||||
requestDepth: 0,
|
||||
});
|
||||
});
|
||||
|
||||
it("defaults issue document format to markdown", async () => {
|
||||
const fetchMock = vi.fn().mockResolvedValue(
|
||||
mockJsonResponse({ key: "plan", latestRevisionNumber: 2 }),
|
||||
|
||||
@@ -4,7 +4,7 @@ import {
|
||||
askUserQuestionsPayloadSchema,
|
||||
checkoutIssueSchema,
|
||||
createApprovalSchema,
|
||||
createIssueSchema,
|
||||
createIssueInputSchema,
|
||||
issueThreadInteractionContinuationPolicySchema,
|
||||
requestConfirmationPayloadSchema,
|
||||
suggestTasksPayloadSchema,
|
||||
@@ -95,7 +95,7 @@ const upsertDocumentToolSchema = z.object({
|
||||
|
||||
const createIssueToolSchema = z.object({
|
||||
companyId: companyIdOptional,
|
||||
}).merge(createIssueSchema);
|
||||
}).merge(createIssueInputSchema);
|
||||
|
||||
const updateIssueToolSchema = z.object({
|
||||
issueId: issueIdSchema,
|
||||
|
||||
@@ -719,7 +719,9 @@ export {
|
||||
COMPANY_SEARCH_MAX_TOKENS,
|
||||
type CompanySearchQuery,
|
||||
createIssueSchema,
|
||||
createIssueInputSchema,
|
||||
createChildIssueSchema,
|
||||
resolveCreateIssueStatusDefault,
|
||||
createIssueLabelSchema,
|
||||
updateIssueSchema,
|
||||
issueExecutionPolicySchema,
|
||||
|
||||
@@ -149,7 +149,9 @@ export {
|
||||
|
||||
export {
|
||||
createIssueSchema,
|
||||
createIssueInputSchema,
|
||||
createChildIssueSchema,
|
||||
resolveCreateIssueStatusDefault,
|
||||
createIssueLabelSchema,
|
||||
updateIssueSchema,
|
||||
issueExecutionPolicySchema,
|
||||
|
||||
@@ -129,6 +129,19 @@ describe("issue validators", () => {
|
||||
expect(parsed.requestDepth).toBe(MAX_ISSUE_REQUEST_DEPTH);
|
||||
});
|
||||
|
||||
it("defaults omitted create status to todo when an assignee is present", () => {
|
||||
expect(createIssueSchema.parse({
|
||||
title: "Assigned work",
|
||||
assigneeAgentId: "22222222-2222-4222-8222-222222222222",
|
||||
}).status).toBe("todo");
|
||||
expect(createIssueSchema.parse({ title: "Unassigned work" }).status).toBe("backlog");
|
||||
expect(createIssueSchema.parse({
|
||||
title: "Deliberately parked",
|
||||
assigneeAgentId: "22222222-2222-4222-8222-222222222222",
|
||||
status: "backlog",
|
||||
}).status).toBe("backlog");
|
||||
});
|
||||
|
||||
it("defaults issue work mode to standard and accepts planning", () => {
|
||||
expect(createIssueSchema.parse({ title: "Plan first" }).workMode).toBe("standard");
|
||||
expect(createIssueSchema.parse({ title: "Plan first", workMode: "planning" }).workMode).toBe("planning");
|
||||
|
||||
@@ -173,7 +173,48 @@ const issueRequestDepthInputSchema = z
|
||||
.nonnegative()
|
||||
.transform((value) => clampIssueRequestDepth(value));
|
||||
|
||||
export const createIssueSchema = z.object({
|
||||
type IssueCreateStatusDefaultInput = {
|
||||
status?: unknown;
|
||||
assigneeAgentId?: unknown;
|
||||
assigneeUserId?: unknown;
|
||||
};
|
||||
|
||||
export function resolveCreateIssueStatusDefault(input: IssueCreateStatusDefaultInput): {
|
||||
status: (typeof ISSUE_STATUSES)[number];
|
||||
defaulted: boolean;
|
||||
reason: "explicit" | "assigned_omitted_status" | "unassigned_omitted_status";
|
||||
} {
|
||||
if (typeof input.status === "string") {
|
||||
return {
|
||||
status: input.status as (typeof ISSUE_STATUSES)[number],
|
||||
defaulted: false,
|
||||
reason: "explicit",
|
||||
};
|
||||
}
|
||||
|
||||
const hasAssignee =
|
||||
(typeof input.assigneeAgentId === "string" && input.assigneeAgentId.length > 0)
|
||||
|| (typeof input.assigneeUserId === "string" && input.assigneeUserId.length > 0);
|
||||
return {
|
||||
status: hasAssignee ? "todo" : "backlog",
|
||||
defaulted: true,
|
||||
reason: hasAssignee ? "assigned_omitted_status" : "unassigned_omitted_status",
|
||||
};
|
||||
}
|
||||
|
||||
function withCreateIssueStatusDefault<T extends z.ZodRawShape>(schema: z.ZodObject<T>) {
|
||||
return z.preprocess((input) => {
|
||||
if (!input || typeof input !== "object" || Array.isArray(input)) return input;
|
||||
const raw = input as Record<string, unknown>;
|
||||
if (raw.status !== undefined) return input;
|
||||
return {
|
||||
...raw,
|
||||
status: resolveCreateIssueStatusDefault(raw).status,
|
||||
};
|
||||
}, schema);
|
||||
}
|
||||
|
||||
const createIssueBaseSchema = z.object({
|
||||
projectId: z.string().uuid().optional().nullable(),
|
||||
projectWorkspaceId: z.string().uuid().optional().nullable(),
|
||||
goalId: z.string().uuid().optional().nullable(),
|
||||
@@ -182,7 +223,7 @@ export const createIssueSchema = z.object({
|
||||
inheritExecutionWorkspaceFromIssueId: z.string().uuid().optional().nullable(),
|
||||
title: z.string().min(1),
|
||||
description: multilineTextSchema.optional().nullable(),
|
||||
status: z.enum(ISSUE_STATUSES).optional().default("backlog"),
|
||||
status: z.enum(ISSUE_STATUSES),
|
||||
workMode: z.enum(ISSUE_WORK_MODES).optional().default("standard"),
|
||||
priority: z.enum(ISSUE_PRIORITIES).optional().default("medium"),
|
||||
assigneeAgentId: z.string().uuid().optional().nullable(),
|
||||
@@ -197,9 +238,15 @@ export const createIssueSchema = z.object({
|
||||
labelIds: z.array(z.string().uuid()).optional(),
|
||||
});
|
||||
|
||||
export const createIssueInputSchema = createIssueBaseSchema.extend({
|
||||
status: createIssueBaseSchema.shape.status.optional(),
|
||||
});
|
||||
|
||||
export const createIssueSchema = withCreateIssueStatusDefault(createIssueBaseSchema);
|
||||
|
||||
export type CreateIssue = z.infer<typeof createIssueSchema>;
|
||||
|
||||
export const createChildIssueSchema = createIssueSchema
|
||||
export const createChildIssueSchema = withCreateIssueStatusDefault(createIssueBaseSchema
|
||||
.omit({
|
||||
parentId: true,
|
||||
inheritExecutionWorkspaceFromIssueId: true,
|
||||
@@ -207,7 +254,7 @@ export const createChildIssueSchema = createIssueSchema
|
||||
.extend({
|
||||
acceptanceCriteria: z.array(z.string().trim().min(1).max(500)).max(20).optional(),
|
||||
blockParentUntilDone: z.boolean().optional().default(false),
|
||||
});
|
||||
}));
|
||||
|
||||
export type CreateChildIssue = z.infer<typeof createChildIssueSchema>;
|
||||
|
||||
@@ -218,7 +265,7 @@ export const createIssueLabelSchema = z.object({
|
||||
|
||||
export type CreateIssueLabel = z.infer<typeof createIssueLabelSchema>;
|
||||
|
||||
export const updateIssueSchema = createIssueSchema.partial().extend({
|
||||
export const updateIssueSchema = createIssueBaseSchema.partial().extend({
|
||||
requestDepth: issueRequestDepthInputSchema.optional(),
|
||||
assigneeAgentId: z.string().trim().min(1).optional().nullable(),
|
||||
comment: multilineTextSchema.pipe(z.string().min(1)).optional(),
|
||||
|
||||
Reference in New Issue
Block a user