forked from farhoodlabs/paperclip
508355b8fc
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - The plugin system is the extension surface for optional product capabilities without baking every workflow into core. > - The LLM Wiki plugin package was reviewed in stacked PR #5592, which targeted `pap-9173-llm-wiki-rest`. > - The stack base PR #5597 merged to `master` before #5592 was merged into that branch, so the plugin package never reached `master`. > - A direct PR from `pap-9173-llm-wiki-rest` back to `master` would be noisy because that branch has diverged from current `master`. > - This pull request reapplies the reviewed `packages/plugins/plugin-llm-wiki/` package onto current `master` and updates Docker deps-stage manifest coverage. > - The branch intentionally no longer changes `pnpm-workspace.yaml` after maintainer feedback; because the new package is now a root workspace importer, the remaining integration question is how maintainers want the root lockfile handled under the current PR policy. ## What Changed - Added the LLM Wiki plugin package under `packages/plugins/plugin-llm-wiki/` from the merged PR #5592 head. - Preserved the post-review cleanup from #5592: generated design/screenshot artifacts are not committed, and `src/ui/index.tsx` / `src/wiki.ts` are small public entrypoints. - Added the new plugin package manifest to the Docker deps stage so policy can validate package manifest coverage. - Removed the earlier `pnpm-workspace.yaml` exclusion per maintainer request, so the plugin is included by the existing `packages/plugins/*` workspace glob. ## Verification Current head: - PGlite migration harness: ran migrations 001-003, verified old non-space distillation unique constraints were removed, inserted duplicate cursor and work-item keys in a second space, then reran migration 003 successfully - `node ./scripts/check-docker-deps-stage.mjs` - `git diff --check` Known current-head install result after removing the workspace exclusion: - `pnpm install --frozen-lockfile` fails because `pnpm-lock.yaml` has no importer for `packages/plugins/plugin-llm-wiki/package.json`. Previously verified on the same plugin source before the workspace-exclusion removal: - `pnpm --filter @paperclipai/plugin-sdk build` - `cd packages/plugins/plugin-llm-wiki && pnpm install --lockfile=false && pnpm test` ## Risks - The branch now includes `packages/plugins/plugin-llm-wiki` in the root workspace but does not update `pnpm-lock.yaml`. Root frozen install will fail until maintainers choose a lockfile path that fits repo policy. - Committing `pnpm-lock.yaml` directly on this PR conflicts with the current PR policy check, while excluding the package from `pnpm-workspace.yaml` was rejected in maintainer feedback. - The package includes UI code already reviewed in #5592; generated screenshot/design artifacts were intentionally removed per maintainer request, so visual review should regenerate screenshots locally if needed. - The package depends on plugin host support from #5597, which is already merged to `master`. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI GPT-5 Codex via Codex CLI, tool use and local code execution enabled; context window not exposed. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run the targeted checks listed above - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge Stack context: #5592 was merged into `pap-9173-llm-wiki-rest` after #5597 had already merged that branch to `master`, so this follow-up PR is needed to carry the plugin package itself into `master`. Co-authored-by: Paperclip <noreply@paperclip.ing>
61 lines
2.1 KiB
TypeScript
61 lines
2.1 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { readIngestOperationIssueId, uploadIssueAttachmentFile } from "../src/ui/issue-attachments.js";
|
|
|
|
describe("LLM Wiki issue attachment uploads", () => {
|
|
it("reads the ingest operation issue id from the action result", () => {
|
|
expect(readIngestOperationIssueId({
|
|
operation: {
|
|
issue: {
|
|
id: "issue-1",
|
|
},
|
|
},
|
|
})).toBe("issue-1");
|
|
});
|
|
|
|
it("rejects an ingest result that cannot identify the created issue", () => {
|
|
expect(() => readIngestOperationIssueId({ operation: { issue: null } }))
|
|
.toThrow("did not return an issue id");
|
|
});
|
|
|
|
it("uploads the original file to the created ingest task", async () => {
|
|
const file = new File(["hello"], "source notes.md", { type: "text/markdown" });
|
|
const calls: Array<{ input: string; init: RequestInit }> = [];
|
|
const fetchImpl = async (input: string, init: RequestInit) => {
|
|
calls.push({ input, init });
|
|
return new Response(JSON.stringify({ id: "attachment-1" }), {
|
|
status: 201,
|
|
headers: { "Content-Type": "application/json" },
|
|
});
|
|
};
|
|
|
|
await expect(uploadIssueAttachmentFile({
|
|
companyId: "company 1",
|
|
issueId: "issue/1",
|
|
file,
|
|
fetchImpl,
|
|
})).resolves.toEqual({ id: "attachment-1" });
|
|
|
|
expect(calls).toHaveLength(1);
|
|
expect(calls[0]?.input).toBe("/api/companies/company%201/issues/issue%2F1/attachments");
|
|
expect(calls[0]?.init.method).toBe("POST");
|
|
expect(calls[0]?.init.credentials).toBe("include");
|
|
const body = calls[0]?.init.body;
|
|
expect(body).toBeInstanceOf(FormData);
|
|
expect((body as FormData).get("file")).toBe(file);
|
|
});
|
|
|
|
it("surfaces server upload errors", async () => {
|
|
const fetchImpl = async () => new Response(JSON.stringify({ error: "Attachment exceeds 10 bytes" }), {
|
|
status: 422,
|
|
headers: { "Content-Type": "application/json" },
|
|
});
|
|
|
|
await expect(uploadIssueAttachmentFile({
|
|
companyId: "company-1",
|
|
issueId: "issue-1",
|
|
file: new File(["hello"], "source.txt"),
|
|
fetchImpl,
|
|
})).rejects.toThrow("Attachment exceeds 10 bytes");
|
|
});
|
|
});
|