forked from farhoodlabs/paperclip
d6d7a7cea6
## Thinking Path > - Paperclip is the control plane for autonomous AI companies. > - Routines are the scheduled/recurring work surface that keeps a company operating without manual kicks. > - Operators need routine edits to be auditable and recoverable, especially when routines control assignments, prompts, triggers, and webhook secrets. > - Documents already have revision-style safety, but routines did not have equivalent history or restore semantics. > - This pull request adds append-only routine revisions across the database, shared contracts, server routes, and board UI. > - The benefit is safer routine iteration: users can inspect history, compare changes, restore older definitions, and avoid overwriting newer edits. ## What Changed - Added `routine_revisions` storage, latest revision pointers on routines, shared types, validators, and API docs for routine revision history. - Added server service/route support for listing routine revisions, conflict-aware routine saves, and append-only restore operations. - Added a History tab on routine detail with revision preview, structured change summaries, description line diffs, dirty-edit blocking, restore confirmation, and restored webhook secret surfacing. - Extracted the line diff helper from `DocumentDiffModal` into `ui/src/lib/line-diff.ts` for reuse. - Rebased the branch onto current `public-gh/master` and renumbered the routine revision migration to `0077_unusual_karnak` after upstream `0076_useful_elektra`. - Made the `0077` routine revision migration idempotent so installs that already applied the branch-local `0076_unusual_karnak` can safely advance. - Updated the plugin SDK test harness routine fixture with the new revision fields required by the shared `Routine` contract. ## Verification - `pnpm --filter @paperclipai/db run check:migrations` passed. - `pnpm exec vitest run --project @paperclipai/shared packages/shared/src/validators/routine.test.ts` passed. - `pnpm exec vitest run --project @paperclipai/ui ui/src/lib/line-diff.test.ts ui/src/components/RoutineHistoryTab.test.tsx ui/src/lib/workspace-routines.test.ts ui/src/pages/Routines.test.tsx` passed. - `pnpm exec vitest run --project @paperclipai/server server/src/__tests__/routines-service.test.ts --pool=forks --poolOptions.forks.isolate=true` passed. - `pnpm exec vitest run --project @paperclipai/server server/src/__tests__/routines-routes.test.ts --pool=forks --poolOptions.forks.isolate=true` passed. - `pnpm --filter @paperclipai/plugin-sdk typecheck` passed after updating the SDK test harness fixture. - `pnpm --filter @paperclipai/plugin-sdk build` passed; this refreshed local generated SDK output needed by plugin example typechecks. - `pnpm -r typecheck` passed. ## Risks - Medium migration risk: this adds routine revision storage and backfills existing routines. The migration is ordered after upstream `0076` and uses `IF NOT EXISTS` / duplicate-object guards to tolerate earlier branch-local migration application. - Restore behavior intentionally appends a new revision instead of mutating history; callers expecting an in-place rollback need to follow the new latest revision pointer. - Restoring webhook triggers recreates webhook secret material, so users must copy newly surfaced secrets after restore. - Conflict-aware saves now reject stale routine edits when the client sends an older `baseRevisionId`. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent, with shell/tool use in a local git worktree. Exact context-window size is not exposed in this runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge Screenshots: not attached in this draft PR; the new UI flow is covered by component tests listed above. --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
87 lines
3.3 KiB
TypeScript
87 lines
3.3 KiB
TypeScript
import type {
|
|
ActivityEvent,
|
|
Routine,
|
|
RoutineDetail,
|
|
RoutineListItem,
|
|
RoutineRevision,
|
|
RoutineRun,
|
|
RoutineRunSummary,
|
|
RoutineTrigger,
|
|
RoutineTriggerSecretMaterial,
|
|
} from "@paperclipai/shared";
|
|
import { activityApi } from "./activity";
|
|
import { api } from "./client";
|
|
|
|
export interface RoutineTriggerResponse {
|
|
trigger: RoutineTrigger;
|
|
secretMaterial: RoutineTriggerSecretMaterial | null;
|
|
}
|
|
|
|
export interface RotateRoutineTriggerResponse {
|
|
trigger: RoutineTrigger;
|
|
secretMaterial: RoutineTriggerSecretMaterial;
|
|
}
|
|
|
|
export interface RestoreRoutineRevisionSecretMaterial extends RoutineTriggerSecretMaterial {
|
|
triggerId: string;
|
|
}
|
|
|
|
export interface RestoreRoutineRevisionResponse {
|
|
routine: Routine;
|
|
revision: RoutineRevision;
|
|
restoredFromRevisionId: string;
|
|
restoredFromRevisionNumber: number;
|
|
secretMaterials: RestoreRoutineRevisionSecretMaterial[];
|
|
}
|
|
|
|
export const routinesApi = {
|
|
list: (companyId: string, filters?: { projectId?: string | null }) => {
|
|
const params = new URLSearchParams();
|
|
if (filters?.projectId) params.set("projectId", filters.projectId);
|
|
const query = params.toString();
|
|
return api.get<RoutineListItem[]>(`/companies/${companyId}/routines${query ? `?${query}` : ""}`);
|
|
},
|
|
create: (companyId: string, data: Record<string, unknown>) =>
|
|
api.post<Routine>(`/companies/${companyId}/routines`, data),
|
|
get: (id: string) => api.get<RoutineDetail>(`/routines/${id}`),
|
|
update: (id: string, data: Record<string, unknown>) => api.patch<Routine>(`/routines/${id}`, data),
|
|
listRevisions: (id: string) => api.get<RoutineRevision[]>(`/routines/${id}/revisions`),
|
|
restoreRevision: (
|
|
id: string,
|
|
revisionId: string,
|
|
body: { changeSummary?: string | null } = {},
|
|
) =>
|
|
api.post<RestoreRoutineRevisionResponse>(
|
|
`/routines/${id}/revisions/${revisionId}/restore`,
|
|
body,
|
|
),
|
|
listRuns: (id: string, limit: number = 50) => api.get<RoutineRunSummary[]>(`/routines/${id}/runs?limit=${limit}`),
|
|
createTrigger: (id: string, data: Record<string, unknown>) =>
|
|
api.post<RoutineTriggerResponse>(`/routines/${id}/triggers`, data),
|
|
updateTrigger: (id: string, data: Record<string, unknown>) =>
|
|
api.patch<RoutineTrigger>(`/routine-triggers/${id}`, data),
|
|
deleteTrigger: (id: string) => api.delete<void>(`/routine-triggers/${id}`),
|
|
rotateTriggerSecret: (id: string) =>
|
|
api.post<RotateRoutineTriggerResponse>(`/routine-triggers/${id}/rotate-secret`, {}),
|
|
run: (id: string, data?: Record<string, unknown>) =>
|
|
api.post<RoutineRun>(`/routines/${id}/run`, data ?? {}),
|
|
activity: async (
|
|
companyId: string,
|
|
routineId: string,
|
|
related?: { triggerIds?: string[]; runIds?: string[] },
|
|
) => {
|
|
const requests = [
|
|
activityApi.list(companyId, { entityType: "routine", entityId: routineId }),
|
|
...(related?.triggerIds ?? []).map((triggerId) =>
|
|
activityApi.list(companyId, { entityType: "routine_trigger", entityId: triggerId })),
|
|
...(related?.runIds ?? []).map((runId) =>
|
|
activityApi.list(companyId, { entityType: "routine_run", entityId: runId })),
|
|
];
|
|
const events = (await Promise.all(requests)).flat();
|
|
const deduped = new Map(events.map((event) => [event.id, event]));
|
|
return [...deduped.values()].sort(
|
|
(a, b) => new Date(b.createdAt).getTime() - new Date(a.createdAt).getTime(),
|
|
);
|
|
},
|
|
};
|