forked from farhoodlabs/paperclip
4811d8dd33
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - Company creation is the first control-plane object operators create, and the generated issue prefix becomes part of task identity. > - The company service already retries when a generated issue prefix collides with the `companies_issue_prefix_idx` unique constraint. > - Drizzle 0.45.x wraps PostgreSQL errors in `DrizzleQueryError`, leaving the real `23505` constraint error on the `.cause` chain. > - The existing retry detector only inspected the top-level error, so wrapped prefix collisions surfaced as 500s instead of retrying. > - This pull request walks the error cause chain for the exact prefix constraint and verifies the retry path against embedded Postgres. > - The benefit is company creation no longer fails when generated prefixes collide under Drizzle 0.45.x wrappers. ## What Changed - Walk the error `.cause` chain when detecting `companies_issue_prefix_idx` unique violations, with a cycle guard and support for `constraint` / `constraint_name` fields. - Added an embedded Postgres regression test that seeds `ARO`, creates `Aron & Sharon`, and verifies the retry produces `AROA`. - Stabilized existing async tests touched by full verification: instance sidebar plugin rendering now waits for React Query results, and Tailscale-unavailable CLI tests explicitly hide host `tailscale` detection. ## Verification - `pnpm --filter @paperclipai/server exec vitest run src/__tests__/companies-service.test.ts` - `pnpm --filter @paperclipai/server exec vitest run src/__tests__/heartbeat-stale-queue-invalidation.test.ts` - `pnpm --filter @paperclipai/ui exec vitest run src/components/InstanceSidebar.test.tsx` - `pnpm --filter paperclipai exec vitest run src/__tests__/network-bind.test.ts src/__tests__/onboard.test.ts` - `pnpm test:run` - `pnpm -r typecheck` - `pnpm build` ## Risks - Low runtime risk: the retry behavior only expands detection for the existing exact company issue-prefix unique constraint. - The cause-chain walk is bounded by visited objects to avoid cycles. - The sidebar and CLI changes are test-only stabilization and do not change production behavior. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent in Codex desktop, with local shell/tool execution. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots (N/A: no UI behavior change) - [x] I have updated relevant documentation to reflect my changes (N/A: bug fix with no user-facing docs change) - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge Closes #6350
203 lines
7.3 KiB
TypeScript
203 lines
7.3 KiB
TypeScript
import fs from "node:fs";
|
|
import os from "node:os";
|
|
import path from "node:path";
|
|
import { afterEach, beforeEach, describe, expect, it } from "vitest";
|
|
import { onboard } from "../commands/onboard.js";
|
|
import type { PaperclipConfig } from "../config/schema.js";
|
|
|
|
const ORIGINAL_ENV = { ...process.env };
|
|
const ORIGINAL_CWD = process.cwd();
|
|
const ORIGINAL_PATH = process.env.PATH;
|
|
|
|
function createExistingConfigFixture() {
|
|
const root = fs.mkdtempSync(path.join(os.tmpdir(), "paperclip-onboard-"));
|
|
const runtimeRoot = path.join(root, "runtime");
|
|
const configPath = path.join(root, ".paperclip", "config.json");
|
|
const config: PaperclipConfig = {
|
|
$meta: {
|
|
version: 1,
|
|
updatedAt: "2026-03-29T00:00:00.000Z",
|
|
source: "configure",
|
|
},
|
|
database: {
|
|
mode: "embedded-postgres",
|
|
embeddedPostgresDataDir: path.join(runtimeRoot, "db"),
|
|
embeddedPostgresPort: 54329,
|
|
backup: {
|
|
enabled: true,
|
|
intervalMinutes: 60,
|
|
retentionDays: 30,
|
|
dir: path.join(runtimeRoot, "backups"),
|
|
},
|
|
},
|
|
logging: {
|
|
mode: "file",
|
|
logDir: path.join(runtimeRoot, "logs"),
|
|
},
|
|
server: {
|
|
deploymentMode: "local_trusted",
|
|
exposure: "private",
|
|
host: "127.0.0.1",
|
|
port: 3100,
|
|
allowedHostnames: [],
|
|
serveUi: true,
|
|
},
|
|
auth: {
|
|
baseUrlMode: "auto",
|
|
disableSignUp: false,
|
|
},
|
|
telemetry: {
|
|
enabled: true,
|
|
},
|
|
storage: {
|
|
provider: "local_disk",
|
|
localDisk: {
|
|
baseDir: path.join(runtimeRoot, "storage"),
|
|
},
|
|
s3: {
|
|
bucket: "paperclip",
|
|
region: "us-east-1",
|
|
prefix: "",
|
|
forcePathStyle: false,
|
|
},
|
|
},
|
|
secrets: {
|
|
provider: "local_encrypted",
|
|
strictMode: false,
|
|
localEncrypted: {
|
|
keyFilePath: path.join(runtimeRoot, "secrets", "master.key"),
|
|
},
|
|
},
|
|
};
|
|
|
|
fs.mkdirSync(path.dirname(configPath), { recursive: true });
|
|
fs.writeFileSync(configPath, `${JSON.stringify(config, null, 2)}\n`, { mode: 0o600 });
|
|
|
|
return { configPath, configText: fs.readFileSync(configPath, "utf8") };
|
|
}
|
|
|
|
function createFreshConfigPath() {
|
|
const root = fs.mkdtempSync(path.join(os.tmpdir(), "paperclip-onboard-fresh-"));
|
|
return path.join(root, ".paperclip", "config.json");
|
|
}
|
|
|
|
describe("onboard", () => {
|
|
beforeEach(() => {
|
|
process.env = { ...ORIGINAL_ENV };
|
|
delete process.env.PAPERCLIP_AGENT_JWT_SECRET;
|
|
delete process.env.PAPERCLIP_SECRETS_MASTER_KEY;
|
|
delete process.env.PAPERCLIP_SECRETS_MASTER_KEY_FILE;
|
|
delete process.env.PAPERCLIP_HOME;
|
|
delete process.env.PAPERCLIP_CONFIG;
|
|
delete process.env.PAPERCLIP_INSTANCE_ID;
|
|
delete process.env.PAPERCLIP_BIND;
|
|
delete process.env.PAPERCLIP_BIND_HOST;
|
|
delete process.env.PAPERCLIP_TAILNET_BIND_HOST;
|
|
delete process.env.HOST;
|
|
});
|
|
|
|
afterEach(() => {
|
|
process.env = { ...ORIGINAL_ENV };
|
|
process.chdir(ORIGINAL_CWD);
|
|
});
|
|
|
|
it("preserves an existing config when rerun without flags", async () => {
|
|
const fixture = createExistingConfigFixture();
|
|
|
|
await onboard({ config: fixture.configPath });
|
|
|
|
expect(fs.readFileSync(fixture.configPath, "utf8")).toBe(fixture.configText);
|
|
expect(fs.existsSync(`${fixture.configPath}.backup`)).toBe(false);
|
|
expect(fs.existsSync(path.join(path.dirname(fixture.configPath), ".env"))).toBe(true);
|
|
});
|
|
|
|
it("preserves an existing config when rerun with --yes", async () => {
|
|
const fixture = createExistingConfigFixture();
|
|
|
|
await onboard({ config: fixture.configPath, yes: true, invokedByRun: true });
|
|
|
|
expect(fs.readFileSync(fixture.configPath, "utf8")).toBe(fixture.configText);
|
|
expect(fs.existsSync(`${fixture.configPath}.backup`)).toBe(false);
|
|
expect(fs.existsSync(path.join(path.dirname(fixture.configPath), ".env"))).toBe(true);
|
|
});
|
|
|
|
it("keeps --yes onboarding on local trusted loopback defaults", async () => {
|
|
const configPath = createFreshConfigPath();
|
|
process.env.HOST = "0.0.0.0";
|
|
process.env.PAPERCLIP_BIND = "lan";
|
|
|
|
await onboard({ config: configPath, yes: true, invokedByRun: true });
|
|
|
|
const raw = JSON.parse(fs.readFileSync(configPath, "utf8")) as PaperclipConfig;
|
|
expect(raw.server.deploymentMode).toBe("local_trusted");
|
|
expect(raw.server.exposure).toBe("private");
|
|
expect(raw.server.bind).toBe("loopback");
|
|
expect(raw.server.host).toBe("127.0.0.1");
|
|
});
|
|
|
|
it("creates instance-root config and data paths for a fresh PAPERCLIP_HOME", async () => {
|
|
const home = fs.mkdtempSync(path.join(os.tmpdir(), "paperclip-onboard-home-"));
|
|
const cwd = fs.mkdtempSync(path.join(os.tmpdir(), "paperclip-onboard-cwd-"));
|
|
process.chdir(cwd);
|
|
process.env.PAPERCLIP_HOME = home;
|
|
|
|
await onboard({ yes: true, invokedByRun: true });
|
|
|
|
const instanceRoot = path.join(home, "instances", "default");
|
|
const configPath = path.join(instanceRoot, "config.json");
|
|
const raw = JSON.parse(fs.readFileSync(configPath, "utf8")) as PaperclipConfig;
|
|
|
|
expect(raw.database.embeddedPostgresDataDir).toBe(path.join(instanceRoot, "db"));
|
|
expect(raw.database.backup.dir).toBe(path.join(instanceRoot, "data", "backups"));
|
|
expect(raw.logging.logDir).toBe(path.join(instanceRoot, "logs"));
|
|
expect(raw.storage.localDisk.baseDir).toBe(path.join(instanceRoot, "data", "storage"));
|
|
expect(raw.secrets.localEncrypted.keyFilePath).toBe(path.join(instanceRoot, "secrets", "master.key"));
|
|
expect(fs.existsSync(path.join(instanceRoot, ".env"))).toBe(true);
|
|
expect(fs.existsSync(path.join(instanceRoot, "secrets", "master.key"))).toBe(true);
|
|
});
|
|
|
|
it("supports authenticated/private quickstart bind presets", async () => {
|
|
const configPath = createFreshConfigPath();
|
|
process.env.PAPERCLIP_TAILNET_BIND_HOST = "100.64.0.8";
|
|
|
|
await onboard({ config: configPath, yes: true, invokedByRun: true, bind: "tailnet" });
|
|
|
|
const raw = JSON.parse(fs.readFileSync(configPath, "utf8")) as PaperclipConfig;
|
|
expect(raw.server.deploymentMode).toBe("authenticated");
|
|
expect(raw.server.exposure).toBe("private");
|
|
expect(raw.server.bind).toBe("tailnet");
|
|
expect(raw.server.host).toBe("100.64.0.8");
|
|
});
|
|
|
|
it("keeps tailnet quickstart on loopback until tailscale is available", async () => {
|
|
const configPath = createFreshConfigPath();
|
|
delete process.env.PAPERCLIP_TAILNET_BIND_HOST;
|
|
process.env.PATH = "";
|
|
|
|
try {
|
|
await onboard({ config: configPath, yes: true, invokedByRun: true, bind: "tailnet" });
|
|
} finally {
|
|
process.env.PATH = ORIGINAL_PATH;
|
|
}
|
|
|
|
const raw = JSON.parse(fs.readFileSync(configPath, "utf8")) as PaperclipConfig;
|
|
expect(raw.server.deploymentMode).toBe("authenticated");
|
|
expect(raw.server.exposure).toBe("private");
|
|
expect(raw.server.bind).toBe("tailnet");
|
|
expect(raw.server.host).toBe("127.0.0.1");
|
|
});
|
|
|
|
it("ignores deployment env overrides during --yes quickstart", async () => {
|
|
const configPath = createFreshConfigPath();
|
|
process.env.PAPERCLIP_DEPLOYMENT_MODE = "authenticated";
|
|
|
|
await onboard({ config: configPath, yes: true, invokedByRun: true });
|
|
|
|
const raw = JSON.parse(fs.readFileSync(configPath, "utf8")) as PaperclipConfig;
|
|
expect(raw.server.deploymentMode).toBe("local_trusted");
|
|
expect(raw.server.exposure).toBe("private");
|
|
expect(raw.server.bind).toBe("loopback");
|
|
expect(raw.server.host).toBe("127.0.0.1");
|
|
});
|
|
});
|