forked from farhoodlabs/paperclip
9b99d30330
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Agents run inside environments (local, SSH, E2B sandbox) > - Operators need to configure and manage these environments > - But environment settings were buried inside the general company settings page, making them hard to find > - Additionally, when testing an agent from the configuration form, the test always ran locally regardless of which environment was selected > - This PR moves environments into a dedicated top-level company settings section and wires the "Test Environment" button to run inside the selected environment > - The benefit is operators can find and manage environments more easily, and the test button now validates the actual environment the agent will use ## What Changed - Added a dedicated `CompanyEnvironments` settings page with its own route and sidebar entry - Updated `CompanySettingsSidebar` and `CompanySettingsNav` to include the new environments section - Modified the agent test route (`POST /agents/:id/test`) to accept an optional `environmentId` parameter - Updated all adapter `test.ts` handlers to resolve and use the specified execution target environment - Added `resolveTestExecutionTarget` to `execution-target.ts` for remote environment test resolution with cwd fallback - Moved the "Test Environment" button and its feedback display into the `NewAgent` page footer for better UX flow ## Verification - `pnpm test` — all existing and new tests pass - `pnpm typecheck` — clean - Manual: navigate to Company Settings, confirm "Environments" appears as a top-level section - Manual: configure an agent with a non-local environment, click "Test Environment", confirm the test runs inside that environment ## Risks - Low risk. UI-only routing change for the settings page. The test-in-environment change adds an optional parameter with a local fallback, so existing behavior is preserved when no environment is specified. ## Model Used Codex GPT 5.4 high via Paperclip. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge
103 lines
3.2 KiB
TypeScript
103 lines
3.2 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act } from "react";
|
|
import { createRoot } from "react-dom/client";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { CompanySettingsNav, getCompanySettingsTab } from "./CompanySettingsNav";
|
|
|
|
let currentPathname = "/company/settings";
|
|
const navigateMock = vi.hoisted(() => vi.fn());
|
|
const pageTabBarMock = vi.hoisted(() => vi.fn());
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
useLocation: () => ({ pathname: currentPathname, search: "", hash: "" }),
|
|
useNavigate: () => navigateMock,
|
|
}));
|
|
|
|
vi.mock("@/components/ui/tabs", () => ({
|
|
Tabs: ({ children }: { children: React.ReactNode }) => <div data-testid="tabs-root">{children}</div>,
|
|
}));
|
|
|
|
vi.mock("@/components/PageTabBar", () => ({
|
|
PageTabBar: (props: {
|
|
items: Array<{ value: string; label: string }>;
|
|
value?: string;
|
|
onValueChange?: (value: string) => void;
|
|
}) => {
|
|
pageTabBarMock(props);
|
|
|
|
return (
|
|
<div>
|
|
<div data-testid="active-tab">{props.value}</div>
|
|
<button type="button" onClick={() => props.onValueChange?.("invites")}>
|
|
switch-tab
|
|
</button>
|
|
</div>
|
|
);
|
|
},
|
|
}));
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
describe("CompanySettingsNav", () => {
|
|
let container: HTMLDivElement;
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
currentPathname = "/company/settings";
|
|
});
|
|
|
|
afterEach(() => {
|
|
container.remove();
|
|
document.body.innerHTML = "";
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
it("maps company settings routes to the expected shared tab value", () => {
|
|
expect(getCompanySettingsTab("/company/settings")).toBe("general");
|
|
expect(getCompanySettingsTab("/PAP/company/settings")).toBe("general");
|
|
expect(getCompanySettingsTab("/company/settings/environments")).toBe("environments");
|
|
expect(getCompanySettingsTab("/PAP/company/settings/environments")).toBe("environments");
|
|
expect(getCompanySettingsTab("/company/settings/access")).toBe("access");
|
|
expect(getCompanySettingsTab("/PAP/company/settings/access")).toBe("access");
|
|
expect(getCompanySettingsTab("/company/settings/invites")).toBe("invites");
|
|
});
|
|
|
|
it("renders the active tab and navigates when a different tab is selected", async () => {
|
|
currentPathname = "/PAP/company/settings/access";
|
|
const root = createRoot(container);
|
|
|
|
await act(async () => {
|
|
root.render(<CompanySettingsNav />);
|
|
});
|
|
|
|
expect(container.textContent).toContain("access");
|
|
expect(pageTabBarMock).toHaveBeenCalledWith(
|
|
expect.objectContaining({
|
|
value: "access",
|
|
items: [
|
|
{ value: "general", label: "General" },
|
|
{ value: "environments", label: "Environments" },
|
|
{ value: "access", label: "Access" },
|
|
{ value: "invites", label: "Invites" },
|
|
],
|
|
}),
|
|
);
|
|
|
|
const button = container.querySelector("button");
|
|
expect(button).not.toBeNull();
|
|
|
|
await act(async () => {
|
|
button?.dispatchEvent(new MouseEvent("click", { bubbles: true }));
|
|
});
|
|
|
|
expect(navigateMock).toHaveBeenCalledWith("/company/settings/invites");
|
|
|
|
await act(async () => {
|
|
root.unmount();
|
|
});
|
|
});
|
|
});
|