Files
paperclip/ui/src/lib/recent-selections.test.ts
T
Dotta 057fee4836 [codex] Polish issue and operator workflow UI (#4090)
## Thinking Path

> - Paperclip operators spend much of their time in issues, inboxes,
selectors, and rich comment threads.
> - Small interaction problems in those surfaces slow down supervision
of AI-agent work.
> - The branch included related operator quality-of-life fixes for issue
layout, inbox actions, recent selectors, mobile inputs, and chat
rendering stability.
> - These changes are UI-focused and can land independently from
workspace navigation and access-profile work.
> - This pull request groups the operator QoL fixes into one standalone
branch.
> - The benefit is a more stable and efficient board workflow for issue
triage and task editing.

## What Changed

- Widened issue detail content and added a desktop inbox archive action.
- Fixed mobile text-field zoom by keeping touch input font sizes at
16px.
- Prioritized recent picker selections for assignees/projects in issue
and routine flows.
- Showed actionable approvals in the Mine inbox model.
- Fixed issue chat renderer state crashes and hardened tests.

## Verification

- `pnpm install --frozen-lockfile`
- `pnpm exec vitest run ui/src/components/IssueChatThread.test.tsx
ui/src/lib/inbox.test.ts ui/src/lib/recent-selections.test.ts`
- Split integration check: merged last after the other
[PAP-1614](/PAP/issues/PAP-1614) branches with no merge conflicts.
- Confirmed this branch does not include `pnpm-lock.yaml`.

## Risks

- Low to medium risk: mostly UI state, layout, and selection-priority
behavior.
- Visual layout and mobile zoom behavior may need browser/device QA
beyond component tests.
- No database migrations are included.

> For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and
discuss it in `#dev` before opening the PR. Feature PRs that overlap
with planned core work may need to be redirected — check the roadmap
first. See `CONTRIBUTING.md`.

## Model Used

- OpenAI Codex, GPT-5.4 tool-enabled coding model, agentic
code-editing/runtime with local shell and GitHub CLI access; exact
context window and reasoning mode are not exposed by the Paperclip
harness.

## Checklist

- [x] I have included a thinking path that traces from project context
to this change
- [x] I have specified the model used (with version and capability
details)
- [x] I have checked ROADMAP.md and confirmed this PR does not duplicate
planned core work
- [x] I have run tests locally and they pass
- [x] I have added or updated tests where applicable
- [x] If this change affects the UI, I have included before/after
screenshots
- [x] I have updated relevant documentation to reflect my changes
- [x] I have considered and documented any risks above
- [x] I will address all Greptile and reviewer comments before
requesting merge

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Paperclip <noreply@paperclip.ing>
2026-04-20 06:16:41 -05:00

80 lines
2.5 KiB
TypeScript

// @vitest-environment jsdom
import { beforeEach, describe, expect, it } from "vitest";
import {
getRecentAssigneeIds,
getRecentAssigneeSelectionIds,
sortAgentsByRecency,
trackRecentAssignee,
trackRecentAssigneeUser,
} from "./recent-assignees";
import { getRecentProjectIds, trackRecentProject } from "./recent-projects";
import { orderItemsBySelectedAndRecent } from "./recent-selections";
describe("recent selection ordering", () => {
beforeEach(() => {
localStorage.clear();
});
it("keeps the selected option first, then three recent options, then default order", () => {
const ordered = orderItemsBySelectedAndRecent(
[
{ id: "", label: "No project" },
{ id: "alpha", label: "Alpha" },
{ id: "bravo", label: "Bravo" },
{ id: "charlie", label: "Charlie" },
{ id: "delta", label: "Delta" },
{ id: "echo", label: "Echo" },
],
"charlie",
["echo", "bravo", "delta", "alpha"],
);
expect(ordered.map((item) => item.id)).toEqual(["charlie", "echo", "bravo", "delta", "", "alpha"]);
});
it("keeps the no-value option first when it is selected", () => {
const ordered = orderItemsBySelectedAndRecent(
[
{ id: "", label: "No assignee" },
{ id: "agent-1", label: "Agent 1" },
{ id: "agent-2", label: "Agent 2" },
],
"",
["agent-2"],
);
expect(ordered.map((item) => item.id)).toEqual(["", "agent-2", "agent-1"]);
});
it("only promotes the latest three assignees before default alphabetical order", () => {
const agents = [
{ id: "alpha", name: "Alpha" },
{ id: "bravo", name: "Bravo" },
{ id: "charlie", name: "Charlie" },
{ id: "delta", name: "Delta" },
{ id: "echo", name: "Echo" },
];
const sorted = sortAgentsByRecency(agents, ["delta", "bravo", "echo", "charlie"]);
expect(sorted.map((agent) => agent.id)).toEqual(["delta", "bravo", "echo", "alpha", "charlie"]);
});
it("tracks recent project ids newest first without duplicates", () => {
trackRecentProject("project-1");
trackRecentProject("project-2");
trackRecentProject("project-1");
expect(getRecentProjectIds()).toEqual(["project-1", "project-2"]);
});
it("tracks recent user and agent assignee selections with prefixed ids", () => {
trackRecentAssignee("agent-1");
trackRecentAssigneeUser("user-1");
expect(getRecentAssigneeSelectionIds()).toEqual(["user:user-1", "agent:agent-1"]);
expect(getRecentAssigneeIds()).toEqual(["agent-1"]);
});
});