forked from farhoodlabs/paperclip
5071c4c776
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - Operators need to inspect what agents changed inside execution and project workspaces. > - The existing workspace detail views did not provide a first-party rich diff surface for staged, unstaged, head, renamed, binary, oversized, and untracked changes. > - The plugin system is the intended extension point for optional rich UI surfaces. > - This pull request adds a workspace diff plugin plus host services and shared contracts so Changes tabs can render workspace diffs through plugin slots. > - The diff-renderer dependency should stay owned by the plugin package rather than the core UI app. > - The dependency surface must stay aligned with repository PR policy, including intentionally omitting `pnpm-lock.yaml` from the PR. > - The benefit is a more reviewable workspace surface without hard-coding the renderer into every page. ## What Changed - Added `@paperclipai/plugin-workspace-diff`, including diff normalization, plugin manifest/worker/UI entrypoints, and focused plugin tests. - Kept `@pierre/diffs` scoped to `@paperclipai/plugin-workspace-diff`; removed the core UI lab diff-renderer surface and direct UI package dependency. - Added shared workspace diff types and validators, plus plugin SDK surface for workspace diff host services. - Added server workspace diff service support and route coverage for execution/project workspace diff flows. - Wired Execution Workspace and Project Workspace Changes tabs to load the diff plugin, including loading/error fallback behavior. - Added UI tests and fixtures for the Changes tabs and plugin bridge behavior. - Added the new plugin package manifest to the Docker deps stage so PR policy can validate dependency coverage. - Addressed review hardening around empty untracked patches, workspace path exposure, project workspace read capability checks, and default base refs. ## Verification - `pnpm --filter @paperclipai/plugin-workspace-diff test` - `pnpm exec vitest run packages/shared/src/validators/workspace-diff.test.ts server/src/__tests__/workspace-diff-service.test.ts ui/src/pages/ProjectWorkspaceDetail.test.tsx ui/src/pages/ExecutionWorkspaceDetail.test.tsx` - `pnpm exec vitest run ui/src/plugins/bridge.test.ts server/src/__tests__/workspace-runtime-routes-authz.test.ts` - `pnpm --filter @paperclipai/shared typecheck` - `pnpm --filter @paperclipai/plugin-workspace-diff typecheck` - `pnpm --filter @paperclipai/server typecheck` - `pnpm --filter @paperclipai/ui typecheck` - `node ./scripts/check-docker-deps-stage.mjs` - Browser screenshot captured from the local worktree dev server: https://files.catbox.moe/ofdpsp.png - Confirmed branch is rebased onto `public-gh/master`, `.github/workflows/pr.yml` is not included in the PR diff, `ui/package.json` is not included in the PR diff, and `pnpm-lock.yaml` is not included in the PR diff. ## Risks - Medium UI integration risk: the Changes tab depends on the plugin slot and host diff service path. - Medium dependency risk: this adds `@pierre/diffs` in the plugin package, but `pnpm-lock.yaml` is intentionally omitted per packaging instructions because repository automation manages lockfile updates. - Current CI blocker: downstream frozen installs fail until the repository policy path for new plugin package dependencies is chosen. - Diff rendering edge cases are covered for common working-tree and head diff states, but very large repositories may still expose performance limits. - No migrations are included. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 class coding model, tool-enabled local execution environment. Exact context window was not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
144 lines
4.0 KiB
TypeScript
144 lines
4.0 KiB
TypeScript
import type {
|
|
WorkspaceDiffFile,
|
|
WorkspaceDiffFilePatch,
|
|
WorkspaceDiffResponse,
|
|
WorkspaceDiffWarning,
|
|
} from "./contracts.js";
|
|
|
|
export type DiffRenderMode = "unified" | "split";
|
|
|
|
export interface DiffPatchViewModel {
|
|
kind: WorkspaceDiffFilePatch["kind"];
|
|
patch: string | null;
|
|
lineCount: number;
|
|
additions: number;
|
|
deletions: number;
|
|
binary: boolean;
|
|
oversized: boolean;
|
|
truncated: boolean;
|
|
warnings: WorkspaceDiffWarning[];
|
|
}
|
|
|
|
export interface DiffFileViewModel {
|
|
path: string;
|
|
oldPath: string | null;
|
|
status: WorkspaceDiffFile["status"];
|
|
additions: number;
|
|
deletions: number;
|
|
binary: boolean;
|
|
oversized: boolean;
|
|
truncated: boolean;
|
|
warnings: WorkspaceDiffWarning[];
|
|
patchKinds: WorkspaceDiffFilePatch["kind"][];
|
|
patches: DiffPatchViewModel[];
|
|
patch: string | null;
|
|
lineCount: number;
|
|
longDiff: boolean;
|
|
}
|
|
|
|
export interface DiffSummaryViewModel {
|
|
changedLabel: string;
|
|
lineLabel: string;
|
|
warningCount: number;
|
|
truncated: boolean;
|
|
}
|
|
|
|
const STATUS_LABELS: Record<WorkspaceDiffFile["status"], string> = {
|
|
added: "Added",
|
|
modified: "Modified",
|
|
deleted: "Deleted",
|
|
renamed: "Renamed",
|
|
copied: "Copied",
|
|
type_changed: "Type changed",
|
|
untracked: "Untracked",
|
|
unknown: "Changed",
|
|
};
|
|
|
|
export const LONG_DIFF_LINE_THRESHOLD = 400;
|
|
|
|
export function statusLabel(status: WorkspaceDiffFile["status"]) {
|
|
return STATUS_LABELS[status] ?? "Changed";
|
|
}
|
|
|
|
export function fileName(filePath: string) {
|
|
return filePath.split("/").filter(Boolean).pop() ?? filePath;
|
|
}
|
|
|
|
export function buildFilePatches(file: WorkspaceDiffFile): DiffPatchViewModel[] {
|
|
return file.patches.map((patch) => {
|
|
const textPatch = patch.patch?.trimEnd() ?? null;
|
|
const lineCount = textPatch ? textPatch.split("\n").length : 0;
|
|
return {
|
|
kind: patch.kind,
|
|
patch: textPatch && textPatch.length > 0 ? textPatch : null,
|
|
lineCount,
|
|
additions: patch.additions,
|
|
deletions: patch.deletions,
|
|
binary: patch.binary,
|
|
oversized: patch.oversized,
|
|
truncated: patch.truncated,
|
|
warnings: patch.warnings,
|
|
};
|
|
});
|
|
}
|
|
|
|
export function buildFilePatch(file: WorkspaceDiffFile): string | null {
|
|
return buildFilePatches(file).find((patch) => patch.patch)?.patch ?? null;
|
|
}
|
|
|
|
export function isLongDiffFile(file: Pick<DiffFileViewModel, "lineCount">) {
|
|
return file.lineCount > LONG_DIFF_LINE_THRESHOLD;
|
|
}
|
|
|
|
export function toFileViewModels(diff: WorkspaceDiffResponse | null | undefined): DiffFileViewModel[] {
|
|
return (diff?.files ?? []).map((file) => {
|
|
const patches = buildFilePatches(file);
|
|
const lineCount = patches.reduce((count, patch) => count + patch.lineCount, 0);
|
|
return {
|
|
path: file.path,
|
|
oldPath: file.oldPath,
|
|
status: file.status,
|
|
additions: file.additions,
|
|
deletions: file.deletions,
|
|
binary: file.binary,
|
|
oversized: file.oversized,
|
|
truncated: file.truncated,
|
|
warnings: file.warnings,
|
|
patchKinds: file.patches.map((patch) => patch.kind),
|
|
patches,
|
|
patch: patches.find((patch) => patch.patch)?.patch ?? null,
|
|
lineCount,
|
|
longDiff: isLongDiffFile({ lineCount }),
|
|
};
|
|
});
|
|
}
|
|
|
|
export function diffSummary(diff: WorkspaceDiffResponse | null | undefined): DiffSummaryViewModel {
|
|
const stats = diff?.stats;
|
|
const fileCount = stats?.fileCount ?? 0;
|
|
const additions = stats?.additions ?? 0;
|
|
const deletions = stats?.deletions ?? 0;
|
|
const warningCount = diff?.warnings.length ?? 0;
|
|
|
|
return {
|
|
changedLabel: `${fileCount} ${fileCount === 1 ? "file" : "files"}`,
|
|
lineLabel: `+${additions} / -${deletions}`,
|
|
warningCount,
|
|
truncated: Boolean(diff?.truncated),
|
|
};
|
|
}
|
|
|
|
export function nextExpandedFileSet(
|
|
current: ReadonlySet<string>,
|
|
filePath: string,
|
|
): Set<string> {
|
|
const next = new Set(current);
|
|
if (next.has(filePath)) next.delete(filePath);
|
|
else next.add(filePath);
|
|
return next;
|
|
}
|
|
|
|
export function initialExpandedFileSet(files: readonly DiffFileViewModel[]): Set<string> {
|
|
return new Set(files.filter((file) => !file.longDiff).map((file) => file.path));
|
|
}
|