forked from farhoodlabs/paperclip
56b3120971
## Thinking Path > - Paperclip models companies as teams of human and AI operators > - The org chart is the primary visual map of that company structure > - Mobile users need to pan and inspect the chart without awkward gestures or layout jumps > - The roadmap also needed to reflect that the multiple-human-users work is complete > - This pull request improves mobile org chart gestures and updates the roadmap references > - The benefit is a smoother company navigation experience and docs that match shipped multi-user support ## What Changed - Added one-finger mobile pan handling for the org chart. - Expanded org chart test coverage for touch gesture behavior. - Updated README, ROADMAP, and CLI README references to mark multiple-human-users work as complete. ## Verification - `pnpm install --frozen-lockfile --ignore-scripts` - `pnpm exec vitest run ui/src/pages/OrgChart.test.tsx` - Result: 4 tests passed. ## Risks - Low-medium risk: org chart pointer/touch handling changed, but the behavior is scoped to the org chart page and covered by targeted tests. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex coding agent based on GPT-5, tool-enabled local shell and GitHub workflow, exact runtime context window not exposed in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots, or documented why targeted interaction tests are sufficient here - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
267 lines
7.4 KiB
TypeScript
267 lines
7.4 KiB
TypeScript
// @vitest-environment jsdom
|
|
|
|
import { act } from "react";
|
|
import { createRoot } from "react-dom/client";
|
|
import { QueryClient, QueryClientProvider } from "@tanstack/react-query";
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
|
import { OrgChart } from "./OrgChart";
|
|
|
|
const navigateMock = vi.fn();
|
|
const orgMock = vi.fn();
|
|
const listMock = vi.fn();
|
|
|
|
vi.mock("@/lib/router", () => ({
|
|
Link: ({ to, children }: { to: string; children: React.ReactNode }) => <a href={to}>{children}</a>,
|
|
useNavigate: () => navigateMock,
|
|
}));
|
|
|
|
vi.mock("../context/CompanyContext", () => ({
|
|
useCompany: () => ({ selectedCompanyId: "company-1" }),
|
|
}));
|
|
|
|
vi.mock("../context/BreadcrumbContext", () => ({
|
|
useBreadcrumbs: () => ({ setBreadcrumbs: vi.fn() }),
|
|
}));
|
|
|
|
vi.mock("../api/agents", () => ({
|
|
agentsApi: {
|
|
org: () => orgMock(),
|
|
list: () => listMock(),
|
|
},
|
|
}));
|
|
|
|
vi.mock("../components/AgentIconPicker", () => ({
|
|
AgentIcon: () => <span data-testid="agent-icon" />,
|
|
}));
|
|
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
(globalThis as any).IS_REACT_ACT_ENVIRONMENT = true;
|
|
|
|
const orgTree = [
|
|
{
|
|
id: "agent-1",
|
|
name: "CEO",
|
|
role: "ceo",
|
|
status: "active",
|
|
reports: [
|
|
{
|
|
id: "agent-2",
|
|
name: "Engineer",
|
|
role: "engineer",
|
|
status: "active",
|
|
reports: [],
|
|
},
|
|
],
|
|
},
|
|
];
|
|
|
|
const agents = [
|
|
{
|
|
id: "agent-1",
|
|
companyId: "company-1",
|
|
name: "CEO",
|
|
role: "ceo",
|
|
title: null,
|
|
status: "active",
|
|
reportsTo: null,
|
|
capabilities: null,
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
contextMode: "thin",
|
|
budgetMonthlyCents: 0,
|
|
spentMonthlyCents: 0,
|
|
lastHeartbeatAt: null,
|
|
icon: "briefcase",
|
|
metadata: null,
|
|
createdAt: new Date("2026-04-01T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-04-01T00:00:00.000Z"),
|
|
urlKey: "ceo",
|
|
pauseReason: null,
|
|
pausedAt: null,
|
|
permissions: null,
|
|
},
|
|
{
|
|
id: "agent-2",
|
|
companyId: "company-1",
|
|
name: "Engineer",
|
|
role: "engineer",
|
|
title: null,
|
|
status: "active",
|
|
reportsTo: "agent-1",
|
|
capabilities: null,
|
|
adapterType: "codex_local",
|
|
adapterConfig: {},
|
|
contextMode: "thin",
|
|
budgetMonthlyCents: 0,
|
|
spentMonthlyCents: 0,
|
|
lastHeartbeatAt: null,
|
|
icon: "code",
|
|
metadata: null,
|
|
createdAt: new Date("2026-04-01T00:00:00.000Z"),
|
|
updatedAt: new Date("2026-04-01T00:00:00.000Z"),
|
|
urlKey: "engineer",
|
|
pauseReason: null,
|
|
pausedAt: null,
|
|
permissions: null,
|
|
},
|
|
];
|
|
|
|
function createTouchEvent(type: string, touches: Array<{ clientX: number; clientY: number }>) {
|
|
const event = new Event(type, { bubbles: true, cancelable: true });
|
|
Object.defineProperty(event, "touches", {
|
|
value: touches,
|
|
});
|
|
Object.defineProperty(event, "changedTouches", {
|
|
value: touches,
|
|
});
|
|
return event;
|
|
}
|
|
|
|
async function flushReact() {
|
|
await act(async () => {
|
|
await Promise.resolve();
|
|
await new Promise((resolve) => window.setTimeout(resolve, 0));
|
|
});
|
|
}
|
|
|
|
describe("OrgChart mobile gestures", () => {
|
|
let container: HTMLDivElement;
|
|
let root: ReturnType<typeof createRoot>;
|
|
let queryClient: QueryClient;
|
|
|
|
beforeEach(() => {
|
|
container = document.createElement("div");
|
|
document.body.appendChild(container);
|
|
queryClient = new QueryClient({
|
|
defaultOptions: { queries: { retry: false } },
|
|
});
|
|
orgMock.mockResolvedValue(orgTree);
|
|
listMock.mockResolvedValue(agents);
|
|
|
|
Object.defineProperty(HTMLElement.prototype, "clientWidth", {
|
|
configurable: true,
|
|
get() {
|
|
return this.getAttribute("data-testid") === "org-chart-viewport" ? 360 : 0;
|
|
},
|
|
});
|
|
Object.defineProperty(HTMLElement.prototype, "clientHeight", {
|
|
configurable: true,
|
|
get() {
|
|
return this.getAttribute("data-testid") === "org-chart-viewport" ? 520 : 0;
|
|
},
|
|
});
|
|
vi.spyOn(HTMLElement.prototype, "getBoundingClientRect").mockImplementation(function getRect(this: HTMLElement) {
|
|
if (this.getAttribute("data-testid") === "org-chart-viewport") {
|
|
return {
|
|
x: 0,
|
|
y: 0,
|
|
left: 0,
|
|
top: 0,
|
|
right: 360,
|
|
bottom: 520,
|
|
width: 360,
|
|
height: 520,
|
|
toJSON: () => ({}),
|
|
};
|
|
}
|
|
return {
|
|
x: 0,
|
|
y: 0,
|
|
left: 0,
|
|
top: 0,
|
|
right: 0,
|
|
bottom: 0,
|
|
width: 0,
|
|
height: 0,
|
|
toJSON: () => ({}),
|
|
};
|
|
});
|
|
});
|
|
|
|
afterEach(async () => {
|
|
if (root) {
|
|
await act(async () => {
|
|
root.unmount();
|
|
});
|
|
}
|
|
container.remove();
|
|
document.body.innerHTML = "";
|
|
vi.restoreAllMocks();
|
|
vi.clearAllMocks();
|
|
});
|
|
|
|
async function renderOrgChart() {
|
|
root = createRoot(container);
|
|
await act(async () => {
|
|
root.render(
|
|
<QueryClientProvider client={queryClient}>
|
|
<OrgChart />
|
|
</QueryClientProvider>,
|
|
);
|
|
});
|
|
await flushReact();
|
|
await flushReact();
|
|
return {
|
|
viewport: container.querySelector('[data-testid="org-chart-viewport"]') as HTMLDivElement,
|
|
layer: container.querySelector('[data-testid="org-chart-card-layer"]') as HTMLDivElement,
|
|
};
|
|
}
|
|
|
|
it("pans the chart with one-finger touch drag", async () => {
|
|
const { viewport, layer } = await renderOrgChart();
|
|
|
|
await act(async () => {
|
|
viewport.dispatchEvent(createTouchEvent("touchstart", [{ clientX: 100, clientY: 100 }]));
|
|
viewport.dispatchEvent(createTouchEvent("touchmove", [{ clientX: 130, clientY: 145 }]));
|
|
viewport.dispatchEvent(createTouchEvent("touchend", []));
|
|
});
|
|
|
|
expect(layer.style.transform).toBe("translate(50px, 105px) scale(1)");
|
|
});
|
|
|
|
it("suppresses card navigation after a touch pan", async () => {
|
|
const { viewport } = await renderOrgChart();
|
|
const card = container.querySelector("[data-org-card]") as HTMLDivElement;
|
|
|
|
await act(async () => {
|
|
viewport.dispatchEvent(createTouchEvent("touchstart", [{ clientX: 100, clientY: 100 }]));
|
|
viewport.dispatchEvent(createTouchEvent("touchmove", [{ clientX: 130, clientY: 145 }]));
|
|
viewport.dispatchEvent(createTouchEvent("touchend", []));
|
|
card.dispatchEvent(new MouseEvent("click", { bubbles: true, cancelable: true }));
|
|
});
|
|
|
|
expect(navigateMock).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("allows card navigation after a touch tap without movement", async () => {
|
|
const { viewport } = await renderOrgChart();
|
|
const card = container.querySelector("[data-org-card]") as HTMLDivElement;
|
|
|
|
await act(async () => {
|
|
viewport.dispatchEvent(createTouchEvent("touchstart", [{ clientX: 100, clientY: 100 }]));
|
|
viewport.dispatchEvent(createTouchEvent("touchend", []));
|
|
card.dispatchEvent(new MouseEvent("click", { bubbles: true, cancelable: true }));
|
|
});
|
|
|
|
expect(navigateMock).toHaveBeenCalledWith("/agents/ceo");
|
|
});
|
|
|
|
it("pinch-zooms toward the touch center", async () => {
|
|
const { viewport, layer } = await renderOrgChart();
|
|
|
|
await act(async () => {
|
|
viewport.dispatchEvent(createTouchEvent("touchstart", [
|
|
{ clientX: 100, clientY: 100 },
|
|
{ clientX: 200, clientY: 100 },
|
|
]));
|
|
viewport.dispatchEvent(createTouchEvent("touchmove", [
|
|
{ clientX: 75, clientY: 100 },
|
|
{ clientX: 225, clientY: 100 },
|
|
]));
|
|
viewport.dispatchEvent(createTouchEvent("touchend", []));
|
|
});
|
|
|
|
expect(layer.style.transform).toBe("translate(-45px, 40px) scale(1.5)");
|
|
});
|
|
});
|