forked from farhoodlabs/paperclip
5f45712846
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - The board depends on issue, inbox, cost, and company-skill surfaces to stay accurate and fast while agents are actively working > - The PAP-1497 follow-up branch exposed a few rough edges in those surfaces: stale active-run state on completed issues, missing creator filters, oversized issue payload scans, and placeholder issue-route parsing > - Those gaps make the control plane harder to trust because operators can see misleading run state, miss the right subset of work, or pay extra query/render cost on large issue records > - This pull request tightens those follow-ups across server and UI code, and adds regression coverage for the affected paths > - The benefit is a more reliable issue workflow, safer high-volume cost aggregation, and clearer board/operator navigation ## What Changed - Added the `v2026.415.0` release changelog entry. - Fixed stale issue-run presentation after completion and reused the shared issue-path parser so literal route placeholders no longer become issue links. - Added creator filters to the Issues page and Inbox, including persisted filter-state normalization and regression coverage. - Bounded issue detail/list project-mention scans and trimmed large issue-list payload fields to keep issue reads lighter. - Hardened company-skill list projection and cost/finance aggregation so large markdown blobs and large summed values do not leak into list responses or overflow 32-bit casts. - Added targeted server/UI regression tests for company skills, costs/finance, issue mention scanning, creator filters, inbox normalization, and issue reference parsing. ## Verification - `pnpm exec vitest run server/src/__tests__/company-skills-service.test.ts server/src/__tests__/costs-service.test.ts server/src/__tests__/issues-goal-context-routes.test.ts server/src/__tests__/issues-service.test.ts ui/src/lib/inbox.test.ts ui/src/lib/issue-filters.test.ts ui/src/lib/issue-reference.test.ts` - `gh pr checks 3779` Current pass set on the PR head: `policy`, `verify`, `e2e`, `security/snyk (cryppadotta)`, `Greptile Review` ## Risks - Creator filter options are derived from the currently loaded issue/agent data, so very sparse result sets may not surface every historical creator until they appear in the active dataset. - Cost/finance aggregate casts now use `double precision`; that removes the current overflow risk, but future schema changes should keep large-value aggregation behavior under review. - Issue detail mention scanning now skips comment-body scans on the detail route, so any consumer that relied on comment-only project mentions there would need to fetch them separately. ## Model Used - OpenAI Codex, GPT-5-based coding agent with terminal tool use and local code execution in the Paperclip workspace. Exact internal model ID/context-window exposure is not surfaced in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
156 lines
4.4 KiB
TypeScript
156 lines
4.4 KiB
TypeScript
type MarkdownNode = {
|
|
type: string;
|
|
value?: string;
|
|
url?: string;
|
|
children?: MarkdownNode[];
|
|
};
|
|
|
|
const BARE_ISSUE_IDENTIFIER_RE = /^[A-Z][A-Z0-9]+-\d+$/i;
|
|
const ISSUE_SCHEME_RE = /^issue:\/\/:?([^?#\s]+)(?:[?#].*)?$/i;
|
|
const ISSUE_REFERENCE_TOKEN_RE = /issue:\/\/:?[^\s<>()]+|https?:\/\/[^\s<>()]+|\b[A-Z][A-Z0-9]+-\d+\b/gi;
|
|
|
|
export function parseIssuePathIdFromPath(pathOrUrl: string | null | undefined): string | null {
|
|
if (!pathOrUrl) return null;
|
|
let pathname = pathOrUrl.trim();
|
|
if (!pathname) return null;
|
|
|
|
if (/^https?:\/\//i.test(pathname)) {
|
|
try {
|
|
pathname = new URL(pathname).pathname;
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
const segments = pathname.split("/").filter(Boolean);
|
|
const issueIndex = segments.findIndex((segment) => segment === "issues");
|
|
if (issueIndex === -1 || issueIndex === segments.length - 1) return null;
|
|
const issuePathId = decodeURIComponent(segments[issueIndex + 1] ?? "");
|
|
if (!issuePathId || issuePathId.startsWith(":")) return null;
|
|
return issuePathId;
|
|
}
|
|
|
|
export function parseIssueReferenceFromHref(href: string | null | undefined) {
|
|
if (!href) return null;
|
|
const trimmed = href.trim();
|
|
const issueSchemeMatch = trimmed.match(ISSUE_SCHEME_RE);
|
|
if (issueSchemeMatch?.[1]) {
|
|
const issuePathId = decodeURIComponent(issueSchemeMatch[1]);
|
|
return {
|
|
issuePathId,
|
|
href: `/issues/${encodeURIComponent(issuePathId)}`,
|
|
};
|
|
}
|
|
|
|
const pathId = parseIssuePathIdFromPath(href);
|
|
if (pathId) {
|
|
return {
|
|
issuePathId: pathId,
|
|
href: `/issues/${encodeURIComponent(pathId)}`,
|
|
};
|
|
}
|
|
|
|
if (!BARE_ISSUE_IDENTIFIER_RE.test(trimmed)) return null;
|
|
const normalized = trimmed.toUpperCase();
|
|
return {
|
|
issuePathId: normalized,
|
|
href: `/issues/${encodeURIComponent(normalized)}`,
|
|
};
|
|
}
|
|
|
|
function splitTrailingPunctuation(token: string) {
|
|
let core = token;
|
|
let trailing = "";
|
|
|
|
while (core.length > 0) {
|
|
const lastChar = core.at(-1);
|
|
if (!lastChar || !/[),.;!?]/.test(lastChar)) break;
|
|
if (lastChar === ")") {
|
|
const openCount = (core.match(/\(/g) ?? []).length;
|
|
const closeCount = (core.match(/\)/g) ?? []).length;
|
|
if (closeCount <= openCount) break;
|
|
}
|
|
trailing = `${lastChar}${trailing}`;
|
|
core = core.slice(0, -1);
|
|
}
|
|
|
|
return { core, trailing };
|
|
}
|
|
|
|
function createIssueLinkNode(value: string, href: string, childType: "text" | "inlineCode" = "text"): MarkdownNode {
|
|
return {
|
|
type: "link",
|
|
url: href,
|
|
children: [{ type: childType, value }],
|
|
};
|
|
}
|
|
|
|
function linkifyIssueReferencesInText(value: string): MarkdownNode[] | null {
|
|
const nodes: MarkdownNode[] = [];
|
|
let cursor = 0;
|
|
let matched = false;
|
|
|
|
for (const match of value.matchAll(ISSUE_REFERENCE_TOKEN_RE)) {
|
|
const raw = match[0];
|
|
if (!raw) continue;
|
|
|
|
const start = match.index ?? 0;
|
|
const end = start + raw.length;
|
|
const { core, trailing } = splitTrailingPunctuation(raw);
|
|
const issueRef = parseIssueReferenceFromHref(core);
|
|
if (!issueRef) continue;
|
|
|
|
matched = true;
|
|
if (start > cursor) {
|
|
nodes.push({ type: "text", value: value.slice(cursor, start) });
|
|
}
|
|
nodes.push(createIssueLinkNode(core, issueRef.href));
|
|
if (trailing) {
|
|
nodes.push({ type: "text", value: trailing });
|
|
}
|
|
cursor = end;
|
|
}
|
|
|
|
if (!matched) return null;
|
|
if (cursor < value.length) {
|
|
nodes.push({ type: "text", value: value.slice(cursor) });
|
|
}
|
|
return nodes;
|
|
}
|
|
|
|
function rewriteMarkdownTree(node: MarkdownNode) {
|
|
if (!Array.isArray(node.children) || node.children.length === 0) return;
|
|
if (node.type === "link" || node.type === "linkReference" || node.type === "code" || node.type === "definition" || node.type === "html") {
|
|
return;
|
|
}
|
|
|
|
const nextChildren: MarkdownNode[] = [];
|
|
for (const child of node.children) {
|
|
if (child.type === "inlineCode" && typeof child.value === "string") {
|
|
const issueRef = parseIssueReferenceFromHref(child.value);
|
|
if (issueRef) {
|
|
nextChildren.push(createIssueLinkNode(child.value, issueRef.href, "inlineCode"));
|
|
continue;
|
|
}
|
|
}
|
|
|
|
if (child.type === "text" && typeof child.value === "string") {
|
|
const linked = linkifyIssueReferencesInText(child.value);
|
|
if (linked) {
|
|
nextChildren.push(...linked);
|
|
continue;
|
|
}
|
|
}
|
|
|
|
rewriteMarkdownTree(child);
|
|
nextChildren.push(child);
|
|
}
|
|
node.children = nextChildren;
|
|
}
|
|
|
|
export function remarkLinkIssueReferences() {
|
|
return (tree: MarkdownNode) => {
|
|
rewriteMarkdownTree(tree);
|
|
};
|
|
}
|