forked from farhoodlabs/paperclip
7f893ac4ec
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Reliable execution depends on heartbeat routing, issue lifecycle semantics, telemetry, and a fast enough local verification loop to keep regressions visible > - The remaining commits on this branch were mostly server/runtime correctness fixes plus test and documentation follow-ups in that area > - Those changes are logically separate from the UI-focused issue-detail and workspace/navigation branches even when they touch overlapping issue APIs > - This pull request groups the execution reliability, heartbeat, telemetry, and tooling changes into one standalone branch > - The benefit is a focused review of the control-plane correctness work, including the follow-up fix that restored the implicit comment-reopen helpers after branch splitting ## What Changed - Hardened issue/heartbeat execution behavior, including self-review stage skipping, deferred mention wakes during active execution, stranded execution recovery, active-run scoping, assignee resolution, and blocked-to-todo wake resumption - Reduced noisy polling/logging overhead by trimming issue run payloads, compacting persisted run logs, silencing high-volume request logs, and capping heartbeat-run queries in dashboard/inbox surfaces - Expanded telemetry and status semantics with adapter/model fields on task completion plus clearer status guidance in docs/onboarding material - Updated test infrastructure and verification defaults with faster route-test module isolation, cheaper default `pnpm test`, e2e isolation from local state, and repo verification follow-ups - Included docs/release housekeeping from the branch and added a small follow-up commit restoring the implicit comment-reopen helpers that were dropped during branch reconstruction ## Verification - `pnpm vitest run server/src/__tests__/issue-comment-reopen-routes.test.ts server/src/__tests__/issue-telemetry-routes.test.ts` - `pnpm vitest run server/src/__tests__/http-log-policy.test.ts server/src/__tests__/heartbeat-run-log.test.ts server/src/__tests__/health.test.ts` - `server/src/__tests__/activity-service.test.ts`, `server/src/__tests__/heartbeat-comment-wake-batching.test.ts`, and `server/src/__tests__/heartbeat-process-recovery.test.ts` were attempted on this host but the embedded Postgres harness reported init-script/data-dir problems and skipped or failed to start, so they are noted as environment-limited ## Risks - Medium: this branch changes core issue/heartbeat routing and reopen/wakeup behavior, so regressions would affect agent execution flow rather than isolated UI polish - Because it also updates verification infrastructure, reviewers should pay attention to whether the new tests are asserting the right failure modes and not just reshaping harness behavior ## Model Used - OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact deployed model ID is not exposed in this environment), reasoning enabled, tool use and local code execution enabled ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [ ] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
315 lines
15 KiB
TypeScript
315 lines
15 KiB
TypeScript
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
|
|
import type { ExecutionWorkspace } from "@paperclipai/shared";
|
|
import { Link } from "@/lib/router";
|
|
import { Loader2 } from "lucide-react";
|
|
import { executionWorkspacesApi } from "../api/execution-workspaces";
|
|
import { useToastActions } from "../context/ToastContext";
|
|
import { queryKeys } from "../lib/queryKeys";
|
|
import { formatDateTime, issueUrl } from "../lib/utils";
|
|
import { Button } from "./ui/button";
|
|
import {
|
|
Dialog,
|
|
DialogContent,
|
|
DialogDescription,
|
|
DialogFooter,
|
|
DialogHeader,
|
|
DialogTitle,
|
|
} from "./ui/dialog";
|
|
|
|
type ExecutionWorkspaceCloseDialogProps = {
|
|
workspaceId: string;
|
|
workspaceName: string;
|
|
currentStatus: ExecutionWorkspace["status"];
|
|
open: boolean;
|
|
onOpenChange: (open: boolean) => void;
|
|
onClosed?: (workspace: ExecutionWorkspace) => void;
|
|
};
|
|
|
|
function readinessTone(state: "ready" | "ready_with_warnings" | "blocked") {
|
|
if (state === "blocked") {
|
|
return "border-destructive/30 bg-destructive/5 text-destructive";
|
|
}
|
|
if (state === "ready_with_warnings") {
|
|
return "border-amber-500/30 bg-amber-500/10 text-amber-800 dark:text-amber-300";
|
|
}
|
|
return "border-emerald-500/30 bg-emerald-500/10 text-emerald-700 dark:text-emerald-300";
|
|
}
|
|
|
|
export function ExecutionWorkspaceCloseDialog({
|
|
workspaceId,
|
|
workspaceName,
|
|
currentStatus,
|
|
open,
|
|
onOpenChange,
|
|
onClosed,
|
|
}: ExecutionWorkspaceCloseDialogProps) {
|
|
const queryClient = useQueryClient();
|
|
const { pushToast } = useToastActions();
|
|
const actionLabel = currentStatus === "cleanup_failed" ? "Retry close" : "Close workspace";
|
|
|
|
const readinessQuery = useQuery({
|
|
queryKey: queryKeys.executionWorkspaces.closeReadiness(workspaceId),
|
|
queryFn: () => executionWorkspacesApi.getCloseReadiness(workspaceId),
|
|
enabled: open,
|
|
});
|
|
|
|
const closeWorkspace = useMutation({
|
|
mutationFn: () => executionWorkspacesApi.update(workspaceId, { status: "archived" }),
|
|
onSuccess: (workspace) => {
|
|
queryClient.setQueryData(queryKeys.executionWorkspaces.detail(workspace.id), workspace);
|
|
queryClient.invalidateQueries({ queryKey: queryKeys.executionWorkspaces.closeReadiness(workspace.id) });
|
|
pushToast({
|
|
title: currentStatus === "cleanup_failed" ? "Workspace close retried" : "Workspace closed",
|
|
tone: "success",
|
|
});
|
|
onOpenChange(false);
|
|
onClosed?.(workspace);
|
|
},
|
|
onError: (error) => {
|
|
pushToast({
|
|
title: "Failed to close workspace",
|
|
body: error instanceof Error ? error.message : "Unknown error",
|
|
tone: "error",
|
|
});
|
|
},
|
|
});
|
|
|
|
const readiness = readinessQuery.data ?? null;
|
|
const blockingIssues = readiness?.linkedIssues.filter((issue) => !issue.isTerminal) ?? [];
|
|
const otherLinkedIssues = readiness?.linkedIssues.filter((issue) => issue.isTerminal) ?? [];
|
|
const confirmDisabled =
|
|
currentStatus === "archived" ||
|
|
closeWorkspace.isPending ||
|
|
readinessQuery.isLoading ||
|
|
readiness == null ||
|
|
readiness.state === "blocked";
|
|
|
|
return (
|
|
<Dialog open={open} onOpenChange={(nextOpen) => {
|
|
if (!closeWorkspace.isPending) onOpenChange(nextOpen);
|
|
}}>
|
|
<DialogContent className="max-h-[85vh] overflow-x-hidden overflow-y-auto p-4 sm:max-w-2xl sm:p-6 [&>*]:min-w-0">
|
|
<DialogHeader>
|
|
<DialogTitle>{actionLabel}</DialogTitle>
|
|
<DialogDescription className="break-words text-xs sm:text-sm">
|
|
Archive <span className="font-medium text-foreground">{workspaceName}</span> and clean up any owned workspace
|
|
artifacts. Paperclip keeps the workspace record and issue history, but removes it from active workspace views.
|
|
</DialogDescription>
|
|
</DialogHeader>
|
|
|
|
{readinessQuery.isLoading ? (
|
|
<div className="flex items-center gap-2 rounded-xl border border-border bg-muted/30 px-3 py-2.5 text-xs sm:px-4 sm:py-3 sm:text-sm text-muted-foreground">
|
|
<Loader2 className="h-4 w-4 animate-spin shrink-0" />
|
|
Checking whether this workspace is safe to close...
|
|
</div>
|
|
) : readinessQuery.error ? (
|
|
<div className="rounded-xl border border-destructive/30 bg-destructive/5 px-3 py-2.5 text-xs sm:px-4 sm:py-3 sm:text-sm text-destructive">
|
|
{readinessQuery.error instanceof Error ? readinessQuery.error.message : "Failed to inspect workspace close readiness."}
|
|
</div>
|
|
) : readiness ? (
|
|
<div className="min-w-0 space-y-3 sm:space-y-4">
|
|
<div className={`rounded-xl border px-3 py-2.5 text-xs sm:px-4 sm:py-3 sm:text-sm ${readinessTone(readiness.state)}`}>
|
|
<div className="font-medium">
|
|
{readiness.state === "blocked"
|
|
? "Close is blocked"
|
|
: readiness.state === "ready_with_warnings"
|
|
? "Close is allowed with warnings"
|
|
: "Close is ready"}
|
|
</div>
|
|
<div className="mt-1 text-xs opacity-80">
|
|
{readiness.isSharedWorkspace
|
|
? "This is a shared workspace session. Archiving it removes this session record but keeps the underlying project workspace."
|
|
: readiness.git?.workspacePath && readiness.git.repoRoot && readiness.git.workspacePath !== readiness.git.repoRoot
|
|
? "This execution workspace has its own checkout path and can be archived independently."
|
|
: readiness.isProjectPrimaryWorkspace
|
|
? "This execution workspace currently points at the project's primary workspace path."
|
|
: "This workspace is disposable and can be archived."}
|
|
</div>
|
|
</div>
|
|
|
|
{blockingIssues.length > 0 ? (
|
|
<section className="space-y-2">
|
|
<h3 className="text-xs font-medium sm:text-sm">Blocking issues</h3>
|
|
<div className="space-y-1.5 sm:space-y-2">
|
|
{blockingIssues.map((issue) => (
|
|
<div key={issue.id} className="rounded-xl border border-destructive/20 bg-destructive/5 px-3 py-2 text-xs sm:px-4 sm:py-3 sm:text-sm">
|
|
<div className="flex min-w-0 flex-wrap items-center justify-between gap-2">
|
|
<Link to={issueUrl(issue)} className="min-w-0 break-words font-medium hover:underline">
|
|
{issue.identifier ?? issue.id} · {issue.title}
|
|
</Link>
|
|
<span className="text-xs text-muted-foreground">{issue.status}</span>
|
|
</div>
|
|
</div>
|
|
))}
|
|
</div>
|
|
</section>
|
|
) : null}
|
|
|
|
{readiness.blockingReasons.length > 0 ? (
|
|
<section className="space-y-2">
|
|
<h3 className="text-xs font-medium sm:text-sm">Blocking reasons</h3>
|
|
<ul className="space-y-1.5 text-xs sm:space-y-2 sm:text-sm text-muted-foreground">
|
|
{readiness.blockingReasons.map((reason, idx) => (
|
|
<li key={`blocking-${idx}`} className="break-words rounded-lg border border-destructive/20 bg-destructive/5 px-2.5 py-1.5 sm:px-3 sm:py-2 text-destructive">
|
|
{reason}
|
|
</li>
|
|
))}
|
|
</ul>
|
|
</section>
|
|
) : null}
|
|
|
|
{readiness.warnings.length > 0 ? (
|
|
<section className="space-y-2">
|
|
<h3 className="text-xs font-medium sm:text-sm">Warnings</h3>
|
|
<ul className="space-y-1.5 text-xs sm:space-y-2 sm:text-sm text-muted-foreground">
|
|
{readiness.warnings.map((warning, idx) => (
|
|
<li key={`warning-${idx}`} className="break-words rounded-lg border border-amber-500/20 bg-amber-500/5 px-2.5 py-1.5 sm:px-3 sm:py-2">
|
|
{warning}
|
|
</li>
|
|
))}
|
|
</ul>
|
|
</section>
|
|
) : null}
|
|
|
|
{readiness.git ? (
|
|
<section className="space-y-2">
|
|
<h3 className="text-xs font-medium sm:text-sm">Git status</h3>
|
|
<div className="overflow-hidden rounded-xl border border-border bg-muted/20 px-3 py-2.5 text-xs sm:px-4 sm:py-3 sm:text-sm">
|
|
<div className="grid grid-cols-2 gap-2">
|
|
<div className="min-w-0">
|
|
<div className="text-xs uppercase tracking-[0.16em] text-muted-foreground">Branch</div>
|
|
<div className="truncate font-mono text-xs">{readiness.git.branchName ?? "Unknown"}</div>
|
|
</div>
|
|
<div className="min-w-0">
|
|
<div className="text-xs uppercase tracking-[0.16em] text-muted-foreground">Base ref</div>
|
|
<div className="truncate font-mono text-xs">{readiness.git.baseRef ?? "Not set"}</div>
|
|
</div>
|
|
<div>
|
|
<div className="text-xs uppercase tracking-[0.16em] text-muted-foreground">Merged into base</div>
|
|
<div>{readiness.git.isMergedIntoBase == null ? "Unknown" : readiness.git.isMergedIntoBase ? "Yes" : "No"}</div>
|
|
</div>
|
|
<div>
|
|
<div className="text-xs uppercase tracking-[0.16em] text-muted-foreground">Ahead / behind</div>
|
|
<div>
|
|
{(readiness.git.aheadCount ?? 0).toString()} / {(readiness.git.behindCount ?? 0).toString()}
|
|
</div>
|
|
</div>
|
|
<div>
|
|
<div className="text-xs uppercase tracking-[0.16em] text-muted-foreground">Dirty tracked files</div>
|
|
<div>{readiness.git.dirtyEntryCount}</div>
|
|
</div>
|
|
<div>
|
|
<div className="text-xs uppercase tracking-[0.16em] text-muted-foreground">Untracked files</div>
|
|
<div>{readiness.git.untrackedEntryCount}</div>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
</section>
|
|
) : null}
|
|
|
|
{otherLinkedIssues.length > 0 ? (
|
|
<section className="space-y-2">
|
|
<h3 className="text-xs font-medium sm:text-sm">Other linked issues</h3>
|
|
<div className="space-y-1.5 sm:space-y-2">
|
|
{otherLinkedIssues.map((issue) => (
|
|
<div key={issue.id} className="rounded-xl border border-border bg-muted/20 px-3 py-2 text-xs sm:px-4 sm:py-3 sm:text-sm">
|
|
<div className="flex min-w-0 flex-wrap items-center justify-between gap-2">
|
|
<Link to={issueUrl(issue)} className="min-w-0 break-words font-medium hover:underline">
|
|
{issue.identifier ?? issue.id} · {issue.title}
|
|
</Link>
|
|
<span className="text-xs text-muted-foreground">{issue.status}</span>
|
|
</div>
|
|
</div>
|
|
))}
|
|
</div>
|
|
</section>
|
|
) : null}
|
|
|
|
{readiness.runtimeServices.length > 0 ? (
|
|
<section className="space-y-2">
|
|
<h3 className="text-xs font-medium sm:text-sm">Attached runtime services</h3>
|
|
<div className="space-y-1.5 sm:space-y-2">
|
|
{readiness.runtimeServices.map((service) => (
|
|
<div key={service.id} className="rounded-xl border border-border bg-muted/20 px-3 py-2 text-xs sm:px-4 sm:py-3 sm:text-sm">
|
|
<div className="flex min-w-0 flex-wrap items-center justify-between gap-2">
|
|
<span className="font-medium">{service.serviceName}</span>
|
|
<span className="text-xs text-muted-foreground">{service.status} · {service.lifecycle}</span>
|
|
</div>
|
|
<div className="mt-1 break-words text-xs text-muted-foreground">
|
|
{service.url ?? service.command ?? service.cwd ?? "No additional details"}
|
|
</div>
|
|
</div>
|
|
))}
|
|
</div>
|
|
</section>
|
|
) : null}
|
|
|
|
<section className="space-y-2">
|
|
<h3 className="text-xs font-medium sm:text-sm">Cleanup actions</h3>
|
|
<div className="space-y-1.5 sm:space-y-2">
|
|
{readiness.plannedActions.map((action, index) => (
|
|
<div key={`${action.kind}-${index}`} className="rounded-xl border border-border bg-muted/20 px-3 py-2 text-xs sm:px-4 sm:py-3 sm:text-sm">
|
|
<div className="font-medium">{action.label}</div>
|
|
<div className="mt-1 break-words text-muted-foreground">{action.description}</div>
|
|
{action.command ? (
|
|
<pre className="mt-2 whitespace-pre-wrap break-all rounded-lg bg-background px-3 py-2 font-mono text-xs text-foreground">
|
|
{action.command}
|
|
</pre>
|
|
) : null}
|
|
</div>
|
|
))}
|
|
</div>
|
|
</section>
|
|
|
|
{currentStatus === "cleanup_failed" ? (
|
|
<div className="rounded-xl border border-amber-500/20 bg-amber-500/5 px-3 py-2.5 text-xs sm:px-4 sm:py-3 sm:text-sm text-muted-foreground">
|
|
Cleanup previously failed on this workspace. Retrying close will rerun the cleanup flow and update the
|
|
workspace status if it succeeds.
|
|
</div>
|
|
) : null}
|
|
|
|
{currentStatus === "archived" ? (
|
|
<div className="rounded-xl border border-border bg-muted/20 px-3 py-2.5 text-xs sm:px-4 sm:py-3 sm:text-sm text-muted-foreground">
|
|
This workspace is already archived.
|
|
</div>
|
|
) : null}
|
|
|
|
{readiness.git?.repoRoot ? (
|
|
<div className="overflow-hidden break-words text-xs text-muted-foreground">
|
|
Repo root: <span className="font-mono break-all">{readiness.git.repoRoot}</span>
|
|
{readiness.git.workspacePath ? (
|
|
<>
|
|
{" · "}Workspace path: <span className="font-mono break-all">{readiness.git.workspacePath}</span>
|
|
</>
|
|
) : null}
|
|
</div>
|
|
) : null}
|
|
|
|
<div className="text-xs text-muted-foreground">
|
|
Last checked {formatDateTime(new Date())}
|
|
</div>
|
|
</div>
|
|
) : null}
|
|
|
|
<DialogFooter>
|
|
<Button
|
|
variant="outline"
|
|
onClick={() => onOpenChange(false)}
|
|
disabled={closeWorkspace.isPending}
|
|
>
|
|
Cancel
|
|
</Button>
|
|
<Button
|
|
variant={currentStatus === "cleanup_failed" ? "default" : "destructive"}
|
|
onClick={() => closeWorkspace.mutate()}
|
|
disabled={confirmDisabled}
|
|
>
|
|
{closeWorkspace.isPending ? <Loader2 className="mr-2 h-4 w-4 animate-spin" /> : null}
|
|
{actionLabel}
|
|
</Button>
|
|
</DialogFooter>
|
|
</DialogContent>
|
|
</Dialog>
|
|
);
|
|
}
|