forked from farhoodlabs/paperclip
0808b388ee
## Thinking Path > - Paperclip is a control plane for autonomous AI companies, where work must end with a clear disposition rather than ambiguous agent liveness. > - Recovery currently detects stalled or missing-next-step issues, but source issue recovery can become split across child recovery issues, blockers, and comments. > - That makes it harder for operators and agents to see who owns recovery and what exact action is needed on the original issue. > - Source-scoped recovery actions give the original issue a first-class active recovery state with owner, evidence, wake policy, and resolution outcome. > - This pull request adds the recovery-action data model, backend reconciliation and resolution APIs, and board UI indicators/actions. > - The benefit is clearer stalled-work recovery without losing source issue context or relying on comments as the liveness path. ## What Changed - Added the `issue_recovery_actions` schema, shared types/constants/validators, and an idempotent `0084_issue_recovery_actions` migration ordered after current `master` migrations. - Updated stranded/missing-disposition recovery to create source-scoped recovery actions, wake the recovery owner on the source issue, and avoid locking the source issue for recovery-action wakes. - Added API support for reading active recovery actions on issue detail/list surfaces and resolving them with restored, blocked, cancelled, or false-positive outcomes. - Require blocked recovery resolutions to have an unresolved first-class blocker, and removed the UI shortcut that could mark recovery blocked without a blocker selection path. - Surfaced recovery indicators/actions in the issue UI, blocker notices, active run panels, issue rows, and Storybook coverage. - Updated docs and focused tests for recovery semantics, ownership, races, stale comments, and UI behavior. ## Verification - `pnpm exec vitest run server/src/__tests__/issue-recovery-actions.test.ts server/src/__tests__/heartbeat-process-recovery.test.ts ui/src/components/IssueRecoveryActionCard.test.tsx ui/src/components/IssueBlockedNotice.test.tsx ui/src/api/issues.test.ts` — 5 files, 72 tests passed. - `pnpm --filter @paperclipai/shared typecheck` — passed. - `pnpm --filter @paperclipai/db typecheck` — passed, including migration numbering check. - `pnpm --filter @paperclipai/server typecheck` — passed. - `pnpm --filter @paperclipai/ui typecheck` — passed. - Follow-up verification after blocker-resolution guard: `pnpm exec vitest run server/src/__tests__/issue-recovery-actions.test.ts ui/src/components/IssueRecoveryActionCard.test.tsx ui/src/api/issues.test.ts` — 3 files, 27 tests passed. - Follow-up `pnpm --filter @paperclipai/server typecheck` — passed. - Follow-up `pnpm --filter @paperclipai/ui typecheck` — passed. - UI states are available in `ui/storybook/stories/source-issue-recovery.stories.tsx`; screenshot capture helper is `scripts/screenshot-recovery-card.cjs`. ## Risks - Medium: recovery behavior changes from child recovery issue ownership toward source-scoped actions, so operators may see stalled-work state in new places. - Migration risk is mitigated by using the next migration slot after `master` and making the table/constraints/index creation idempotent for anyone who previously applied the old branch-local `0082_dizzy_master_mold` migration. - Existing child recovery issue paths are still guarded for already-created recovery issues, but new source-scoped flows should be watched in CI and Greptile review. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5 coding agent, tool use enabled for shell, Git, GitHub, and local test execution. Context window not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
86 lines
2.6 KiB
JavaScript
86 lines
2.6 KiB
JavaScript
#!/usr/bin/env node
|
|
/* eslint-disable no-console */
|
|
const path = require("path");
|
|
const fs = require("fs");
|
|
|
|
const repoRoot = path.resolve(__dirname, "..");
|
|
const playwright = require(path.join(
|
|
repoRoot,
|
|
"node_modules/.pnpm/playwright@1.58.2/node_modules/playwright/index.js",
|
|
));
|
|
|
|
const STORYBOOK_BASE = process.env.STORYBOOK_URL ?? "http://localhost:6006";
|
|
const OUT_DIR = path.resolve(repoRoot, "tmp/pap-9134-recovery-screens");
|
|
|
|
const VIEWPORTS = [
|
|
{ name: "desktop", width: 1440, height: 900 },
|
|
{ name: "mobile", width: 390, height: 844 },
|
|
];
|
|
|
|
const STORIES = [
|
|
{
|
|
id: "paperclip-source-issue-recovery--recovery-action-card-states",
|
|
label: "card-states",
|
|
},
|
|
{
|
|
id: "paperclip-source-issue-recovery--inbox-row-chips",
|
|
label: "inbox-rows",
|
|
},
|
|
{
|
|
id: "paperclip-source-issue-recovery--blocker-notice-recovery-indicators",
|
|
label: "blocker-notice",
|
|
},
|
|
{
|
|
id: "paperclip-source-issue-recovery--active-run-panel-recovery-chips",
|
|
label: "active-run-panel",
|
|
},
|
|
];
|
|
|
|
const THEMES = [
|
|
{ name: "light", apply: () => document.documentElement.classList.remove("dark") },
|
|
{ name: "dark", apply: () => document.documentElement.classList.add("dark") },
|
|
];
|
|
|
|
(async () => {
|
|
fs.mkdirSync(OUT_DIR, { recursive: true });
|
|
const browser = await playwright.chromium.launch();
|
|
try {
|
|
for (const viewport of VIEWPORTS) {
|
|
const context = await browser.newContext({
|
|
viewport: { width: viewport.width, height: viewport.height },
|
|
deviceScaleFactor: 2,
|
|
});
|
|
for (const story of STORIES) {
|
|
for (const theme of THEMES) {
|
|
const page = await context.newPage();
|
|
const url = `${STORYBOOK_BASE}/iframe.html?id=${story.id}&viewMode=story`;
|
|
await page.goto(url, { waitUntil: "domcontentloaded", timeout: 30_000 });
|
|
await page.waitForLoadState("networkidle", { timeout: 30_000 }).catch(() => {});
|
|
await page.evaluate((darkTheme) => {
|
|
const html = document.documentElement;
|
|
if (darkTheme) {
|
|
html.classList.add("dark");
|
|
} else {
|
|
html.classList.remove("dark");
|
|
}
|
|
}, theme.name === "dark");
|
|
await page.waitForTimeout(400);
|
|
const outPath = path.join(
|
|
OUT_DIR,
|
|
`${story.label}_${viewport.name}_${theme.name}.png`,
|
|
);
|
|
await page.screenshot({ path: outPath, fullPage: true });
|
|
console.log(`Saved ${outPath}`);
|
|
await page.close();
|
|
}
|
|
}
|
|
await context.close();
|
|
}
|
|
} finally {
|
|
await browser.close();
|
|
}
|
|
})().catch((err) => {
|
|
console.error(err);
|
|
process.exit(1);
|
|
});
|