forked from farhoodlabs/paperclip
a72731f118
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Its release automation publishes canary packages to npm and then validates the published registry state before considering the release healthy > - The failing canary run `25139465018` showed that npm can expose a newly published version through version-specific endpoints before the root package document has fully converged > - That made a successful canary publish look like a failed release because the verifier trusted stale root metadata too early > - This pull request hardens the registry verification path by preferring version-specific manifest checks, retrying convergence-sensitive failures, and distinguishing permanent failures from propagation lag > - While validating that change in CI, a separate teardown race in `heartbeat-stale-queue-invalidation.test.ts` surfaced and was hardened so the PR could pass reliably > - The benefit is that transient npm propagation lag no longer fails a successful canary publish, while genuine registry-state and dependency-integrity failures still stop the release flow promptly ## What Changed - Hardened `scripts/verify-release-registry-state.mjs` so it prefers version-specific manifest resolution over stale root metadata, adds bounded registry-fetch timeouts, and classifies failures as retriable vs non-retriable. - Updated `scripts/release-lib.sh` and `scripts/release.sh` so post-publish registry verification retries only convergence-sensitive failures and reports immediate permanent failures clearly. - Expanded `scripts/verify-release-registry-state.test.mjs` with regression coverage for stale root metadata, fetch timeout behavior, peer dependency range handling, non-retriable canary-latest cases, and related verifier edge cases. - Hardened `server/src/__tests__/heartbeat-stale-queue-invalidation.test.ts` teardown to tolerate the late-comment foreign-key race that CI exposed while validating this branch. ## Verification - `pnpm run test:release-registry` - `node --check scripts/verify-release-registry-state.mjs` - `bash -n scripts/release.sh && bash -n scripts/release-lib.sh` - PR checks passed on head `5c422600fc12acac61f6b7c267a4dc915df622b1`: `policy`, `verify`, `e2e`, `security/snyk`, and `Greptile Review` ## Risks - Low risk. The main behavioral changes are limited to release automation and verifier retry semantics, plus a test-only teardown hardening for a CI race. > I checked [`ROADMAP.md`](ROADMAP.md). This is a narrow release bugfix and does not overlap planned core feature work. ## Model Used - OpenAI Codex via Paperclip `codex_local` with tool use and local code execution enabled. This agent session runs on a GPT-5-class coding model; the exact backend model ID/context window is not exposed by the local adapter runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [ ] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I have addressed all Greptile and reviewer comments before requesting merge
469 lines
14 KiB
JavaScript
469 lines
14 KiB
JavaScript
#!/usr/bin/env node
|
|
|
|
import { pathToFileURL } from "node:url";
|
|
|
|
const CANARY_VERSION_RE = /-canary\.\d+$/;
|
|
const EXIT_RETRIABLE_FAILURE = 1;
|
|
const EXIT_NON_RETRIABLE_FAILURE = 2;
|
|
|
|
export function isCanaryVersion(version) {
|
|
return CANARY_VERSION_RE.test(version);
|
|
}
|
|
|
|
function createExitError(message, exitCode = EXIT_RETRIABLE_FAILURE) {
|
|
return Object.assign(new Error(message), { exitCode });
|
|
}
|
|
|
|
function createProblem(message, { retriable = true } = {}) {
|
|
return { message, retriable };
|
|
}
|
|
|
|
function usage() {
|
|
process.stderr.write(
|
|
[
|
|
"Usage:",
|
|
" node scripts/verify-release-registry-state.mjs --channel <canary|stable> --dist-tag <tag> --target-version <version> --package <name> [--package <name> ...] [--allow-canary-latest]",
|
|
"",
|
|
].join("\n"),
|
|
);
|
|
}
|
|
|
|
function parseArgs(argv) {
|
|
const options = {
|
|
channel: "",
|
|
distTag: "",
|
|
targetVersion: "",
|
|
allowCanaryLatest: false,
|
|
packages: [],
|
|
};
|
|
|
|
for (let index = 0; index < argv.length; index += 1) {
|
|
const arg = argv[index];
|
|
|
|
switch (arg) {
|
|
case "--channel":
|
|
options.channel = argv[index + 1] ?? "";
|
|
index += 1;
|
|
break;
|
|
case "--dist-tag":
|
|
options.distTag = argv[index + 1] ?? "";
|
|
index += 1;
|
|
break;
|
|
case "--target-version":
|
|
options.targetVersion = argv[index + 1] ?? "";
|
|
index += 1;
|
|
break;
|
|
case "--package":
|
|
options.packages.push(argv[index + 1] ?? "");
|
|
index += 1;
|
|
break;
|
|
case "--allow-canary-latest":
|
|
options.allowCanaryLatest = true;
|
|
break;
|
|
case "-h":
|
|
case "--help":
|
|
usage();
|
|
process.exit(0);
|
|
default:
|
|
throw createExitError(`unexpected argument: ${arg}`, EXIT_NON_RETRIABLE_FAILURE);
|
|
}
|
|
}
|
|
|
|
if (options.channel !== "canary" && options.channel !== "stable") {
|
|
throw createExitError("--channel must be canary or stable", EXIT_NON_RETRIABLE_FAILURE);
|
|
}
|
|
|
|
if (!options.distTag) {
|
|
throw createExitError("--dist-tag is required", EXIT_NON_RETRIABLE_FAILURE);
|
|
}
|
|
|
|
if (!options.targetVersion) {
|
|
throw createExitError("--target-version is required", EXIT_NON_RETRIABLE_FAILURE);
|
|
}
|
|
|
|
if (options.packages.length === 0 || options.packages.some((name) => !name)) {
|
|
throw createExitError("at least one non-empty --package value is required", EXIT_NON_RETRIABLE_FAILURE);
|
|
}
|
|
|
|
if (options.allowCanaryLatest && options.channel !== "canary") {
|
|
throw createExitError("--allow-canary-latest only applies to canary releases", EXIT_NON_RETRIABLE_FAILURE);
|
|
}
|
|
|
|
return options;
|
|
}
|
|
|
|
function createRegistryUrl(packageName, version = "") {
|
|
const registry = process.env.npm_config_registry ?? process.env.NPM_CONFIG_REGISTRY ?? "https://registry.npmjs.org/";
|
|
const baseUrl = registry.endsWith("/") ? registry : `${registry}/`;
|
|
const encodedPackage = encodeURIComponent(packageName);
|
|
|
|
if (!version) {
|
|
return new URL(encodedPackage, baseUrl);
|
|
}
|
|
|
|
return new URL(`${encodedPackage}/${encodeURIComponent(version)}`, baseUrl);
|
|
}
|
|
|
|
export async function fetchRegistryJson(url, { allowMissing = false, timeoutMs = 30_000 } = {}) {
|
|
const controller = new AbortController();
|
|
const timeout = setTimeout(() => controller.abort(), timeoutMs);
|
|
let response;
|
|
|
|
try {
|
|
response = await fetch(url, {
|
|
signal: controller.signal,
|
|
headers: {
|
|
accept: "application/vnd.npm.install-v1+json, application/json;q=0.9",
|
|
},
|
|
});
|
|
} catch (error) {
|
|
if (error instanceof Error && error.name === "AbortError") {
|
|
throw new Error(`npm registry request timed out for ${url} after ${timeoutMs}ms`);
|
|
}
|
|
throw error;
|
|
} finally {
|
|
clearTimeout(timeout);
|
|
}
|
|
|
|
if (response.status === 404 && allowMissing) {
|
|
return null;
|
|
}
|
|
|
|
if (!response.ok) {
|
|
throw new Error(`npm registry request failed for ${url}: ${response.status} ${response.statusText}`);
|
|
}
|
|
|
|
return response.json();
|
|
}
|
|
|
|
async function fetchPackageDocument(packageName, { allowMissing = false } = {}) {
|
|
return fetchRegistryJson(createRegistryUrl(packageName), { allowMissing });
|
|
}
|
|
|
|
async function fetchPackageManifest(packageName, version, { allowMissing = false } = {}) {
|
|
return fetchRegistryJson(createRegistryUrl(packageName, version), { allowMissing });
|
|
}
|
|
|
|
export function createManifestLookupKey(packageName, version) {
|
|
return `${packageName}@${version}`;
|
|
}
|
|
|
|
function isRangeVersionSpecifier(version) {
|
|
return /[\^~*xX><| ]/.test(version);
|
|
}
|
|
|
|
function resolvePublishedManifest(packageName, version, packageDoc, packageManifestsByKey = new Map()) {
|
|
const directManifest = packageManifestsByKey.get(createManifestLookupKey(packageName, version));
|
|
if (directManifest) {
|
|
return directManifest;
|
|
}
|
|
|
|
if (directManifest === null) {
|
|
return null;
|
|
}
|
|
|
|
return packageDoc?.versions?.[version] ?? null;
|
|
}
|
|
|
|
function collectInternalDependencyProblemEntries(
|
|
manifest,
|
|
packageDocsByName,
|
|
packageManifestsByKey = new Map(),
|
|
) {
|
|
const problems = [];
|
|
const sections = [
|
|
["dependencies", manifest.dependencies ?? {}],
|
|
["optionalDependencies", manifest.optionalDependencies ?? {}],
|
|
["peerDependencies", manifest.peerDependencies ?? {}],
|
|
];
|
|
|
|
for (const [sectionName, deps] of sections) {
|
|
for (const [dependencyName, dependencyVersion] of Object.entries(deps)) {
|
|
if (!dependencyName.startsWith("@paperclipai/")) {
|
|
continue;
|
|
}
|
|
|
|
if (typeof dependencyVersion !== "string" || !dependencyVersion) {
|
|
problems.push(
|
|
createProblem(
|
|
`${sectionName} declares ${dependencyName} with a non-string version: ${JSON.stringify(dependencyVersion)}`,
|
|
),
|
|
);
|
|
continue;
|
|
}
|
|
|
|
// Peer dependency ranges express compatibility, not a manifest that can be fetched directly.
|
|
if (sectionName === "peerDependencies" && isRangeVersionSpecifier(dependencyVersion)) {
|
|
continue;
|
|
}
|
|
|
|
const dependencyManifest = resolvePublishedManifest(
|
|
dependencyName,
|
|
dependencyVersion,
|
|
packageDocsByName.get(dependencyName),
|
|
packageManifestsByKey,
|
|
);
|
|
const dependencyLookupKey = createManifestLookupKey(dependencyName, dependencyVersion);
|
|
|
|
if (!dependencyManifest) {
|
|
const dependencyDoc = packageDocsByName.get(dependencyName);
|
|
if (!dependencyDoc && !packageManifestsByKey.has(dependencyLookupKey)) {
|
|
problems.push(
|
|
createProblem(
|
|
`${sectionName} requires ${dependencyName}@${dependencyVersion}, but npm publication metadata was not fetched for that dependency`,
|
|
),
|
|
);
|
|
continue;
|
|
}
|
|
|
|
problems.push(
|
|
createProblem(
|
|
`${sectionName} requires ${dependencyName}@${dependencyVersion}, but npm does not expose that version`,
|
|
),
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
return problems;
|
|
}
|
|
|
|
export function collectInternalDependencyProblems(
|
|
manifest,
|
|
packageDocsByName,
|
|
packageManifestsByKey = new Map(),
|
|
) {
|
|
return collectInternalDependencyProblemEntries(
|
|
manifest,
|
|
packageDocsByName,
|
|
packageManifestsByKey,
|
|
).map((problem) => problem.message);
|
|
}
|
|
|
|
function requireManifest(packageName, version, packageDoc, packageManifestsByKey, problems) {
|
|
const manifest = resolvePublishedManifest(packageName, version, packageDoc, packageManifestsByKey);
|
|
if (!manifest) {
|
|
if (problems) {
|
|
problems.push(createProblem(`${packageName}: npm registry is missing manifest data for ${version}`));
|
|
}
|
|
return null;
|
|
}
|
|
return manifest;
|
|
}
|
|
|
|
export function verifyPackageRegistryProblems({
|
|
packageName,
|
|
packageDoc,
|
|
packageDocsByName,
|
|
packageManifestsByKey = new Map(),
|
|
channel,
|
|
distTag,
|
|
targetVersion,
|
|
allowCanaryLatest,
|
|
}) {
|
|
const problems = [];
|
|
const distTags = packageDoc["dist-tags"] ?? {};
|
|
const taggedVersion = distTags[distTag];
|
|
|
|
if (taggedVersion !== targetVersion) {
|
|
problems.push(
|
|
createProblem(
|
|
`${packageName}: dist-tag ${distTag} resolves to ${taggedVersion ?? "<missing>"}, expected ${targetVersion}`,
|
|
),
|
|
);
|
|
}
|
|
|
|
const targetManifest = requireManifest(packageName, targetVersion, packageDoc, packageManifestsByKey, problems);
|
|
if (targetManifest) {
|
|
for (const problem of collectInternalDependencyProblemEntries(
|
|
targetManifest,
|
|
packageDocsByName,
|
|
packageManifestsByKey,
|
|
)) {
|
|
problems.push(createProblem(`${packageName}@${targetVersion}: ${problem.message}`, problem));
|
|
}
|
|
}
|
|
|
|
if (channel === "canary") {
|
|
const latestVersion = distTags.latest;
|
|
|
|
if (latestVersion && isCanaryVersion(latestVersion) && !allowCanaryLatest) {
|
|
problems.push(
|
|
createProblem(
|
|
`${packageName}: latest dist-tag still resolves to canary ${latestVersion}; if that state is intentional, rerun the verification script directly with --allow-canary-latest`,
|
|
{ retriable: false },
|
|
),
|
|
);
|
|
}
|
|
|
|
if (latestVersion && isCanaryVersion(latestVersion)) {
|
|
const latestManifest = requireManifest(
|
|
packageName,
|
|
latestVersion,
|
|
packageDoc,
|
|
packageManifestsByKey,
|
|
problems,
|
|
);
|
|
if (latestManifest) {
|
|
for (const problem of collectInternalDependencyProblemEntries(
|
|
latestManifest,
|
|
packageDocsByName,
|
|
packageManifestsByKey,
|
|
)) {
|
|
problems.push(createProblem(`${packageName}@${latestVersion} via latest: ${problem.message}`, problem));
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
return problems;
|
|
}
|
|
|
|
export function verifyPackageRegistryState(options) {
|
|
return verifyPackageRegistryProblems(options).map((problem) => problem.message);
|
|
}
|
|
|
|
function collectInternalDependencyVersions(manifest) {
|
|
const dependencyVersions = [];
|
|
|
|
for (const [sectionName, deps] of [
|
|
["dependencies", manifest.dependencies ?? {}],
|
|
["optionalDependencies", manifest.optionalDependencies ?? {}],
|
|
["peerDependencies", manifest.peerDependencies ?? {}],
|
|
]) {
|
|
for (const [dependencyName, dependencyVersion] of Object.entries(deps)) {
|
|
if (!dependencyName.startsWith("@paperclipai/")) {
|
|
continue;
|
|
}
|
|
|
|
if (typeof dependencyVersion !== "string" || !dependencyVersion) {
|
|
continue;
|
|
}
|
|
|
|
if (sectionName === "peerDependencies" && isRangeVersionSpecifier(dependencyVersion)) {
|
|
continue;
|
|
}
|
|
|
|
dependencyVersions.push({
|
|
packageName: dependencyName,
|
|
version: dependencyVersion,
|
|
});
|
|
}
|
|
}
|
|
|
|
return dependencyVersions;
|
|
}
|
|
|
|
async function main() {
|
|
const options = parseArgs(process.argv.slice(2));
|
|
const packageNames = [...new Set(options.packages)];
|
|
const packageDocsByName = new Map();
|
|
const packageManifestsByKey = new Map();
|
|
|
|
await Promise.all(
|
|
packageNames.map(async (packageName) => {
|
|
packageDocsByName.set(packageName, await fetchPackageDocument(packageName));
|
|
}),
|
|
);
|
|
|
|
const versionsToFetchByPackage = new Map();
|
|
for (const packageName of packageNames) {
|
|
const packageDoc = packageDocsByName.get(packageName);
|
|
const versionsToFetch = new Set([options.targetVersion]);
|
|
const latestVersion = packageDoc?.["dist-tags"]?.latest;
|
|
if (latestVersion && isCanaryVersion(latestVersion)) {
|
|
versionsToFetch.add(latestVersion);
|
|
}
|
|
versionsToFetchByPackage.set(packageName, versionsToFetch);
|
|
}
|
|
|
|
await Promise.all(
|
|
[...versionsToFetchByPackage.entries()].flatMap(([packageName, versionsToFetch]) =>
|
|
[...versionsToFetch].map(async (version) => {
|
|
packageManifestsByKey.set(
|
|
createManifestLookupKey(packageName, version),
|
|
await fetchPackageManifest(packageName, version, { allowMissing: true }),
|
|
);
|
|
}),
|
|
),
|
|
);
|
|
|
|
const dependencyVersionsByKey = new Map();
|
|
for (const [packageName, versionsToFetch] of versionsToFetchByPackage.entries()) {
|
|
for (const version of versionsToFetch) {
|
|
const manifest = resolvePublishedManifest(
|
|
packageName,
|
|
version,
|
|
packageDocsByName.get(packageName),
|
|
packageManifestsByKey,
|
|
);
|
|
if (!manifest) {
|
|
continue;
|
|
}
|
|
|
|
for (const dependencyVersion of collectInternalDependencyVersions(manifest)) {
|
|
dependencyVersionsByKey.set(
|
|
createManifestLookupKey(dependencyVersion.packageName, dependencyVersion.version),
|
|
dependencyVersion,
|
|
);
|
|
}
|
|
}
|
|
}
|
|
|
|
await Promise.all(
|
|
[...dependencyVersionsByKey.values()].map(async ({ packageName, version }) => {
|
|
const lookupKey = createManifestLookupKey(packageName, version);
|
|
if (packageManifestsByKey.has(lookupKey)) {
|
|
return;
|
|
}
|
|
|
|
packageManifestsByKey.set(
|
|
lookupKey,
|
|
await fetchPackageManifest(packageName, version, { allowMissing: true }),
|
|
);
|
|
}),
|
|
);
|
|
|
|
const problems = [];
|
|
|
|
for (const packageName of packageNames) {
|
|
process.stdout.write(` Verifying ${packageName} on dist-tag ${options.distTag}\n`);
|
|
const packageProblems = verifyPackageRegistryProblems({
|
|
packageName,
|
|
packageDoc: packageDocsByName.get(packageName),
|
|
packageDocsByName,
|
|
packageManifestsByKey,
|
|
channel: options.channel,
|
|
distTag: options.distTag,
|
|
targetVersion: options.targetVersion,
|
|
allowCanaryLatest: options.allowCanaryLatest,
|
|
});
|
|
|
|
if (packageProblems.length === 0) {
|
|
process.stdout.write(` ✓ dist-tag and published internal dependencies are consistent\n`);
|
|
continue;
|
|
}
|
|
|
|
for (const problem of packageProblems) {
|
|
process.stderr.write(` ✗ ${problem.message}\n`);
|
|
problems.push(problem);
|
|
}
|
|
}
|
|
|
|
if (problems.length > 0) {
|
|
const exitCode = problems.some((problem) => !problem.retriable)
|
|
? EXIT_NON_RETRIABLE_FAILURE
|
|
: EXIT_RETRIABLE_FAILURE;
|
|
throw createExitError(`npm registry verification failed for ${problems.length} problem(s)`, exitCode);
|
|
}
|
|
}
|
|
|
|
const isDirectRun = process.argv[1] && import.meta.url === pathToFileURL(process.argv[1]).href;
|
|
|
|
if (isDirectRun) {
|
|
main().catch((error) => {
|
|
process.stderr.write(`Error: ${error.message}\n`);
|
|
process.exit(error.exitCode ?? EXIT_RETRIABLE_FAILURE);
|
|
});
|
|
}
|