forked from farhoodlabs/paperclip
a3de1d764d
## Thinking Path > - Paperclip is a control plane for autonomous AI companies, where adapters are the boundary between the board, agents, and execution runtimes. > - Local adapters currently expose a primary runtime configuration, but operators often need a cheaper model lane for routine or low-risk work. > - That cheap lane has to stay adapter-owned: runtime profile settings should not mutate the primary adapter config or bypass existing auth/secret mediation. > - Issue creation also needs an ergonomic way to request primary, cheap, or custom model behavior for a selected assignee. > - This pull request adds a first-class `cheap` model profile contract across adapter capabilities, heartbeat config resolution, agent configuration, and issue creation. > - The benefit is cheaper task execution can be configured and requested explicitly while preserving adapter boundaries, secret handling, and audit visibility. ## What Changed - Added adapter model-profile capability metadata and a `cheap` profile contract for supported local adapters. - Applied `runtimeConfig.modelProfiles.cheap.adapterConfig` during heartbeat config resolution, including requested/applied/fallback run metadata. - Added agent configuration UI for cheap model profile settings without writing those settings into primary `adapterConfig`. - Added New Issue assignee model lane controls for Primary / Cheap / Custom and request payload handling. - Added run ledger profile badges and Storybook stories for the new cheap-lane UI states. - Added tests for validators, heartbeat model profile application, permission/secret mediation, UI payload helpers, and run ledger rendering. - Added committed UI verification screenshots under `docs/pr-screenshots/pap-2837/`. - Addressed Greptile review feedback around cheap-profile defaults, shared profile types, and fallback test data. ## Verification Local: - `pnpm exec vitest run packages/shared/src/validators/issue.test.ts server/src/__tests__/adapter-registry.test.ts server/src/__tests__/agent-permissions-routes.test.ts server/src/__tests__/heartbeat-model-profile.test.ts ui/src/components/IssueRunLedger.test.tsx ui/src/lib/agent-config-patch.test.ts ui/src/lib/issue-assignee-overrides.test.ts ui/src/lib/new-agent-runtime-config.test.ts` — passed, 8 files / 103 tests. - `pnpm exec vitest run ui/src/lib/new-agent-runtime-config.test.ts ui/src/components/IssueRunLedger.test.tsx` — passed after Greptile/rebase follow-up, 2 files / 17 tests. - `pnpm --filter @paperclipai/ui typecheck` — passed after Greptile/rebase follow-up. - `pnpm -r typecheck` — passed. - `pnpm build` — passed. - `pnpm test:run` — did not complete successfully in this local worktree: it stopped in pre-existing `@paperclipai/adapter-utils` sandbox/SSH fixture suites outside this PR diff. Failures were 5s local timeouts plus `git init -b` unsupported by this machine's Git 2.21.0. The branch-specific targeted suites above passed. - Branch was fetched/rebased onto `public-gh/master`; `git rev-list --left-right --count public-gh/master...HEAD` reports `0 9`. Remote PR checks on latest head `e30bf399146451c86cee98ed528d51d33fa5af5a`: - `policy` — passed. - `verify` — passed. - `e2e` — passed. - `Greptile Review` — passed, confidence score 5/5; Greptile review threads resolved. - `security/snyk (cryppadotta)` — passed. Screenshots: - [New issue cheap lane desktop](https://github.com/paperclipai/paperclip/blob/PAP-2837-plan-cheap-model-for-adapters-that-can-support-it/docs/pr-screenshots/pap-2837/newissue-cheap-desktop.png) - [New issue custom lane desktop](https://github.com/paperclipai/paperclip/blob/PAP-2837-plan-cheap-model-for-adapters-that-can-support-it/docs/pr-screenshots/pap-2837/newissue-custom-desktop.png) - [New issue unsupported adapter desktop](https://github.com/paperclipai/paperclip/blob/PAP-2837-plan-cheap-model-for-adapters-that-can-support-it/docs/pr-screenshots/pap-2837/newissue-unsupported-desktop.png) - [Run ledger model profile badges desktop](https://github.com/paperclipai/paperclip/blob/PAP-2837-plan-cheap-model-for-adapters-that-can-support-it/docs/pr-screenshots/pap-2837/runledger-profile-badges-desktop.png) - Mobile variants are also in `docs/pr-screenshots/pap-2837/`. ## Risks - Medium: heartbeat config mediation now merges runtime model profiles into adapter configs, so adapter secret normalization and host-command restrictions must keep covering nested config paths. - Medium: the UI adds another issue creation choice; unsupported adapters must keep hiding the cheap lane and preserve primary behavior. - Low migration risk: no database migration is included. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used OpenAI Codex coding agent using GPT-5-class reasoning with repo tool use and command execution. Exact served model/context window was not exposed by the runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [ ] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
181 lines
5.1 KiB
TypeScript
181 lines
5.1 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { MAX_ISSUE_REQUEST_DEPTH } from "../index.js";
|
|
import {
|
|
addIssueCommentSchema,
|
|
createIssueSchema,
|
|
respondIssueThreadInteractionSchema,
|
|
suggestedTaskDraftSchema,
|
|
updateIssueSchema,
|
|
upsertIssueDocumentSchema,
|
|
} from "./issue.js";
|
|
import { createAgentSchema } from "./agent.js";
|
|
|
|
describe("issue validators", () => {
|
|
it("passes real line breaks through unchanged", () => {
|
|
const parsed = createIssueSchema.parse({
|
|
title: "Follow up PR",
|
|
description: "Line 1\n\nLine 2",
|
|
});
|
|
|
|
expect(parsed.description).toBe("Line 1\n\nLine 2");
|
|
});
|
|
|
|
it("accepts null and omitted optional multiline issue fields", () => {
|
|
expect(createIssueSchema.parse({ title: "Follow up PR", description: null }).description)
|
|
.toBeNull();
|
|
expect(createIssueSchema.parse({ title: "Follow up PR" }).description)
|
|
.toBeUndefined();
|
|
expect(updateIssueSchema.parse({ comment: undefined }).comment)
|
|
.toBeUndefined();
|
|
});
|
|
|
|
it("normalizes JSON-escaped line breaks in issue descriptions", () => {
|
|
const parsed = createIssueSchema.parse({
|
|
title: "Follow up PR",
|
|
description: "PR: https://example.com/pr/1\\n\\nShip the follow-up.",
|
|
});
|
|
|
|
expect(parsed.description).toBe("PR: https://example.com/pr/1\n\nShip the follow-up.");
|
|
});
|
|
|
|
it("normalizes escaped line breaks in issue update comments", () => {
|
|
const parsed = updateIssueSchema.parse({
|
|
comment: "Done\\n\\n- Verified the route",
|
|
});
|
|
|
|
expect(parsed.comment).toBe("Done\n\n- Verified the route");
|
|
});
|
|
|
|
it("normalizes escaped line breaks in issue comment bodies", () => {
|
|
const parsed = addIssueCommentSchema.parse({
|
|
body: "Progress update\\r\\n\\r\\nNext action.",
|
|
});
|
|
|
|
expect(parsed.body).toBe("Progress update\n\nNext action.");
|
|
});
|
|
|
|
it("normalizes escaped line breaks in generated task drafts", () => {
|
|
const parsed = suggestedTaskDraftSchema.parse({
|
|
clientKey: "task-1",
|
|
title: "Follow up",
|
|
description: "Line 1\\n\\nLine 2",
|
|
});
|
|
|
|
expect(parsed.description).toBe("Line 1\n\nLine 2");
|
|
});
|
|
|
|
it("normalizes escaped line breaks in thread summaries and documents", () => {
|
|
const response = respondIssueThreadInteractionSchema.parse({
|
|
answers: [],
|
|
summaryMarkdown: "Summary\\n\\nNext action",
|
|
});
|
|
const document = upsertIssueDocumentSchema.parse({
|
|
format: "markdown",
|
|
body: "# Plan\\n\\nShip it",
|
|
});
|
|
|
|
expect(response.summaryMarkdown).toBe("Summary\n\nNext action");
|
|
expect(document.body).toBe("# Plan\n\nShip it");
|
|
});
|
|
|
|
it("clamps oversized requestDepth values on create", () => {
|
|
const parsed = createIssueSchema.parse({
|
|
title: "Clamp request depth",
|
|
requestDepth: MAX_ISSUE_REQUEST_DEPTH + 500,
|
|
});
|
|
|
|
expect(parsed.requestDepth).toBe(MAX_ISSUE_REQUEST_DEPTH);
|
|
});
|
|
|
|
it("clamps oversized requestDepth values on update", () => {
|
|
const parsed = updateIssueSchema.parse({
|
|
requestDepth: MAX_ISSUE_REQUEST_DEPTH + 1,
|
|
});
|
|
|
|
expect(parsed.requestDepth).toBe(MAX_ISSUE_REQUEST_DEPTH);
|
|
});
|
|
|
|
it("accepts the cheap model profile in issue assignee adapter overrides", () => {
|
|
const parsed = createIssueSchema.parse({
|
|
title: "Run a cheap heartbeat",
|
|
assigneeAdapterOverrides: {
|
|
modelProfile: "cheap",
|
|
},
|
|
});
|
|
|
|
expect(parsed.assigneeAdapterOverrides?.modelProfile).toBe("cheap");
|
|
});
|
|
|
|
it("rejects unknown issue model profile keys", () => {
|
|
const parsed = updateIssueSchema.safeParse({
|
|
assigneeAdapterOverrides: {
|
|
modelProfile: "fast",
|
|
},
|
|
});
|
|
|
|
expect(parsed.success).toBe(false);
|
|
});
|
|
|
|
it("validates agent runtime cheap model profile config without rejecting other runtime fields", () => {
|
|
const parsed = createAgentSchema.parse({
|
|
name: "Coder",
|
|
adapterType: "codex_local",
|
|
runtimeConfig: {
|
|
heartbeat: { enabled: true },
|
|
modelProfiles: {
|
|
cheap: {
|
|
enabled: true,
|
|
label: "Cheap Codex",
|
|
adapterConfig: {
|
|
model: "gpt-5.3-codex-spark",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
});
|
|
|
|
expect(parsed.runtimeConfig.modelProfiles?.cheap?.adapterConfig).toEqual({
|
|
model: "gpt-5.3-codex-spark",
|
|
});
|
|
expect(parsed.runtimeConfig.heartbeat).toEqual({ enabled: true });
|
|
});
|
|
|
|
it("validates cheap model profile env bindings like top-level adapter config", () => {
|
|
const parsed = createAgentSchema.safeParse({
|
|
name: "Coder",
|
|
adapterType: "codex_local",
|
|
runtimeConfig: {
|
|
modelProfiles: {
|
|
cheap: {
|
|
adapterConfig: {
|
|
env: {
|
|
API_TOKEN: 123,
|
|
},
|
|
},
|
|
},
|
|
},
|
|
},
|
|
});
|
|
|
|
expect(parsed.success).toBe(false);
|
|
});
|
|
|
|
it("rejects unknown agent runtime model profile keys", () => {
|
|
const parsed = createAgentSchema.safeParse({
|
|
name: "Coder",
|
|
adapterType: "codex_local",
|
|
runtimeConfig: {
|
|
modelProfiles: {
|
|
fast: {
|
|
adapterConfig: {
|
|
model: "gpt-5-mini",
|
|
},
|
|
},
|
|
},
|
|
},
|
|
});
|
|
|
|
expect(parsed.success).toBe(false);
|
|
});
|
|
});
|