forked from farhoodlabs/paperclip
a1835cfa5e
## Thinking Path > - Paperclip orchestrates AI-agent companies through a company-scoped control plane. > - Plugins extend that control plane, but plugin workers still call back into host APIs. > - Those worker-to-host calls need the same company boundary guarantees as normal API routes. > - Plugin action handlers also need authenticated actor context from the host instead of trusting caller-supplied params. > - This pull request hardens plugin bridge/action scope and keeps plugin operation issues out of normal issue surfaces. > - The benefit is safer plugin execution with clearer authorization boundaries and better test coverage. ## What Changed - Added host-owned invocation context plumbing for nested plugin worker calls. - Added actor context to plugin `performAction` calls and test harness helpers. - Enforced company invocation scope on worker-to-host calls and filtered company lists to the active invocation scope. - Extended plugin action route tests for board and agent actor context, spoofed company params, and cross-company rejection. - Extended plugin worker manager coverage for invocation-scope propagation. - Filtered typed and legacy plugin operation issue origins from default issue/inbox lists. ## Verification - `pnpm --filter @paperclipai/plugin-sdk build` - `NODE_ENV=test pnpm exec vitest run packages/plugins/sdk/tests/host-client-factory.test.ts packages/plugins/sdk/tests/testing-actions.test.ts server/src/__tests__/plugin-routes-authz.test.ts server/src/__tests__/plugin-worker-manager.test.ts server/src/__tests__/issues-service.test.ts` Note: embedded Postgres issue-service tests reported host-level Postgres init skip for 47 tests; the non-embedded targeted tests passed. ## Risks - Medium: plugin host authorization paths are sensitive, and external plugins may rely on previously loose company params. - Mitigation: the change only tightens calls when the host attached a company invocation scope and includes explicit tests for board, agent, and nested worker calls. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI GPT-5 Codex via `codex_local`, tool-enabled coding session; exact context window not exposed by this runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge
101 lines
2.1 KiB
JavaScript
101 lines
2.1 KiB
JavaScript
const readline = require("node:readline");
|
|
|
|
let nextRequestId = 1;
|
|
const pendingNested = new Map();
|
|
|
|
function send(message) {
|
|
process.stdout.write(`${JSON.stringify(message)}\n`);
|
|
}
|
|
|
|
function sendNestedHostRequest(originalRequest, invocationId) {
|
|
const nestedId = `nested-${nextRequestId++}`;
|
|
const params = originalRequest.params?.params ?? {};
|
|
const mode = params.mode;
|
|
const requestedCompanyId = params.requestedCompanyId;
|
|
const nestedRequest = {
|
|
jsonrpc: "2.0",
|
|
id: nestedId,
|
|
method: "companies.get",
|
|
params: {
|
|
companyId: requestedCompanyId,
|
|
},
|
|
};
|
|
|
|
if (mode === "echo") {
|
|
nestedRequest.paperclipInvocationId = invocationId;
|
|
} else if (mode === "unknown") {
|
|
nestedRequest.paperclipInvocationId = "unknown-invocation";
|
|
}
|
|
|
|
pendingNested.set(nestedId, originalRequest.id);
|
|
send(nestedRequest);
|
|
}
|
|
|
|
const rl = readline.createInterface({
|
|
input: process.stdin,
|
|
crlfDelay: Infinity,
|
|
});
|
|
|
|
rl.on("line", (line) => {
|
|
if (!line.trim()) return;
|
|
const message = JSON.parse(line);
|
|
|
|
if (message.id && pendingNested.has(message.id)) {
|
|
const originalId = pendingNested.get(message.id);
|
|
pendingNested.delete(message.id);
|
|
if (message.error) {
|
|
send({
|
|
jsonrpc: "2.0",
|
|
id: originalId,
|
|
error: message.error,
|
|
});
|
|
return;
|
|
}
|
|
|
|
send({
|
|
jsonrpc: "2.0",
|
|
id: originalId,
|
|
result: message.result,
|
|
});
|
|
return;
|
|
}
|
|
|
|
const method = message && typeof message.method === "string" ? message.method : null;
|
|
|
|
if (method === "initialize") {
|
|
send({
|
|
jsonrpc: "2.0",
|
|
id: message.id,
|
|
result: {
|
|
ok: true,
|
|
supportedMethods: ["getData", "performAction"],
|
|
},
|
|
});
|
|
return;
|
|
}
|
|
|
|
if (method === "getData" || method === "performAction") {
|
|
sendNestedHostRequest(message, message.paperclipInvocation?.id);
|
|
return;
|
|
}
|
|
|
|
if (method === "shutdown") {
|
|
send({
|
|
jsonrpc: "2.0",
|
|
id: message.id,
|
|
result: {},
|
|
});
|
|
setImmediate(() => process.exit(0));
|
|
return;
|
|
}
|
|
|
|
send({
|
|
jsonrpc: "2.0",
|
|
id: message.id,
|
|
error: {
|
|
code: -32601,
|
|
message: `Unhandled method: ${method}`,
|
|
},
|
|
});
|
|
});
|