forked from farhoodlabs/paperclip
9c6f551595
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies. > - The plugin system is the extension path for optional capabilities that should not require core product changes for every integration. > - Plugins need scoped host APIs for issue orchestration, documents, wakeups, summaries, activity attribution, and isolated database state. > - Without those host APIs, richer plugins either cannot coordinate Paperclip work safely or need privileged core-side special cases. > - This pull request adds the plugin orchestration host surface, scoped route dispatch, a database namespace layer, and a smoke plugin that exercises the contract. > - The benefit is a broader plugin API that remains company-scoped, auditable, and covered by tests. ## What Changed - Added plugin orchestration host APIs for issue creation, document access, wakeups, summaries, plugin-origin activity, and scoped API route dispatch. - Added plugin database namespace tables, schema exports, migration checks, and idempotent replay coverage under migration `0059_plugin_database_namespaces`. - Added shared plugin route/API types and validators used by server and SDK boundaries. - Expanded plugin SDK types, protocol helpers, worker RPC host behavior, and testing utilities for orchestration flows. - Added the `plugin-orchestration-smoke-example` package to exercise scoped routes, restricted database namespaces, issue orchestration, documents, wakeups, summaries, and UI status surfaces. - Kept the new orchestration smoke fixture out of the root pnpm workspace importer so this PR preserves the repository policy of not committing `pnpm-lock.yaml`. - Updated plugin docs and database docs for the new orchestration and database namespace surfaces. - Rebased the branch onto `public-gh/master`, resolved conflicts, and removed `pnpm-lock.yaml` from the final PR diff. ## Verification - `pnpm install --frozen-lockfile` - `pnpm --filter @paperclipai/db typecheck` - `pnpm exec vitest run packages/db/src/client.test.ts` - `pnpm exec vitest run server/src/__tests__/plugin-database.test.ts server/src/__tests__/plugin-orchestration-apis.test.ts server/src/__tests__/plugin-routes-authz.test.ts server/src/__tests__/plugin-scoped-api-routes.test.ts server/src/__tests__/plugin-sdk-orchestration-contract.test.ts` - From `packages/plugins/examples/plugin-orchestration-smoke-example`: `pnpm exec vitest run --config ./vitest.config.ts` - `pnpm --dir packages/plugins/examples/plugin-orchestration-smoke-example run typecheck` - `pnpm --filter @paperclipai/server typecheck` - PR CI on latest head `293fc67c`: `policy`, `verify`, `e2e`, and `security/snyk` all passed. ## Risks - Medium risk: this expands plugin host authority, so route auth, company scoping, and plugin-origin activity attribution need careful review. - Medium risk: database namespace migration behavior must remain idempotent for environments that may have seen earlier branch versions. - Medium risk: the orchestration smoke fixture is intentionally excluded from the root workspace importer to avoid a `pnpm-lock.yaml` PR diff; direct fixture verification remains listed above. - Low operational risk from the PR setup itself: the branch is rebased onto current `master`, the migration is ordered after upstream `0057`/`0058`, and `pnpm-lock.yaml` is not in the final diff. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. Roadmap checked: this work aligns with the completed Plugin system milestone and extends the plugin surface rather than duplicating an unrelated planned core feature. ## Model Used - OpenAI Codex, GPT-5-based coding agent in a tool-enabled CLI environment. Exact hosted model build and context-window size are not exposed by the runtime; reasoning/tool use were enabled for repository inspection, editing, testing, git operations, and PR creation. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots (N/A: no core UI screen change; example plugin UI contract is covered by tests) - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
241 lines
7.2 KiB
TypeScript
241 lines
7.2 KiB
TypeScript
import { randomUUID } from "node:crypto";
|
|
import { describe, expect, it } from "vitest";
|
|
import type { Issue, PaperclipPluginManifestV1 } from "@paperclipai/shared";
|
|
import { createTestHarness } from "../../../packages/plugins/sdk/src/testing.js";
|
|
|
|
function manifest(capabilities: PaperclipPluginManifestV1["capabilities"]): PaperclipPluginManifestV1 {
|
|
return {
|
|
id: "paperclip.test-orchestration",
|
|
apiVersion: 1,
|
|
version: "0.1.0",
|
|
displayName: "Test Orchestration",
|
|
description: "Test plugin",
|
|
author: "Paperclip",
|
|
categories: ["automation"],
|
|
capabilities,
|
|
entrypoints: { worker: "./dist/worker.js" },
|
|
};
|
|
}
|
|
|
|
function issue(input: Partial<Issue> & Pick<Issue, "id" | "companyId" | "title">): Issue {
|
|
const now = new Date();
|
|
return {
|
|
id: input.id,
|
|
companyId: input.companyId,
|
|
projectId: null,
|
|
projectWorkspaceId: null,
|
|
goalId: null,
|
|
parentId: null,
|
|
title: input.title,
|
|
description: null,
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
checkoutRunId: null,
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
createdByAgentId: null,
|
|
createdByUserId: null,
|
|
issueNumber: null,
|
|
identifier: null,
|
|
requestDepth: 0,
|
|
billingCode: null,
|
|
assigneeAdapterOverrides: null,
|
|
executionWorkspaceId: null,
|
|
executionWorkspacePreference: null,
|
|
executionWorkspaceSettings: null,
|
|
startedAt: null,
|
|
completedAt: null,
|
|
cancelledAt: null,
|
|
hiddenAt: null,
|
|
createdAt: now,
|
|
updatedAt: now,
|
|
...input,
|
|
};
|
|
}
|
|
|
|
describe("plugin SDK orchestration contract", () => {
|
|
it("supports expanded issue create fields and relation helpers", async () => {
|
|
const companyId = randomUUID();
|
|
const blockerIssueId = randomUUID();
|
|
const harness = createTestHarness({
|
|
manifest: manifest(["issues.create", "issue.relations.read", "issue.relations.write", "issue.subtree.read"]),
|
|
});
|
|
harness.seed({
|
|
issues: [issue({ id: blockerIssueId, companyId, title: "Blocker" })],
|
|
});
|
|
|
|
const created = await harness.ctx.issues.create({
|
|
companyId,
|
|
title: "Generated issue",
|
|
status: "todo",
|
|
assigneeUserId: "board-user",
|
|
billingCode: "mission:alpha",
|
|
originId: "mission-alpha",
|
|
blockedByIssueIds: [blockerIssueId],
|
|
});
|
|
|
|
expect(created.originKind).toBe("plugin:paperclip.test-orchestration");
|
|
expect(created.originId).toBe("mission-alpha");
|
|
expect(created.billingCode).toBe("mission:alpha");
|
|
expect(created.assigneeUserId).toBe("board-user");
|
|
|
|
await expect(harness.ctx.issues.relations.get(created.id, companyId)).resolves.toEqual({
|
|
blockedBy: [
|
|
expect.objectContaining({
|
|
id: blockerIssueId,
|
|
title: "Blocker",
|
|
}),
|
|
],
|
|
blocks: [],
|
|
});
|
|
|
|
await expect(harness.ctx.issues.relations.removeBlockers(created.id, [blockerIssueId], companyId)).resolves.toEqual({
|
|
blockedBy: [],
|
|
blocks: [],
|
|
});
|
|
|
|
await expect(harness.ctx.issues.relations.addBlockers(created.id, [blockerIssueId], companyId)).resolves.toEqual({
|
|
blockedBy: [expect.objectContaining({ id: blockerIssueId })],
|
|
blocks: [],
|
|
});
|
|
|
|
await expect(
|
|
harness.ctx.issues.getSubtree(created.id, companyId, { includeRelations: true }),
|
|
).resolves.toMatchObject({
|
|
rootIssueId: created.id,
|
|
issueIds: [created.id],
|
|
relations: {
|
|
[created.id]: {
|
|
blockedBy: [expect.objectContaining({ id: blockerIssueId })],
|
|
},
|
|
},
|
|
});
|
|
});
|
|
|
|
it("enforces plugin origin namespaces in the test harness", async () => {
|
|
const companyId = randomUUID();
|
|
const harness = createTestHarness({
|
|
manifest: manifest(["issues.create", "issues.update", "issues.read"]),
|
|
});
|
|
|
|
const created = await harness.ctx.issues.create({
|
|
companyId,
|
|
title: "Generated issue",
|
|
originKind: "plugin:paperclip.test-orchestration:feature",
|
|
});
|
|
|
|
expect(created.originKind).toBe("plugin:paperclip.test-orchestration:feature");
|
|
await expect(
|
|
harness.ctx.issues.list({
|
|
companyId,
|
|
originKind: "plugin:paperclip.test-orchestration:feature",
|
|
}),
|
|
).resolves.toHaveLength(1);
|
|
await expect(
|
|
harness.ctx.issues.create({
|
|
companyId,
|
|
title: "Spoofed issue",
|
|
originKind: "plugin:other.plugin:feature",
|
|
}),
|
|
).rejects.toThrow("Plugin may only use originKind values under plugin:paperclip.test-orchestration");
|
|
await expect(
|
|
harness.ctx.issues.update(
|
|
created.id,
|
|
{ originKind: "plugin:other.plugin:feature" },
|
|
companyId,
|
|
),
|
|
).rejects.toThrow("Plugin may only use originKind values under plugin:paperclip.test-orchestration");
|
|
});
|
|
|
|
it("enforces checkout and wakeup capabilities in the test harness", async () => {
|
|
const companyId = randomUUID();
|
|
const agentId = randomUUID();
|
|
const runId = randomUUID();
|
|
const checkedOutIssueId = randomUUID();
|
|
const harness = createTestHarness({
|
|
manifest: manifest(["issues.checkout", "issues.wakeup", "issues.read"]),
|
|
});
|
|
harness.seed({
|
|
issues: [
|
|
issue({
|
|
id: checkedOutIssueId,
|
|
companyId,
|
|
title: "Checked out",
|
|
status: "in_progress",
|
|
assigneeAgentId: agentId,
|
|
checkoutRunId: runId,
|
|
}),
|
|
],
|
|
});
|
|
|
|
await expect(
|
|
harness.ctx.issues.assertCheckoutOwner({
|
|
issueId: checkedOutIssueId,
|
|
companyId,
|
|
actorAgentId: agentId,
|
|
actorRunId: runId,
|
|
}),
|
|
).resolves.toMatchObject({
|
|
issueId: checkedOutIssueId,
|
|
checkoutRunId: runId,
|
|
});
|
|
|
|
await expect(
|
|
harness.ctx.issues.requestWakeup(checkedOutIssueId, companyId, {
|
|
reason: "mission_advance",
|
|
}),
|
|
).resolves.toMatchObject({ queued: true });
|
|
|
|
await expect(
|
|
harness.ctx.issues.requestWakeups([checkedOutIssueId], companyId, {
|
|
reason: "mission_advance",
|
|
idempotencyKeyPrefix: "mission:alpha",
|
|
}),
|
|
).resolves.toEqual([
|
|
expect.objectContaining({
|
|
issueId: checkedOutIssueId,
|
|
queued: true,
|
|
}),
|
|
]);
|
|
});
|
|
|
|
it("rejects wakeups when blockers are unresolved", async () => {
|
|
const companyId = randomUUID();
|
|
const blockerIssueId = randomUUID();
|
|
const blockedIssueId = randomUUID();
|
|
const harness = createTestHarness({
|
|
manifest: manifest(["issues.wakeup", "issues.read"]),
|
|
});
|
|
harness.seed({
|
|
issues: [
|
|
issue({ id: blockerIssueId, companyId, title: "Unresolved blocker", status: "todo" }),
|
|
issue({
|
|
id: blockedIssueId,
|
|
companyId,
|
|
title: "Blocked work",
|
|
status: "todo",
|
|
assigneeAgentId: randomUUID(),
|
|
blockedBy: [
|
|
{
|
|
id: blockerIssueId,
|
|
identifier: null,
|
|
title: "Unresolved blocker",
|
|
status: "todo",
|
|
priority: "medium",
|
|
assigneeAgentId: null,
|
|
assigneeUserId: null,
|
|
},
|
|
],
|
|
}),
|
|
],
|
|
});
|
|
|
|
await expect(
|
|
harness.ctx.issues.requestWakeup(blockedIssueId, companyId),
|
|
).rejects.toThrow("Issue is blocked by unresolved blockers");
|
|
});
|
|
});
|