forked from farhoodlabs/paperclip
7f893ac4ec
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Reliable execution depends on heartbeat routing, issue lifecycle semantics, telemetry, and a fast enough local verification loop to keep regressions visible > - The remaining commits on this branch were mostly server/runtime correctness fixes plus test and documentation follow-ups in that area > - Those changes are logically separate from the UI-focused issue-detail and workspace/navigation branches even when they touch overlapping issue APIs > - This pull request groups the execution reliability, heartbeat, telemetry, and tooling changes into one standalone branch > - The benefit is a focused review of the control-plane correctness work, including the follow-up fix that restored the implicit comment-reopen helpers after branch splitting ## What Changed - Hardened issue/heartbeat execution behavior, including self-review stage skipping, deferred mention wakes during active execution, stranded execution recovery, active-run scoping, assignee resolution, and blocked-to-todo wake resumption - Reduced noisy polling/logging overhead by trimming issue run payloads, compacting persisted run logs, silencing high-volume request logs, and capping heartbeat-run queries in dashboard/inbox surfaces - Expanded telemetry and status semantics with adapter/model fields on task completion plus clearer status guidance in docs/onboarding material - Updated test infrastructure and verification defaults with faster route-test module isolation, cheaper default `pnpm test`, e2e isolation from local state, and repo verification follow-ups - Included docs/release housekeeping from the branch and added a small follow-up commit restoring the implicit comment-reopen helpers that were dropped during branch reconstruction ## Verification - `pnpm vitest run server/src/__tests__/issue-comment-reopen-routes.test.ts server/src/__tests__/issue-telemetry-routes.test.ts` - `pnpm vitest run server/src/__tests__/http-log-policy.test.ts server/src/__tests__/heartbeat-run-log.test.ts server/src/__tests__/health.test.ts` - `server/src/__tests__/activity-service.test.ts`, `server/src/__tests__/heartbeat-comment-wake-batching.test.ts`, and `server/src/__tests__/heartbeat-process-recovery.test.ts` were attempted on this host but the embedded Postgres harness reported init-script/data-dir problems and skipped or failed to start, so they are noted as environment-limited ## Risks - Medium: this branch changes core issue/heartbeat routing and reopen/wakeup behavior, so regressions would affect agent execution flow rather than isolated UI polish - Because it also updates verification infrastructure, reviewers should pay attention to whether the new tests are asserting the right failure modes and not just reshaping harness behavior ## Model Used - OpenAI Codex coding agent (GPT-5-class runtime in Codex CLI; exact deployed model ID is not exposed in this environment), reasoning enabled, tool use and local code execution enabled ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [ ] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
233 lines
7.4 KiB
TypeScript
233 lines
7.4 KiB
TypeScript
import express from "express";
|
|
import request from "supertest";
|
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
|
|
|
function makeDb(overrides: Record<string, unknown> = {}) {
|
|
const selectChain = {
|
|
from: vi.fn().mockReturnThis(),
|
|
where: vi.fn().mockReturnThis(),
|
|
leftJoin: vi.fn().mockReturnThis(),
|
|
innerJoin: vi.fn().mockReturnThis(),
|
|
groupBy: vi.fn().mockReturnThis(),
|
|
orderBy: vi.fn().mockReturnThis(),
|
|
limit: vi.fn().mockReturnThis(),
|
|
then: vi.fn().mockResolvedValue([]),
|
|
};
|
|
|
|
const thenableChain = Object.assign(Promise.resolve([]), selectChain);
|
|
|
|
return {
|
|
select: vi.fn().mockReturnValue(thenableChain),
|
|
insert: vi.fn().mockReturnValue({
|
|
values: vi.fn().mockReturnValue({ returning: vi.fn().mockResolvedValue([]) }),
|
|
}),
|
|
update: vi.fn().mockReturnValue({
|
|
set: vi.fn().mockReturnValue({ where: vi.fn().mockResolvedValue([]) }),
|
|
}),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
const mockCompanyService = vi.hoisted(() => ({
|
|
getById: vi.fn(),
|
|
update: vi.fn(),
|
|
}));
|
|
const mockAgentService = vi.hoisted(() => ({
|
|
getById: vi.fn(),
|
|
update: vi.fn(),
|
|
}));
|
|
const mockHeartbeatService = vi.hoisted(() => ({
|
|
cancelBudgetScopeWork: vi.fn().mockResolvedValue(undefined),
|
|
}));
|
|
const mockLogActivity = vi.hoisted(() => vi.fn());
|
|
const mockFetchAllQuotaWindows = vi.hoisted(() => vi.fn());
|
|
const mockCostService = vi.hoisted(() => ({
|
|
createEvent: vi.fn(),
|
|
summary: vi.fn().mockResolvedValue({ spendCents: 0 }),
|
|
byAgent: vi.fn().mockResolvedValue([]),
|
|
byAgentModel: vi.fn().mockResolvedValue([]),
|
|
byProvider: vi.fn().mockResolvedValue([]),
|
|
byBiller: vi.fn().mockResolvedValue([]),
|
|
windowSpend: vi.fn().mockResolvedValue([]),
|
|
byProject: vi.fn().mockResolvedValue([]),
|
|
}));
|
|
const mockFinanceService = vi.hoisted(() => ({
|
|
createEvent: vi.fn(),
|
|
summary: vi.fn().mockResolvedValue({ debitCents: 0, creditCents: 0, netCents: 0, estimatedDebitCents: 0, eventCount: 0 }),
|
|
byBiller: vi.fn().mockResolvedValue([]),
|
|
byKind: vi.fn().mockResolvedValue([]),
|
|
list: vi.fn().mockResolvedValue([]),
|
|
}));
|
|
const mockBudgetService = vi.hoisted(() => ({
|
|
overview: vi.fn().mockResolvedValue({
|
|
companyId: "company-1",
|
|
policies: [],
|
|
activeIncidents: [],
|
|
pausedAgentCount: 0,
|
|
pausedProjectCount: 0,
|
|
pendingApprovalCount: 0,
|
|
}),
|
|
upsertPolicy: vi.fn(),
|
|
resolveIncident: vi.fn(),
|
|
}));
|
|
|
|
function registerModuleMocks() {
|
|
vi.doMock("../services/index.js", () => ({
|
|
budgetService: () => mockBudgetService,
|
|
costService: () => mockCostService,
|
|
financeService: () => mockFinanceService,
|
|
companyService: () => mockCompanyService,
|
|
agentService: () => mockAgentService,
|
|
heartbeatService: () => mockHeartbeatService,
|
|
logActivity: mockLogActivity,
|
|
}));
|
|
|
|
vi.doMock("../services/quota-windows.js", () => ({
|
|
fetchAllQuotaWindows: mockFetchAllQuotaWindows,
|
|
}));
|
|
}
|
|
|
|
async function createApp() {
|
|
const [{ costRoutes }, { errorHandler }] = await Promise.all([
|
|
vi.importActual<typeof import("../routes/costs.js")>("../routes/costs.js"),
|
|
vi.importActual<typeof import("../middleware/index.js")>("../middleware/index.js"),
|
|
]);
|
|
const app = express();
|
|
app.use(express.json());
|
|
app.use((req, _res, next) => {
|
|
req.actor = { type: "board", userId: "board-user", source: "local_implicit" };
|
|
next();
|
|
});
|
|
app.use("/api", costRoutes(makeDb() as any));
|
|
app.use(errorHandler);
|
|
return app;
|
|
}
|
|
|
|
async function createAppWithActor(actor: any) {
|
|
const [{ costRoutes }, { errorHandler }] = await Promise.all([
|
|
vi.importActual<typeof import("../routes/costs.js")>("../routes/costs.js"),
|
|
vi.importActual<typeof import("../middleware/index.js")>("../middleware/index.js"),
|
|
]);
|
|
const app = express();
|
|
app.use(express.json());
|
|
app.use((req, _res, next) => {
|
|
req.actor = actor;
|
|
next();
|
|
});
|
|
app.use("/api", costRoutes(makeDb() as any));
|
|
app.use(errorHandler);
|
|
return app;
|
|
}
|
|
|
|
async function loadCostParsers() {
|
|
const { parseCostDateRange, parseCostLimit } = await import("../routes/costs.js");
|
|
return { parseCostDateRange, parseCostLimit };
|
|
}
|
|
|
|
beforeEach(() => {
|
|
vi.resetModules();
|
|
vi.doUnmock("../services/index.js");
|
|
vi.doUnmock("../services/quota-windows.js");
|
|
vi.doUnmock("../routes/costs.js");
|
|
vi.doUnmock("../middleware/index.js");
|
|
registerModuleMocks();
|
|
vi.clearAllMocks();
|
|
mockCompanyService.update.mockResolvedValue({
|
|
id: "company-1",
|
|
name: "Paperclip",
|
|
budgetMonthlyCents: 100,
|
|
spentMonthlyCents: 0,
|
|
});
|
|
mockAgentService.update.mockResolvedValue({
|
|
id: "agent-1",
|
|
companyId: "company-1",
|
|
name: "Budget Agent",
|
|
budgetMonthlyCents: 100,
|
|
spentMonthlyCents: 0,
|
|
});
|
|
mockBudgetService.upsertPolicy.mockResolvedValue(undefined);
|
|
});
|
|
|
|
describe("cost routes", () => {
|
|
it("accepts valid ISO date strings", async () => {
|
|
const { parseCostDateRange } = await loadCostParsers();
|
|
expect(parseCostDateRange({
|
|
from: "2026-01-01T00:00:00.000Z",
|
|
to: "2026-01-31T23:59:59.999Z",
|
|
})).toEqual({
|
|
from: new Date("2026-01-01T00:00:00.000Z"),
|
|
to: new Date("2026-01-31T23:59:59.999Z"),
|
|
});
|
|
});
|
|
|
|
it("returns 400 for an invalid 'from' date string", async () => {
|
|
const { parseCostDateRange } = await loadCostParsers();
|
|
expect(() => parseCostDateRange({ from: "not-a-date" })).toThrow(/invalid 'from' date/i);
|
|
});
|
|
|
|
it("returns 400 for an invalid 'to' date string", async () => {
|
|
const { parseCostDateRange } = await loadCostParsers();
|
|
expect(() => parseCostDateRange({ to: "banana" })).toThrow(/invalid 'to' date/i);
|
|
});
|
|
|
|
it("returns finance summary rows for valid requests", async () => {
|
|
const app = await createApp();
|
|
const res = await request(app)
|
|
.get("/api/companies/company-1/costs/finance-summary")
|
|
.query({ from: "2026-02-01T00:00:00.000Z", to: "2026-02-28T23:59:59.999Z" });
|
|
expect(res.status).toBe(200);
|
|
expect(mockFinanceService.summary).toHaveBeenCalled();
|
|
});
|
|
|
|
it("returns 400 for invalid finance event list limits", async () => {
|
|
const { parseCostLimit } = await loadCostParsers();
|
|
expect(() => parseCostLimit({ limit: "0" })).toThrow(/invalid 'limit'/i);
|
|
});
|
|
|
|
it("accepts valid finance event list limits", async () => {
|
|
const { parseCostLimit } = await loadCostParsers();
|
|
expect(parseCostLimit({ limit: "25" })).toBe(25);
|
|
});
|
|
|
|
it("rejects company budget updates for board users outside the company", async () => {
|
|
const app = await createAppWithActor({
|
|
type: "board",
|
|
userId: "board-user",
|
|
source: "session",
|
|
isInstanceAdmin: false,
|
|
companyIds: ["company-2"],
|
|
});
|
|
|
|
const res = await request(app)
|
|
.patch("/api/companies/company-1/budgets")
|
|
.send({ budgetMonthlyCents: 2500 });
|
|
|
|
expect(res.status).toBe(403);
|
|
expect(mockCompanyService.update).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("rejects agent budget updates for board users outside the agent company", async () => {
|
|
mockAgentService.getById.mockResolvedValue({
|
|
id: "agent-1",
|
|
companyId: "company-1",
|
|
name: "Budget Agent",
|
|
budgetMonthlyCents: 100,
|
|
spentMonthlyCents: 0,
|
|
});
|
|
const app = await createAppWithActor({
|
|
type: "board",
|
|
userId: "board-user",
|
|
source: "session",
|
|
isInstanceAdmin: false,
|
|
companyIds: ["company-2"],
|
|
});
|
|
|
|
const res = await request(app)
|
|
.patch("/api/agents/agent-1/budgets")
|
|
.send({ budgetMonthlyCents: 2500 });
|
|
|
|
expect(res.status).toBe(403);
|
|
expect(mockAgentService.update).not.toHaveBeenCalled();
|
|
});
|
|
});
|