forked from farhoodlabs/paperclip
d734bd43d1
## Thinking Path > - Paperclip is the control plane for autonomous AI companies, so agent work needs visible ownership, recovery, and operator controls. > - This local branch had accumulated several related control-plane reliability and operator-experience fixes across recovery actions, watchdog folding, model-profile defaults, mentions, markdown editing, plugin launchers, and small UI polish. > - The branch needed to be converted into a PR against the current `origin/master` without losing dirty work or including lockfile/workflow churn. > - The safest standalone shape is a single rollup PR because the recovery/server/UI files overlap heavily across the local commits and splitting would create avoidable conflicts. > - This pull request replays the local branch onto latest `origin/master`, preserves the uncommitted work as logical commits, and adds a Zod 4 validator compatibility fix found during verification. > - The benefit is that the May 17 local branch can be reviewed and merged as one coherent, conflict-free branch under the 100-file Greptile limit. ## What Changed - Rebased the local May 17 branch work onto current `origin/master` in a dedicated worktree. - Preserved and committed previously dirty changes for recovery retry handling, plugin/sidebar launcher polish, and `.herenow` ignores. - Added recovery-action behavior for returning source issues to `todo` when retrying source-scoped recovery. - Included the existing local recovery/liveness/watchdog fold, Codex cheap-profile, markdown/mention, duplicate-agent, and UI polish commits from the branch. - Normalized shared validator `z.record(...)` schemas to explicit string-key records for Zod 4 compatibility. - Confirmed the PR has no `pnpm-lock.yaml` or `.github/workflows/*` changes and stays below the 100-file Greptile limit. ## Verification - `pnpm install --frozen-lockfile --ignore-scripts` - `npm run install` in `node_modules/.pnpm/sqlite3@5.1.7/node_modules/sqlite3` to build the local native sqlite3 binding after installing with scripts disabled - `pnpm exec vitest run packages/shared/src/validators/issue.test.ts packages/shared/src/project-mentions.test.ts packages/adapter-utils/src/server-utils.test.ts server/src/__tests__/heartbeat-model-profile.test.ts server/src/__tests__/issue-recovery-actions.test.ts server/src/__tests__/issue-agent-mutation-ownership-routes.test.ts server/src/__tests__/heartbeat-active-run-output-watchdog.test.ts server/src/__tests__/plugin-local-folders.test.ts ui/src/components/IssueRecoveryActionCard.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/SidebarAccountMenu.test.tsx ui/src/components/IssueProperties.test.tsx ui/src/components/MarkdownEditor.test.tsx ui/src/components/MarkdownBody.test.tsx ui/src/lib/duplicate-agent-payload.test.ts ui/src/pages/Routines.test.tsx` - First pass: 13 files passed with 201 passing tests; 3 server files failed before sqlite3 native binding was built. - After rebuilding sqlite3: `server/src/__tests__/heartbeat-model-profile.test.ts`, `server/src/__tests__/issue-recovery-actions.test.ts`, and `server/src/__tests__/heartbeat-active-run-output-watchdog.test.ts` passed/loaded; embedded Postgres tests were skipped by the local host guard. - `pnpm --filter @paperclipai/shared typecheck` - `pnpm --filter @paperclipai/adapter-utils typecheck` - `pnpm --filter @paperclipai/server typecheck` - `pnpm --filter @paperclipai/ui typecheck` ## Risks - Medium risk: this is a broad rollup PR across recovery semantics, server tests, shared validators, and UI surfaces. - Some embedded Postgres tests skipped locally due the host guard, so CI should provide the stronger database-backed signal. - UI changes were covered by component tests, but no browser screenshot was captured in this PR creation pass. - This branch may overlap with existing recovery/liveness PR work; merge this PR independently or restack/close overlapping branches rather than merging duplicate implementations together. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent, tool-enabled local repository and GitHub workflow, medium reasoning effort. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
233 lines
6.2 KiB
TypeScript
233 lines
6.2 KiB
TypeScript
import type { CSSProperties } from "react";
|
|
import {
|
|
parseAgentMentionHref,
|
|
parseIssueReferenceHref,
|
|
parseProjectMentionHref,
|
|
parseRoutineMentionHref,
|
|
parseSkillMentionHref,
|
|
parseUserMentionHref,
|
|
} from "@paperclipai/shared";
|
|
import { getAgentIcon } from "./agent-icons";
|
|
import { hexToRgb, pickTextColorForPillBg } from "./color-contrast";
|
|
|
|
export type ParsedMentionChip =
|
|
| {
|
|
kind: "agent";
|
|
agentId: string;
|
|
icon: string | null;
|
|
}
|
|
| {
|
|
kind: "issue";
|
|
identifier: string;
|
|
}
|
|
| {
|
|
kind: "project";
|
|
projectId: string;
|
|
color: string | null;
|
|
}
|
|
| {
|
|
kind: "user";
|
|
userId: string;
|
|
}
|
|
| {
|
|
kind: "skill";
|
|
skillId: string;
|
|
slug: string | null;
|
|
}
|
|
| {
|
|
kind: "routine";
|
|
routineId: string;
|
|
};
|
|
|
|
const iconMaskCache = new Map<string, string>();
|
|
|
|
export function parseMentionChipHref(href: string): ParsedMentionChip | null {
|
|
if (/^https?:\/\//i.test(href.trim())) {
|
|
return null;
|
|
}
|
|
|
|
const issue = parseIssueReferenceHref(href);
|
|
if (issue) {
|
|
return {
|
|
kind: "issue",
|
|
identifier: issue.identifier,
|
|
};
|
|
}
|
|
|
|
const agent = parseAgentMentionHref(href);
|
|
if (agent) {
|
|
return {
|
|
kind: "agent",
|
|
agentId: agent.agentId,
|
|
icon: agent.icon,
|
|
};
|
|
}
|
|
|
|
const project = parseProjectMentionHref(href);
|
|
if (project) {
|
|
return {
|
|
kind: "project",
|
|
projectId: project.projectId,
|
|
color: project.color,
|
|
};
|
|
}
|
|
|
|
const user = parseUserMentionHref(href);
|
|
if (user) {
|
|
return {
|
|
kind: "user",
|
|
userId: user.userId,
|
|
};
|
|
}
|
|
|
|
const skill = parseSkillMentionHref(href);
|
|
if (skill) {
|
|
return {
|
|
kind: "skill",
|
|
skillId: skill.skillId,
|
|
slug: skill.slug,
|
|
};
|
|
}
|
|
|
|
const routine = parseRoutineMentionHref(href);
|
|
if (routine) {
|
|
return {
|
|
kind: "routine",
|
|
routineId: routine.routineId,
|
|
};
|
|
}
|
|
|
|
return null;
|
|
}
|
|
|
|
export function mentionChipInlineStyle(mention: ParsedMentionChip): CSSProperties | undefined {
|
|
const style: CSSProperties & Record<string, string> = {};
|
|
|
|
if (mention.kind === "project" && mention.color) {
|
|
const projectStyle = projectMentionColors(mention.color);
|
|
Object.assign(style, projectStyle);
|
|
style["--paperclip-mention-project-color"] = mention.color;
|
|
}
|
|
|
|
if (mention.kind === "agent") {
|
|
const iconMask = buildAgentIconMask(mention.icon);
|
|
if (iconMask) {
|
|
style["--paperclip-mention-icon-mask"] = iconMask;
|
|
}
|
|
}
|
|
|
|
return Object.keys(style).length > 0 ? (style as CSSProperties) : undefined;
|
|
}
|
|
|
|
export function applyMentionChipDecoration(element: HTMLElement, mention: ParsedMentionChip) {
|
|
clearMentionChipDecoration(element);
|
|
element.dataset.mentionKind = mention.kind;
|
|
element.setAttribute("contenteditable", "false");
|
|
element.classList.add("paperclip-mention-chip", `paperclip-mention-chip--${mention.kind}`);
|
|
if (mention.kind === "project") {
|
|
element.classList.add("paperclip-project-mention-chip");
|
|
}
|
|
|
|
const style = mentionChipInlineStyle(mention);
|
|
if (!style) return;
|
|
for (const [key, value] of Object.entries(style)) {
|
|
if (typeof value === "string") {
|
|
if (key.startsWith("--")) {
|
|
element.style.setProperty(key, value);
|
|
} else {
|
|
(element.style as CSSStyleDeclaration & Record<string, string>)[key] = value;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
export function clearMentionChipDecoration(element: HTMLElement) {
|
|
delete element.dataset.mentionKind;
|
|
element.classList.remove(
|
|
"paperclip-mention-chip",
|
|
"paperclip-mention-chip--agent",
|
|
"paperclip-mention-chip--issue",
|
|
"paperclip-mention-chip--project",
|
|
"paperclip-mention-chip--routine",
|
|
"paperclip-mention-chip--user",
|
|
"paperclip-mention-chip--skill",
|
|
"paperclip-project-mention-chip",
|
|
);
|
|
element.removeAttribute("contenteditable");
|
|
element.style.removeProperty("border-color");
|
|
element.style.removeProperty("background-color");
|
|
element.style.removeProperty("color");
|
|
element.style.removeProperty("--paperclip-mention-project-color");
|
|
element.style.removeProperty("--paperclip-mention-icon-mask");
|
|
}
|
|
|
|
function projectMentionColors(color: string): Pick<CSSProperties, "borderColor" | "backgroundColor" | "color"> {
|
|
const rgb = hexToRgb(color);
|
|
if (!rgb) return {};
|
|
return {
|
|
borderColor: color,
|
|
backgroundColor: `rgba(${rgb.r}, ${rgb.g}, ${rgb.b}, 0.22)`,
|
|
color: pickTextColorForPillBg(color),
|
|
};
|
|
}
|
|
|
|
function buildAgentIconMask(iconName: string | null): string | null {
|
|
const cacheKey = iconName ?? "__default__";
|
|
const cached = iconMaskCache.get(cacheKey);
|
|
if (cached) return cached;
|
|
|
|
const Icon = getAgentIcon(iconName);
|
|
const iconNode = resolveLucideIconNode(Icon);
|
|
if (!Array.isArray(iconNode) || iconNode.length === 0) return null;
|
|
|
|
const body = iconNode.map(([tag, attrs]) => {
|
|
const attrString = Object.entries(attrs)
|
|
.filter(([key]) => key !== "key")
|
|
.map(([key, value]) => `${key}="${escapeAttribute(String(value))}"`)
|
|
.join(" ");
|
|
return `<${tag}${attrString ? ` ${attrString}` : ""}></${tag}>`;
|
|
}).join("");
|
|
|
|
const svg =
|
|
`<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" ` +
|
|
`fill="none" stroke="#000" stroke-width="2" stroke-linecap="round" ` +
|
|
`stroke-linejoin="round">${body}</svg>`;
|
|
const url = `url("data:image/svg+xml,${encodeURIComponent(svg)}")`;
|
|
iconMaskCache.set(cacheKey, url);
|
|
return url;
|
|
}
|
|
|
|
function resolveLucideIconNode(
|
|
icon: unknown,
|
|
): Array<[string, Record<string, string>]> | null {
|
|
const staticIconNode = (
|
|
icon as {
|
|
iconNode?: Array<[string, Record<string, string>]>;
|
|
}
|
|
).iconNode;
|
|
if (Array.isArray(staticIconNode) && staticIconNode.length > 0) {
|
|
return staticIconNode;
|
|
}
|
|
|
|
const render = (
|
|
icon as {
|
|
render?: (props: Record<string, unknown>, ref: unknown) => {
|
|
props?: { iconNode?: Array<[string, Record<string, string>]> };
|
|
} | null;
|
|
}
|
|
).render;
|
|
const rendered = typeof render === "function" ? render({}, null) : null;
|
|
const renderedIconNode = rendered?.props?.iconNode;
|
|
return Array.isArray(renderedIconNode) && renderedIconNode.length > 0
|
|
? renderedIconNode
|
|
: null;
|
|
}
|
|
|
|
function escapeAttribute(value: string): string {
|
|
return value
|
|
.replaceAll("&", "&")
|
|
.replaceAll('"', """)
|
|
.replaceAll("<", "<")
|
|
.replaceAll(">", ">");
|
|
}
|