forked from farhoodlabs/paperclip
a26e1288b6
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - Human operators supervise that work through issue lists, issue detail, comments, inbox groups, markdown references, and profile/activity surfaces > - The branch had many small UI fixes that improve the operator loop but do not need to ship with backend runtime migrations > - These changes belong together as board workflow polish because they affect scanning, navigation, issue context, comment state, and markdown clarity > - This pull request groups the UI-only slice so it can merge independently from runtime/backend changes > - The benefit is a clearer board experience with better issue context, steadier optimistic updates, and more predictable keyboard navigation ## What Changed - Improves issue properties, sub-issue actions, blocker chips, and issue list/detail refresh behavior. - Adds blocker context above the issue composer and stabilizes queued/interrupted comment UI state. - Improves markdown issue/GitHub link rendering and opens external markdown links in a new tab. - Adds inbox group keyboard navigation and fold/unfold support. - Polishes activity/avatar/profile/settings/workspace presentation details. ## Verification - `pnpm exec vitest run ui/src/components/IssueProperties.test.tsx ui/src/components/IssueChatThread.test.tsx ui/src/components/MarkdownBody.test.tsx ui/src/lib/inbox.test.ts ui/src/lib/optimistic-issue-comments.test.ts` ## Risks - Low to medium risk: changes are UI-focused but cover high-traffic issue and inbox surfaces. - This branch intentionally does not include the backend runtime changes from the companion PR; where UI calls newer API filters, unsupported servers should continue to fail visibly through existing API error handling. - Visual screenshots were not captured in this heartbeat; targeted component/helper tests cover the changed behavior. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent runtime, shell/git tool use enabled. Exact hosted model build and context window are not exposed in this Paperclip heartbeat environment. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge
124 lines
3.9 KiB
TypeScript
124 lines
3.9 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import type { Issue } from "@paperclipai/shared";
|
|
import type { RunForIssue } from "../api/activity";
|
|
import type { ActiveRunForIssue, LiveRunForIssue } from "../api/heartbeats";
|
|
import { clearIssueExecutionRun, removeLiveRunById, upsertInterruptedRun } from "./optimistic-issue-runs";
|
|
|
|
function createLiveRun(overrides: Partial<LiveRunForIssue> = {}): LiveRunForIssue {
|
|
return {
|
|
id: "run-1",
|
|
status: "running",
|
|
invocationSource: "manual",
|
|
triggerDetail: null,
|
|
startedAt: "2026-04-08T21:00:00.000Z",
|
|
finishedAt: null,
|
|
createdAt: "2026-04-08T21:00:00.000Z",
|
|
agentId: "agent-1",
|
|
agentName: "CodexCoder",
|
|
adapterType: "codex_local",
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
function createActiveRun(overrides: Partial<ActiveRunForIssue> = {}): ActiveRunForIssue {
|
|
return {
|
|
id: "run-1",
|
|
agentId: "agent-1",
|
|
agentName: "CodexCoder",
|
|
adapterType: "codex_local",
|
|
invocationSource: "on_demand",
|
|
triggerDetail: null,
|
|
status: "running",
|
|
startedAt: new Date("2026-04-08T21:00:00.000Z"),
|
|
finishedAt: null,
|
|
createdAt: new Date("2026-04-08T21:00:00.000Z"),
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
describe("upsertInterruptedRun", () => {
|
|
it("adds a synthetic cancelled historical run when the live run has not reached linkedRuns yet", () => {
|
|
const runs = upsertInterruptedRun(undefined, createLiveRun(), "2026-04-08T21:00:10.000Z");
|
|
expect(runs).toEqual([{
|
|
runId: "run-1",
|
|
status: "cancelled",
|
|
agentId: "agent-1",
|
|
adapterType: "codex_local",
|
|
startedAt: "2026-04-08T21:00:00.000Z",
|
|
finishedAt: "2026-04-08T21:00:10.000Z",
|
|
createdAt: "2026-04-08T21:00:00.000Z",
|
|
invocationSource: "manual",
|
|
usageJson: null,
|
|
resultJson: null,
|
|
}]);
|
|
});
|
|
|
|
it("updates an existing linked run in place when the interrupted run is already present", () => {
|
|
const existing: RunForIssue[] = [{
|
|
runId: "run-1",
|
|
status: "running",
|
|
agentId: "agent-1",
|
|
adapterType: "codex_local",
|
|
startedAt: "2026-04-08T21:00:00.000Z",
|
|
finishedAt: null,
|
|
createdAt: "2026-04-08T21:00:00.000Z",
|
|
invocationSource: "manual",
|
|
usageJson: { inputTokens: 2 },
|
|
resultJson: { summary: "partial" },
|
|
}];
|
|
|
|
const runs = upsertInterruptedRun(existing, createActiveRun(), "2026-04-08T21:00:11.000Z");
|
|
expect(runs).toEqual([{
|
|
runId: "run-1",
|
|
status: "cancelled",
|
|
agentId: "agent-1",
|
|
adapterType: "codex_local",
|
|
startedAt: "2026-04-08T21:00:00.000Z",
|
|
finishedAt: "2026-04-08T21:00:11.000Z",
|
|
createdAt: "2026-04-08T21:00:00.000Z",
|
|
invocationSource: "on_demand",
|
|
usageJson: { inputTokens: 2 },
|
|
resultJson: { summary: "partial" },
|
|
}]);
|
|
});
|
|
});
|
|
|
|
describe("removeLiveRunById", () => {
|
|
it("removes an interrupted live run from the live list", () => {
|
|
const runs = removeLiveRunById([
|
|
createLiveRun(),
|
|
createLiveRun({ id: "run-2" }),
|
|
], "run-1");
|
|
expect(runs?.map((run) => run.id)).toEqual(["run-2"]);
|
|
});
|
|
});
|
|
|
|
describe("clearIssueExecutionRun", () => {
|
|
it("clears the cached execution run when the interrupted run matches the issue lock", () => {
|
|
const issue = {
|
|
id: "issue-1",
|
|
executionRunId: "run-1",
|
|
executionAgentNameKey: "codexcoder",
|
|
executionLockedAt: new Date("2026-04-08T21:00:00.000Z"),
|
|
updatedAt: new Date("2026-04-08T21:00:00.000Z"),
|
|
} as Issue;
|
|
|
|
expect(clearIssueExecutionRun(issue, "run-1")).toMatchObject({
|
|
id: "issue-1",
|
|
executionRunId: null,
|
|
executionAgentNameKey: null,
|
|
executionLockedAt: null,
|
|
});
|
|
});
|
|
|
|
it("leaves the cached issue alone when another run is interrupted", () => {
|
|
const issue = {
|
|
id: "issue-1",
|
|
executionRunId: "run-2",
|
|
executionAgentNameKey: "codexcoder",
|
|
} as Issue;
|
|
|
|
expect(clearIssueExecutionRun(issue, "run-1")).toBe(issue);
|
|
});
|
|
});
|