forked from farhoodlabs/paperclip
5f45712846
## Thinking Path > - Paperclip orchestrates AI agents for zero-human companies > - The board depends on issue, inbox, cost, and company-skill surfaces to stay accurate and fast while agents are actively working > - The PAP-1497 follow-up branch exposed a few rough edges in those surfaces: stale active-run state on completed issues, missing creator filters, oversized issue payload scans, and placeholder issue-route parsing > - Those gaps make the control plane harder to trust because operators can see misleading run state, miss the right subset of work, or pay extra query/render cost on large issue records > - This pull request tightens those follow-ups across server and UI code, and adds regression coverage for the affected paths > - The benefit is a more reliable issue workflow, safer high-volume cost aggregation, and clearer board/operator navigation ## What Changed - Added the `v2026.415.0` release changelog entry. - Fixed stale issue-run presentation after completion and reused the shared issue-path parser so literal route placeholders no longer become issue links. - Added creator filters to the Issues page and Inbox, including persisted filter-state normalization and regression coverage. - Bounded issue detail/list project-mention scans and trimmed large issue-list payload fields to keep issue reads lighter. - Hardened company-skill list projection and cost/finance aggregation so large markdown blobs and large summed values do not leak into list responses or overflow 32-bit casts. - Added targeted server/UI regression tests for company skills, costs/finance, issue mention scanning, creator filters, inbox normalization, and issue reference parsing. ## Verification - `pnpm exec vitest run server/src/__tests__/company-skills-service.test.ts server/src/__tests__/costs-service.test.ts server/src/__tests__/issues-goal-context-routes.test.ts server/src/__tests__/issues-service.test.ts ui/src/lib/inbox.test.ts ui/src/lib/issue-filters.test.ts ui/src/lib/issue-reference.test.ts` - `gh pr checks 3779` Current pass set on the PR head: `policy`, `verify`, `e2e`, `security/snyk (cryppadotta)`, `Greptile Review` ## Risks - Creator filter options are derived from the currently loaded issue/agent data, so very sparse result sets may not surface every historical creator until they appear in the active dataset. - Cost/finance aggregate casts now use `double precision`; that removes the current overflow risk, but future schema changes should keep large-value aggregation behavior under review. - Issue detail mention scanning now skips comment-body scans on the detail route, so any consumer that relied on comment-only project mentions there would need to fetch them separately. ## Model Used - OpenAI Codex, GPT-5-based coding agent with terminal tool use and local code execution in the Paperclip workspace. Exact internal model ID/context-window exposure is not surfaced in this session. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [ ] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
110 lines
3.6 KiB
TypeScript
110 lines
3.6 KiB
TypeScript
import { and, eq, gte, sql } from "drizzle-orm";
|
|
import type { Db } from "@paperclipai/db";
|
|
import { agents, approvals, companies, costEvents, issues } from "@paperclipai/db";
|
|
import { notFound } from "../errors.js";
|
|
import { budgetService } from "./budgets.js";
|
|
|
|
export function dashboardService(db: Db) {
|
|
const budgets = budgetService(db);
|
|
return {
|
|
summary: async (companyId: string) => {
|
|
const company = await db
|
|
.select()
|
|
.from(companies)
|
|
.where(eq(companies.id, companyId))
|
|
.then((rows) => rows[0] ?? null);
|
|
|
|
if (!company) throw notFound("Company not found");
|
|
|
|
const agentRows = await db
|
|
.select({ status: agents.status, count: sql<number>`count(*)` })
|
|
.from(agents)
|
|
.where(eq(agents.companyId, companyId))
|
|
.groupBy(agents.status);
|
|
|
|
const taskRows = await db
|
|
.select({ status: issues.status, count: sql<number>`count(*)` })
|
|
.from(issues)
|
|
.where(eq(issues.companyId, companyId))
|
|
.groupBy(issues.status);
|
|
|
|
const pendingApprovals = await db
|
|
.select({ count: sql<number>`count(*)` })
|
|
.from(approvals)
|
|
.where(and(eq(approvals.companyId, companyId), eq(approvals.status, "pending")))
|
|
.then((rows) => Number(rows[0]?.count ?? 0));
|
|
|
|
const agentCounts: Record<string, number> = {
|
|
active: 0,
|
|
running: 0,
|
|
paused: 0,
|
|
error: 0,
|
|
};
|
|
for (const row of agentRows) {
|
|
const count = Number(row.count);
|
|
// "idle" agents are operational — count them as active
|
|
const bucket = row.status === "idle" ? "active" : row.status;
|
|
agentCounts[bucket] = (agentCounts[bucket] ?? 0) + count;
|
|
}
|
|
|
|
const taskCounts: Record<string, number> = {
|
|
open: 0,
|
|
inProgress: 0,
|
|
blocked: 0,
|
|
done: 0,
|
|
};
|
|
for (const row of taskRows) {
|
|
const count = Number(row.count);
|
|
if (row.status === "in_progress") taskCounts.inProgress += count;
|
|
if (row.status === "blocked") taskCounts.blocked += count;
|
|
if (row.status === "done") taskCounts.done += count;
|
|
if (row.status !== "done" && row.status !== "cancelled") taskCounts.open += count;
|
|
}
|
|
|
|
const now = new Date();
|
|
const monthStart = new Date(now.getFullYear(), now.getMonth(), 1);
|
|
const [{ monthSpend }] = await db
|
|
.select({
|
|
monthSpend: sql<number>`coalesce(sum(${costEvents.costCents}), 0)::double precision`,
|
|
})
|
|
.from(costEvents)
|
|
.where(
|
|
and(
|
|
eq(costEvents.companyId, companyId),
|
|
gte(costEvents.occurredAt, monthStart),
|
|
),
|
|
);
|
|
|
|
const monthSpendCents = Number(monthSpend);
|
|
const utilization =
|
|
company.budgetMonthlyCents > 0
|
|
? (monthSpendCents / company.budgetMonthlyCents) * 100
|
|
: 0;
|
|
const budgetOverview = await budgets.overview(companyId);
|
|
|
|
return {
|
|
companyId,
|
|
agents: {
|
|
active: agentCounts.active,
|
|
running: agentCounts.running,
|
|
paused: agentCounts.paused,
|
|
error: agentCounts.error,
|
|
},
|
|
tasks: taskCounts,
|
|
costs: {
|
|
monthSpendCents,
|
|
monthBudgetCents: company.budgetMonthlyCents,
|
|
monthUtilizationPercent: Number(utilization.toFixed(2)),
|
|
},
|
|
pendingApprovals,
|
|
budgets: {
|
|
activeIncidents: budgetOverview.activeIncidents.length,
|
|
pendingApprovals: budgetOverview.pendingApprovalCount,
|
|
pausedAgents: budgetOverview.pausedAgentCount,
|
|
pausedProjects: budgetOverview.pausedProjectCount,
|
|
},
|
|
};
|
|
},
|
|
};
|
|
}
|