forked from farhoodlabs/paperclip
f257530537
## Thinking Path > - Paperclip operators spend most of their time scanning the board, inbox, sidebar, and local dev status surfaces > - Small UI and dev-ops frictions make repeated operator workflows feel slower than they need to be > - The working branch contained several independent quality-of-life improvements mixed with larger cloud work > - Grouping these smaller UI/dev-ops changes together keeps review overhead reasonable without merging them into feature PRs > - This pull request collects the operator-facing QoL polish into one standalone branch > - The benefit is a cleaner board navigation and local dev recovery experience without depending on cloud upstream sync ## What Changed - Relaxed forced 44px touch targets for small inline widgets. - Fixed mobile mention menu scrolling and sidebar spacing on touch/mobile layouts. - Synced inbox hover state with j/k selection. - Moved plugin sidebar entries into the Work section. - Added manual dev-server restart action/banner behavior. - Logged plugin bridge 502 causes for better diagnosis. ## Verification - `pnpm install --frozen-lockfile --ignore-scripts` - `pnpm --filter @paperclipai/plugin-sdk build` - `pnpm exec vitest run ui/src/components/MarkdownEditor.test.tsx ui/src/components/Sidebar.test.tsx ui/src/components/SidebarProjects.test.tsx ui/src/pages/Inbox.test.tsx ui/src/components/DevRestartBanner.test.tsx server/src/__tests__/dev-server-status.test.ts server/src/__tests__/health-dev-server-token.test.ts server/src/__tests__/plugin-routes-authz.test.ts` initially failed only because plugin SDK `dist` was not built in the fresh worktree. - Rerun after build: `pnpm exec vitest run server/src/__tests__/plugin-routes-authz.test.ts` passed. - The remaining targeted UI/dev-server tests passed on the first post-install run. ## Visual Evidence - Sidebar layout and plugin Work section:  - Inbox/task row selection and hover-state surface:  - Dev restart banner desktop:  - Dev restart banner mobile:  ## Risks - Mostly UI/dev ergonomics with low data risk. - Sidebar and inbox changes touch frequently used navigation surfaces, so visual review on desktop/mobile is still useful. > For core feature work, check [`ROADMAP.md`](ROADMAP.md) first and discuss it in `#dev` before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See `CONTRIBUTING.md`. ## Model Used - OpenAI Codex, GPT-5-based coding agent with local shell/git/tool use. Exact hosted model ID and context-window size are not exposed by the local Paperclip adapter runtime. ## Checklist - [x] I have included a thinking path that traces from project context to this change - [x] I have specified the model used (with version and capability details) - [x] I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work - [x] I have run tests locally and they pass - [x] I have added or updated tests where applicable - [x] If this change affects the UI, I have included before/after screenshots - [x] I have updated relevant documentation to reflect my changes - [x] I have considered and documented any risks above - [x] I will address all Greptile and reviewer comments before requesting merge --------- Co-authored-by: Paperclip <noreply@paperclip.ing>
135 lines
4.3 KiB
TypeScript
135 lines
4.3 KiB
TypeScript
import { existsSync, mkdirSync, readFileSync, statSync, writeFileSync } from "node:fs";
|
|
import path from "node:path";
|
|
|
|
const MAX_PERSISTED_DEV_SERVER_STATUS_BYTES = 64 * 1024;
|
|
|
|
export type PersistedDevServerStatus = {
|
|
dirty: boolean;
|
|
lastChangedAt: string | null;
|
|
changedPathCount: number;
|
|
changedPathsSample: string[];
|
|
pendingMigrations: string[];
|
|
lastRestartAt: string | null;
|
|
};
|
|
|
|
export type DevServerHealthStatus = {
|
|
enabled: true;
|
|
restartRequired: boolean;
|
|
reason: "backend_changes" | "pending_migrations" | "backend_changes_and_pending_migrations" | null;
|
|
lastChangedAt: string | null;
|
|
changedPathCount: number;
|
|
changedPathsSample: string[];
|
|
pendingMigrations: string[];
|
|
autoRestartEnabled: boolean;
|
|
activeRunCount: number;
|
|
waitingForIdle: boolean;
|
|
lastRestartAt: string | null;
|
|
};
|
|
|
|
export type DevServerRestartRequest = {
|
|
requestedAt: string;
|
|
reason: "manual_restart_now";
|
|
};
|
|
|
|
export function getDevServerRestartRequestFilePath(
|
|
env: NodeJS.ProcessEnv = process.env,
|
|
): string | null {
|
|
const statusFilePath = env.PAPERCLIP_DEV_SERVER_STATUS_FILE?.trim();
|
|
if (!statusFilePath) return null;
|
|
return path.join(path.dirname(statusFilePath), "dev-server-restart-request.json");
|
|
}
|
|
|
|
export function writeDevServerRestartRequest(
|
|
request: DevServerRestartRequest,
|
|
env: NodeJS.ProcessEnv = process.env,
|
|
): boolean {
|
|
const filePath = getDevServerRestartRequestFilePath(env);
|
|
if (!filePath) return false;
|
|
|
|
mkdirSync(path.dirname(filePath), { recursive: true });
|
|
writeFileSync(filePath, `${JSON.stringify(request, null, 2)}\n`, "utf8");
|
|
return true;
|
|
}
|
|
|
|
function normalizeStringArray(value: unknown): string[] {
|
|
if (!Array.isArray(value)) return [];
|
|
return value
|
|
.filter((entry): entry is string => typeof entry === "string")
|
|
.map((entry) => entry.trim())
|
|
.filter((entry) => entry.length > 0);
|
|
}
|
|
|
|
function normalizeTimestamp(value: unknown): string | null {
|
|
if (typeof value !== "string") return null;
|
|
const trimmed = value.trim();
|
|
return trimmed.length > 0 ? trimmed : null;
|
|
}
|
|
|
|
export function readPersistedDevServerStatus(
|
|
env: NodeJS.ProcessEnv = process.env,
|
|
): PersistedDevServerStatus | null {
|
|
const filePath = env.PAPERCLIP_DEV_SERVER_STATUS_FILE?.trim();
|
|
if (!filePath || !existsSync(filePath)) return null;
|
|
|
|
try {
|
|
if (statSync(filePath).size > MAX_PERSISTED_DEV_SERVER_STATUS_BYTES) {
|
|
return null;
|
|
}
|
|
const raw = JSON.parse(readFileSync(filePath, "utf8")) as Record<string, unknown>;
|
|
const changedPathsSample = normalizeStringArray(raw.changedPathsSample).slice(0, 5);
|
|
const pendingMigrations = normalizeStringArray(raw.pendingMigrations);
|
|
const changedPathCountRaw = raw.changedPathCount;
|
|
const changedPathCount =
|
|
typeof changedPathCountRaw === "number" && Number.isFinite(changedPathCountRaw)
|
|
? Math.max(0, Math.trunc(changedPathCountRaw))
|
|
: changedPathsSample.length;
|
|
const dirtyRaw = raw.dirty;
|
|
const dirty =
|
|
typeof dirtyRaw === "boolean"
|
|
? dirtyRaw
|
|
: changedPathCount > 0 || pendingMigrations.length > 0;
|
|
|
|
return {
|
|
dirty,
|
|
lastChangedAt: normalizeTimestamp(raw.lastChangedAt),
|
|
changedPathCount,
|
|
changedPathsSample,
|
|
pendingMigrations,
|
|
lastRestartAt: normalizeTimestamp(raw.lastRestartAt),
|
|
};
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
export function toDevServerHealthStatus(
|
|
persisted: PersistedDevServerStatus,
|
|
opts: { autoRestartEnabled: boolean; activeRunCount: number },
|
|
): DevServerHealthStatus {
|
|
const hasPathChanges = persisted.changedPathCount > 0;
|
|
const hasPendingMigrations = persisted.pendingMigrations.length > 0;
|
|
const reason =
|
|
hasPathChanges && hasPendingMigrations
|
|
? "backend_changes_and_pending_migrations"
|
|
: hasPendingMigrations
|
|
? "pending_migrations"
|
|
: hasPathChanges
|
|
? "backend_changes"
|
|
: null;
|
|
const restartRequired = persisted.dirty || reason !== null;
|
|
|
|
return {
|
|
enabled: true,
|
|
restartRequired,
|
|
reason,
|
|
lastChangedAt: persisted.lastChangedAt,
|
|
changedPathCount: persisted.changedPathCount,
|
|
changedPathsSample: persisted.changedPathsSample,
|
|
pendingMigrations: persisted.pendingMigrations,
|
|
autoRestartEnabled: opts.autoRestartEnabled,
|
|
activeRunCount: opts.activeRunCount,
|
|
waitingForIdle: restartRequired && opts.autoRestartEnabled && opts.activeRunCount > 0,
|
|
lastRestartAt: persisted.lastRestartAt,
|
|
};
|
|
}
|