2e0d63f7f6
fix(gro-1866): address QA review failures — portalSession null-guard,
...
CI / Test (push) Successful in 32s
CI / Lint & Typecheck (push) Successful in 34s
CI / Build & Push Docker Images (push) Successful in 2m34s
email null-dereference guard, externalize DEMO_STAFF_ID
1. portal.ts:138 — add null guard for portalSession before accessing .id
(TS18048: 'portalSession' is possibly 'undefined')
2. rbac.ts:130 — guard jwt.email before split() to prevent runtime throw
3. portal.ts:39,105 — externalize DEMO_STAFF_ID as env var
(process.env.DEMO_STAFF_ID ?? "00000000-...")
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com >
2026-05-28 19:50:14 +00:00
3b9e82adff
fix(rbac): guard noUncheckedIndexedAccess in name derivation and newStaff insert
...
CI / Lint & Typecheck (push) Successful in 12s
CI / Test (push) Successful in 14s
CI / Build & Push Docker Images (push) Successful in 46s
With noUncheckedIndexedAccess:true, split("@")[0] returns string|undefined,
making `name` typed as string|undefined and failing the notNull staff.name
insert constraint. Fix by using ?? fallback on the array access.
Also add newStaff null guard after .returning() destructure — array
destructuring yields T|undefined with noUncheckedIndexedAccess enabled.
2026-05-26 01:48:41 +00:00
Scrubs McBarkley
b61d899f81
fix(GRO-1757): auto-provision staff for OIDC users + UAT playbook updates ( #83 )
2026-05-25 23:39:57 +00:00
Chris Farhood
abac9dfe6c
Extract groombook/api from monorepo with CI workflow
...
- Add source code from apps/api
- Add packages/db and packages/types workspace dependencies
- Add GitHub Actions CI workflow (lint, typecheck, test, docker)
- Generate pnpm-lock.yaml
- Add .gitignore
Co-Authored-By: Paperclip <noreply@paperclip.ing >
2026-05-11 01:26:56 +00:00
Flea Flicker
Scrubs McBarkley
Chris Farhood