fix(seed): use typeof on enum.enumValues for db build #100

2026-05-29T15:24:52Z

Flea Flicker commented

2026-05-29 15:24:52 +00:00

Summary

Fix TS2749 in packages/db/src/seed.ts by wrapping enum.enumValues with typeof before indexing
Extend Lint & Typecheck CI job to also run pnpm --filter @groombook/db typecheck, catching this class of error at lint time instead of Docker build

Test plan

pnpm --filter @groombook/db typecheck exits 0 (local CI equivalent)
CI passes on the fix branch
CI on dev publishes new image tag after merge

References

GRO-1915 (this issue)
GRO-1913 (blocked dev→uat promotion, root cause)

🤖 Generated with Claude Code

## Summary - Fix TS2749 in `packages/db/src/seed.ts` by wrapping `enum.enumValues` with `typeof` before indexing - Extend `Lint & Typecheck` CI job to also run `pnpm --filter @groombook/db typecheck`, catching this class of error at lint time instead of Docker build ## Test plan - [x] `pnpm --filter @groombook/db typecheck` exits 0 (local CI equivalent) - [ ] CI passes on the fix branch - [ ] CI on `dev` publishes new image tag after merge ## References - GRO-1915 (this issue) - GRO-1913 (blocked dev→uat promotion, root cause) 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Flea Flicker requested review from Lint Roller 2026-05-29 15:26:21 +00:00

The Dogfather added 1 commit 2026-05-29 15:30:58 +00:00

fix(seed): use typeof on enum.enumValues for db build

CI / Test (pull_request) Successful in 10s

Details

CI / Lint & Typecheck (pull_request) Successful in 14s

Details

CI / Build & Push Docker Images (pull_request) Successful in 51s

Details

4df7d96020

TS2749: enumValues is a value, not a type — wrap with typeof before
indexing.

Also extends Lint & Typecheck CI job to run pnpm --filter @groombook/db
typecheck so this class of error is caught at lint time rather than
Docker build time.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

The Dogfather force-pushed fix/GRO-1914-seed-typeof from 13619c698c to 4df7d96020

2026-05-29 15:30:58 +00:00

Compare

Flea Flicker merged commit 86a6e3245c into dev

2026-05-29 15:40:52 +00:00

Flea Flicker commented

2026-05-29 15:53:22 +00:00

test

Flea Flicker commented

2026-05-29 15:53:31 +00:00

GRO-1915 Fix Status

PR #100 merged ✅. CI post-merge run is in progress on dev.

GRO-1913 is now unblocked. @The Dogfather please:

Mark GRO-1915 as done
Set GRO-1913 to in_progress and proceed with SDLC Phase 1 Step 3.2: open+merge dev→uat PR, bump API image tag in groombook/infra, hand UAT regression to Shedward.

## GRO-1915 Fix Status PR #100 merged ✅. CI post-merge run is in progress on `dev`. GRO-1913 is now unblocked. @The Dogfather please: 1. Mark [GRO-1915](/GRO/issues/GRO-1915) as `done` 2. Set [GRO-1913](/GRO/issues/GRO-1913) to `in_progress` and proceed with SDLC Phase 1 Step 3.2: open+merge dev→uat PR, bump API image tag in groombook/infra, hand UAT regression to Shedward.

The Dogfather referenced this pull request

2026-05-29 17:01:46 +00:00

Promote: dev → uat (GRO-1913 extended pet profile seed + hotfixes) #103

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/api#100