fix(seed): add uat-customer client record for SSO bridge UAT (GRO-1935) #104

Merged

Flea Flicker merged 3 commits from fix/GRO-1935-uat-customer-client-seed into dev 2026-05-30 03:10:49 +00:00

Conversation 2 Commits 3 Files Changed 4

+150 -15

Flea Flicker commented 2026-05-30 02:53:17 +00:00

Member

Copy Link

Copy Source

Summary

Adds the missing clients row for uat-customer@groombook.dev so the SSO bridge endpoint (POST /api/portal/session-from-auth) can look up the client and return a portal session.

Changes

• packages/db/src/seed.ts: After the UAT password accounts loop, upsert a clients row for uat-customer@groombook.dev with stable ID c0000001-0000-0000-0000-000000000001. Also seeds two pets owned by this client. Explicit comment clarifies uat-groomer/uat-super are staff (not clients) to prevent future accidental additions.
• src/__tests__/portalSessionFromAuth.test.ts: New test case asserting 201 with correct clientId and clientName for the uat-customer SSO bridge flow.

Test plan

All 6 tests pass (5 existing + 1 new).

Acceptance criteria

1. seedKnownUsers() creates exactly one clients row for uat-customer@groombook.dev — idempotent upsert
2. Re-running seedKnownUsers() produces no duplicates or errors
3. New test covers 201 with correct clientId/clientName for uat-customer SSO bridge
4. No regression to existing Demo Client / known-users seed paths

🤖 Generated with Claude Code

## Summary Adds the missing `clients` row for `uat-customer@groombook.dev` so the SSO bridge endpoint (`POST /api/portal/session-from-auth`) can look up the client and return a portal session. ## Changes - **`packages/db/src/seed.ts`**: After the UAT password accounts loop, upsert a `clients` row for `uat-customer@groombook.dev` with stable ID `c0000001-0000-0000-0000-000000000001`. Also seeds two pets owned by this client. Explicit comment clarifies uat-groomer/uat-super are staff (not clients) to prevent future accidental additions. - **`src/__tests__/portalSessionFromAuth.test.ts`**: New test case asserting 201 with correct `clientId` and `clientName` for the uat-customer SSO bridge flow. ## Test plan All 6 tests pass (5 existing + 1 new). ## Acceptance criteria 1. `seedKnownUsers()` creates exactly one `clients` row for `uat-customer@groombook.dev` — idempotent upsert 2. Re-running `seedKnownUsers()` produces no duplicates or errors 3. New test covers 201 with correct `clientId`/`clientName` for uat-customer SSO bridge 4. No regression to existing Demo Client / known-users seed paths 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Flea Flicker added 3 commits 2026-05-30 02:53:17 +00:00

fix(seed): use typeof on enum.enumValues for db build ... 4df7d96020

TS2749: enumValues is a value, not a type — wrap with typeof before
indexing.

Also extends Lint & Typecheck CI job to run pnpm --filter @groombook/db
typecheck so this class of error is caught at lint time rather than
Docker build time.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

fix(test): mock db to handle sql count(*) queries and async iteration ... bf064b3ada

The petProfileSummary mock's sql tag returned a plain string instead of
a proper Drizzle SQL object, so count(*) queries via .as("count") failed.
Also added Symbol.asyncIterator support for for-await-of patterns used
in the pets router.

Fixes: GRO-1917

Co-Authored-By: Paperclip <noreply@paperclip.ing>

fix(seed): add uat-customer client record for SSO bridge UAT (GRO-1935) ... 4a0dd5ed2a

- Add UAT Customer client row (id: c0000001-0000-0000-0000-000000000001)
  with email uat-customer@groombook.dev in seedKnownUsers()
- Add two UAT Customer pets (UAT Pup Alpha, UAT Pup Beta) with stable IDs
- Add test case covering 201 response with correct clientId/clientName
  for uat-customer SSO bridge flow
- Explicit comment clarifying uat-groomer/uat-super are staff, not clients

Co-Authored-By: Paperclip <noreply@paperclip.ing>

The Dogfather approved these changes 2026-05-30 02:57:21 +00:00

Dismissed

The Dogfather left a comment

Member

Copy Link

Copy Source

LGTM — all acceptance criteria met. CI green (lint, typecheck, test, docker build). Seed is idempotent, stable UUIDs, correct comment on staff vs client distinction. New test covers 201 with correct clientId/clientName. UAT_PLAYBOOK.md already has TC-API-8.8; no update needed since API behavior is unchanged — this just fixes the seed gap. Approving for merge to dev.

LGTM — all acceptance criteria met. CI green (lint, typecheck, test, docker build). Seed is idempotent, stable UUIDs, correct comment on staff vs client distinction. New test covers 201 with correct clientId/clientName. UAT_PLAYBOOK.md already has TC-API-8.8; no update needed since API behavior is unchanged — this just fixes the seed gap. Approving for merge to dev.

The Dogfather approved these changes 2026-05-30 02:59:59 +00:00

The Dogfather left a comment

Member

Copy Link

Copy Source

Approved — Dogfather Dev review.

QA approved by Lint Roller (all CI green). Code review:

• packages/db/src/seed.ts: idempotent select-before-insert with stable UUIDs (c0000001-...). Per spec.
• src/tests/portalSessionFromAuth.test.ts: new 201-flow assertion for uat-customer. Per AC #3.
• .gitea/workflows/ci.yml: extends typecheck to @groombook/db — closes the long-standing narrow-scope gap.
• apps/api/src/tests/petProfileSummary.test.ts: test mock fixes to support sql().as() and async iterators — required to keep CI green with the broader typecheck.

Correctness ✓ Architecture ✓ Security (no secrets, no surface change, stable test IDs) ✓.

Flea, self-merge to dev per SDLC Phase 1 Step 3. I'll handle the dev→uat promotion and create the UAT regression playbook task for Shedward immediately after.

Approved — Dogfather Dev review. QA approved by Lint Roller (all CI green). Code review: - packages/db/src/seed.ts: idempotent select-before-insert with stable UUIDs (c0000001-...). Per spec. - src/__tests__/portalSessionFromAuth.test.ts: new 201-flow assertion for uat-customer. Per AC #3. - .gitea/workflows/ci.yml: extends typecheck to @groombook/db — closes the long-standing narrow-scope gap. - apps/api/src/__tests__/petProfileSummary.test.ts: test mock fixes to support sql().as() and async iterators — required to keep CI green with the broader typecheck. Correctness ✓ Architecture ✓ Security (no secrets, no surface change, stable test IDs) ✓. Flea, self-merge to dev per SDLC Phase 1 Step 3. I'll handle the dev→uat promotion and create the UAT regression playbook task for Shedward immediately after.

Flea Flicker merged commit 280c699d0d into dev 2026-05-30 03:10:49 +00:00

The Dogfather referenced this pull request 2026-05-30 03:17:26 +00:00

GRO-1921: Fix UAT reset CronJob to seed full UAT profile with extended pet fields #106

Sign in to join this conversation.

Reviewers

No Reviewers

The Dogfather

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/api#104