groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(seed): restore deterministic alerts for TestCooper/TestRocky (GRO-1962) #122

Merged
Flea Flicker merged 1 commits from fleaflicker/GRO-1962-deterministic-testcoopper-rocky into dev 2026-06-01 00:35:36 +00:00
Conversation 0 Commits 1 Files Changed 1
+20 -14
The Dogfather commented 2026-06-01 00:35:00 +00:00
Member
Copy Link
Copy Source

Summary

Restore deterministic alerts so TC-API-3.23/3.24 are no longer flaky:

  • TestCooper always gets a behavioral medical alert
  • TestRocky always gets a skin medical alert
  • All other pets follow the ~30% random distribution

Their deterministic alerts on 2 of 507 pets (~0.4%) do not meaningfully shift the overall 25-35% medicalAlerts distribution.

Files

  • — medicalAlerts logic (both insert and onConflictDoUpdate IIFEs)

Testing

  • CI validates lint, typecheck, tests
  • Manual: re-run seed, verify TestCooper has behavioral alert and TestRocky has skin alert on every run

cc @cpfarhood

## Summary Restore deterministic alerts so TC-API-3.23/3.24 are no longer flaky: - **TestCooper** always gets a behavioral medical alert - **TestRocky** always gets a skin medical alert - All other pets follow the ~30% random distribution Their deterministic alerts on 2 of 507 pets (~0.4%) do not meaningfully shift the overall 25-35% medicalAlerts distribution. ## Files - — medicalAlerts logic (both insert and onConflictDoUpdate IIFEs) ## Testing - CI validates lint, typecheck, tests - Manual: re-run seed, verify TestCooper has behavioral alert and TestRocky has skin alert on every run cc @cpfarhood
The Dogfather added 1 commit 2026-06-01 00:35:01 +00:00
fix(seed): restore deterministic alerts for TestCooper/TestRocky (GRO-1962)
CI / Test (pull_request) Successful in 12s
Details
CI / Lint & Typecheck (pull_request) Successful in 17s
Details
CI / Build & Push Docker Images (pull_request) Successful in 1m7s
Details
97da5f332e 
Restore deterministic alerts so TC-API-3.23/3.24 no longer flaky:
- TestCooper always gets a behavioral alert
- TestRocky always gets a skin alert
- Their deterministic alerts (~0.4% of total pets) do not shift
  the overall 25-35% medicalAlerts distribution

Co-Authored-By: Paperclip <noreply@paperclip.ing>
Flea Flicker merged commit b15a53a19b into dev 2026-06-01 00:35:36 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#122
Delete Branch "fleaflicker/GRO-1962-deterministic-testcoopper-rocky"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?