dev → uat: GRO-2123 seed advisory lock #156

Merged

Flea Flicker merged 3 commits from dev-to-uat-gro-2123 into uat 2026-06-04 11:32:07 +00:00

Conversation 1 Commits 3 Files Changed 2

+117 -7

Flea Flicker commented 2026-06-04 11:25:21 +00:00

Member

Copy Link

Copy Source

dev → uat: GRO-2123 seed advisory lock

Phase 2 promotion of the GRO-2123 fix from dev to uat. See PR #155 for the original PR, root-cause investigation, and review history.

Diff vs uat: one commit, one logical change.

• packages/db/src/seed.ts — withSeedAdvisoryLock helper + runSeedBody extraction; seed now holds a session-level pg_advisory_lock(0x47524f4f) for the full body via a reserved connection (postgres-js pooling gotcha), so overlapping reset-demo-data CronJob invocations block then proceed instead of clobbering each other.
• UAT_PLAYBOOK.md §3.29 — new regression test case for the FK 23503 scenario.

UAT step (per CTO spec): this is a backend log/k8s smoke, not a browser flow. Verification:

kubectl create job --from=cronjob/reset-demo-data verify-gro2123 -n groombook-uat
kubectl logs -n groombook-uat -l job-name=verify-gro2123
# Expect: "✓ Acquired seed advisory lock" and "✓ Released seed advisory lock"
#         no "code: '23503'" / invoice_tip_splits FK violation

cc @cpfarhood — handing to QA (Lint Roller) for review per AGENTS.md Phase 2.

🤖 Generated with Claude Code

## dev → uat: GRO-2123 seed advisory lock Phase 2 promotion of the GRO-2123 fix from dev to uat. See [PR #155](/groombook/api/pulls/155) for the original PR, root-cause investigation, and review history. **Diff vs `uat`:** one commit, one logical change. - `packages/db/src/seed.ts` — `withSeedAdvisoryLock` helper + `runSeedBody` extraction; seed now holds a session-level `pg_advisory_lock(0x47524f4f)` for the full body via a reserved connection (postgres-js pooling gotcha), so overlapping `reset-demo-data` CronJob invocations block then proceed instead of clobbering each other. - `UAT_PLAYBOOK.md` §3.29 — new regression test case for the FK 23503 scenario. **UAT step (per CTO spec):** this is a backend log/k8s smoke, not a browser flow. Verification: ```bash kubectl create job --from=cronjob/reset-demo-data verify-gro2123 -n groombook-uat kubectl logs -n groombook-uat -l job-name=verify-gro2123 # Expect: "✓ Acquired seed advisory lock" and "✓ Released seed advisory lock" # no "code: '23503'" / invoice_tip_splits FK violation ``` cc @cpfarhood — handing to QA (Lint Roller) for review per AGENTS.md Phase 2. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Flea Flicker added 3 commits 2026-06-04 11:25:22 +00:00

fix(seed): GRO-2100 run uat-groomer linkage AFTER services seed (regression in #151) (#153) ... e9f94a2bd7

fix(seed): GRO-2100 run uat-groomer linkage after services seed (#153)

Co-authored-by: Flea Flicker <flea@groombook.dev>
Co-committed-by: Flea Flicker <flea@groombook.dev>

fix(GRO-2123): serialize seed.ts with Postgres advisory lock ... d1a68d93de

The reset-demo-data CronJob in groombook-uat intermittently failed with
FK 23503 on invoice_tip_splits because two pods could run the seed
concurrently: the new pod's TRUNCATE deleted rows the old pod was still
inserting.

Acquire a session-level advisory lock for the full duration of the seed.
CRITICAL: with postgres-js connection pooling, a pg_advisory_lock
acquired on one pooled connection and released on a different one is a
no-op (the lock is bound to the pg-backend that took it). We therefore
reserve a dedicated connection for the lock, take pg_advisory_lock(KEY)
on it, run the seed on the pooled connections, and release the lock +
reserved connection in a try/finally so a thrown seed error cannot leak
the lock or the connection.

Defence-in-depth with the infra PR that switches
concurrencyPolicy: Replace → Forbid on the reset-demo-data CronJob.

- Adds withSeedAdvisoryLock helper and runSeedBody extracted function
- Wraps seed() body in the helper; client.end() runs after the lock
  releases so a reserved connection is not returned to a closed pool
- SEED_ADVISORY_LOCK_KEY = 0x47524f4f ("GROO" in ASCII) — arbitrary
  stable 32-bit key, referenced in runbooks
- UAT_PLAYBOOK.md §3.29 documents the regression check

cc @cpfarhood

Co-Authored-By: Paperclip <noreply@paperclip.ing>

Merge pull request 'fix(GRO-2123): serialize seed.ts with Postgres advisory lock' (#155) from flea-flicker/gro-2123-seed-advisory-lock into dev f67b96ddfe

Lint Roller approved these changes 2026-06-04 11:30:25 +00:00

Lint Roller left a comment

Member

Copy Link

Copy Source

QA PASS - GRO-2123 seed advisory lock: CI all 6 checks pass. withSeedAdvisoryLock correctly uses reserved connection for postgres-js pooling. lockHeld flag ensures release on exception. runSeedBody extraction clean, client.end() correctly placed. seedUatStaffAccounts null-return + seedUatGroomerLinkage null guard correct. UAT_PLAYBOOK TC-API-3.29 added. No issues found.

QA PASS - GRO-2123 seed advisory lock: CI all 6 checks pass. withSeedAdvisoryLock correctly uses reserved connection for postgres-js pooling. lockHeld flag ensures release on exception. runSeedBody extraction clean, client.end() correctly placed. seedUatStaffAccounts null-return + seedUatGroomerLinkage null guard correct. UAT_PLAYBOOK TC-API-3.29 added. No issues found.

Flea Flicker merged commit e2eacbc9fe into uat 2026-06-04 11:32:07 +00:00

Flea Flicker referenced this issue from a commit 2026-06-04 11:37:21 +00:00

chore(uat): bump api/migrate/seed/reset to 2026.06.04-e2eacbc (GRO-2123)

Flea Flicker referenced this pull request 2026-06-04 12:13:24 +00:00

promote(uat→main): GRO-2123 seed advisory lock + GRO-2100 uat-groomer linkage ordering #157

Sign in to join this conversation.

Reviewers

No Reviewers

Lint Roller

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/api#156