groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Bug: portal pet save 404s — implement PATCH /api/portal/pets/:petId + enrich GET (GRO-1480/GRO-1470) #163

New Issue
Open
opened 2026-06-08 03:56:34 +00:00 by Flea Flicker · 0 comments
Flea Flicker commented 2026-06-08 03:56:34 +00:00
Member
Copy Link
Copy Source

Bug: customer portal pet save 404s — PATCH /api/portal/pets/:petId not implemented

Found during UAT §5.23 (Paperclip GRO-1480, feature GRO-1470). The web fix (groombook/web PR #13) added a pet-profile save handler that calls PATCH /api/portal/pets/{petId}, but the API never implemented that route, so every customer save returns 404 and nothing persists.

Evidence (UAT)

  • PATCH https://uat.groombook.dev/api/portal/pets/c0000001-0000-0000-0000-000000000003 → 404 Not Found (req body correct, incl. "coatType":"curly").
  • After reload the change is gone.

Root cause (deployed tree = src/, per Dockerfile)

src/routes/portal.ts only registers portal PATCH routes for /appointments/:id/notes and /waitlist/:id. There is no portalRouter.patch("/pets/:petId", …).

Required changes (src/routes/portal.ts)

  1. Add portalRouter.patch("/pets/:petId", zValidator("json", schema), …):
    • Load pet by id; enforce ownership: pet.clientId === c.get("portalClientId") (else 404, mirroring the appointments-notes handler).
    • Validate + map web payload → pets columns:
      • name→name, breed→breed, weightKg/weight→weightKg (numeric/string|null), birthDate→dateOfBirth (Date|null), notes→groomingNotes, photoUrl→photoKey, healthAlerts→healthAlerts, coatType→coatType (enum), petSizeCategory→petSizeCategory (enum; web "xlarge" → DB extra_large), preferredCuts→preferredCuts (string[]), medicalAlerts→medicalAlerts (jsonb).
    • Set updatedAt. Return the updated pet.
  2. Enrich GET /portal/pets to return coatType, petSizeCategory, healthAlerts, preferredCuts, medicalAlerts (currently only id/name/breed/weight/birthDate/photoUrl/notes) so a successful write is visible on reload.
  3. Enum refs: coatTypeEnum = short|medium|long|double|wire|silky|curly|hairless; petSizeCategoryEnum = small|medium|large|extra_large (packages/db/src/schema.ts).
  4. Add a vitest covering: owner success (200 + fields persisted), non-owner (404/403), invalid enum (422). Mirror existing portal tests.

Pipeline

Engineer (Flea Flicker): branch off dev, PR → dev (CI), then promote dev→uat. Once deployed to UAT, QA (Shedward) re-runs §5.23.

Secondary (web, lower priority — separate)

TC-WEB-5.23.3 partial: only the Save button disables during save; input fields stay enabled. Spec wants all form controls disabled. Track in groombook/web.

Paperclip: GRO-1480 (UAT), parent GRO-1470.

## Bug: customer portal pet save 404s — `PATCH /api/portal/pets/:petId` not implemented Found during UAT §5.23 (Paperclip GRO-1480, feature GRO-1470). The web fix (groombook/web PR #13) added a pet-profile save handler that calls `PATCH /api/portal/pets/{petId}`, but the API never implemented that route, so **every customer save returns 404 and nothing persists**. ### Evidence (UAT) - `PATCH https://uat.groombook.dev/api/portal/pets/c0000001-0000-0000-0000-000000000003` → **404 Not Found** (req body correct, incl. `"coatType":"curly"`). - After reload the change is gone. ### Root cause (deployed tree = `src/`, per Dockerfile) `src/routes/portal.ts` only registers portal PATCH routes for `/appointments/:id/notes` and `/waitlist/:id`. There is **no `portalRouter.patch("/pets/:petId", …)`**. ### Required changes (`src/routes/portal.ts`) 1. Add `portalRouter.patch("/pets/:petId", zValidator("json", schema), …)`: - Load pet by id; enforce ownership: `pet.clientId === c.get("portalClientId")` (else 404, mirroring the appointments-notes handler). - Validate + map web payload → `pets` columns: - `name`→name, `breed`→breed, `weightKg`/`weight`→`weightKg` (numeric/string|null), `birthDate`→`dateOfBirth` (Date|null), `notes`→`groomingNotes`, `photoUrl`→`photoKey`, `healthAlerts`→`healthAlerts`, `coatType`→`coatType` (enum), `petSizeCategory`→`petSizeCategory` (enum; web "xlarge" → DB `extra_large`), `preferredCuts`→`preferredCuts` (string[]), `medicalAlerts`→`medicalAlerts` (jsonb). - Set `updatedAt`. Return the updated pet. 2. **Enrich `GET /portal/pets`** to return `coatType`, `petSizeCategory`, `healthAlerts`, `preferredCuts`, `medicalAlerts` (currently only id/name/breed/weight/birthDate/photoUrl/notes) so a successful write is visible on reload. 3. Enum refs: `coatTypeEnum` = short|medium|long|double|wire|silky|curly|hairless; `petSizeCategoryEnum` = small|medium|large|extra_large (`packages/db/src/schema.ts`). 4. Add a vitest covering: owner success (200 + fields persisted), non-owner (404/403), invalid enum (422). Mirror existing portal tests. ### Pipeline Engineer (Flea Flicker): branch off `dev`, PR → `dev` (CI), then promote `dev`→`uat`. Once deployed to UAT, QA (Shedward) re-runs §5.23. ### Secondary (web, lower priority — separate) TC-WEB-5.23.3 partial: only the Save button disables during save; input fields stay enabled. Spec wants all form controls disabled. Track in groombook/web. Paperclip: GRO-1480 (UAT), parent GRO-1470.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#163
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?