fix(ci): GRO-2197 api lint/typecheck/test run root scripts (de-false-green) #169

2026-06-08T11:02:43Z

Flea Flicker commented

2026-06-08 11:02:43 +00:00

GRO-2197 — CI fix: api lint/typecheck/test run root scripts (de-false-green)

Parent: GRO-2196. Fixes the false-green api CI gate and the latent lint error it now surfaces.

Root cause

.gitea/workflows/ci.yml ran pnpm --filter @groombook/api <script>. But @groombook/api is the workspace root package, and pnpm-workspace.yaml only includes packages/*. pnpm's --filter excludes the root by default, so --filter @groombook/api matched no project — lint/typecheck/test silently no-op'd and reported success.

Changes

.gitea/workflows/ci.yml — invoke the root scripts directly:
- Typecheck: pnpm run typecheck (kept the real --filter @groombook/db typecheck)
- Lint: pnpm run lint
- Test: pnpm run test
- docker job untouched.
src/__tests__/petProfileSummary.test.ts — fix the now-surfaced unused-var error. servicesTable was declared and written in resetMock but never enqueued/read; removed the declaration, the dead write, and the orphaned makeService helper (its only caller).

Local verification (all green)

$ pnpm run typecheck            → tsc --noEmit, exit 0
$ pnpm --filter @groombook/db typecheck → exit 0
$ pnpm run lint                 → eslint src, 0 errors, 7 pre-existing warnings, exit 0
$ pnpm run test                 → Test Files 41 passed (41), Tests 602 passed (602), exit 0

The servicesTable unused-var error is resolved; full local suite passes.

feature→dev is CI-only + engineer self-merge. The CI gate is now meaningful (real eslint/tsc/vitest output expected in the job logs).

cc @cpfarhood

## GRO-2197 — CI fix: api lint/typecheck/test run root scripts (de-false-green) Parent: GRO-2196. Fixes the false-green api CI gate and the latent lint error it now surfaces. ### Root cause `.gitea/workflows/ci.yml` ran `pnpm --filter @groombook/api <script>`. But `@groombook/api` is the **workspace root** package, and `pnpm-workspace.yaml` only includes `packages/*`. pnpm's `--filter` excludes the root by default, so `--filter @groombook/api` matched **no project** — lint/typecheck/test silently no-op'd and reported success. ### Changes - **`.gitea/workflows/ci.yml`** — invoke the root scripts directly: - Typecheck: `pnpm run typecheck` (kept the real `--filter @groombook/db typecheck`) - Lint: `pnpm run lint` - Test: `pnpm run test` - `docker` job untouched. - **`src/__tests__/petProfileSummary.test.ts`** — fix the now-surfaced unused-var error. `servicesTable` was declared and written in `resetMock` but never enqueued/read; removed the declaration, the dead write, and the orphaned `makeService` helper (its only caller). ### Local verification (all green) ``` $ pnpm run typecheck → tsc --noEmit, exit 0 $ pnpm --filter @groombook/db typecheck → exit 0 $ pnpm run lint → eslint src, 0 errors, 7 pre-existing warnings, exit 0 $ pnpm run test → Test Files 41 passed (41), Tests 602 passed (602), exit 0 ``` The `servicesTable` unused-var error is resolved; full local suite passes. feature→dev is CI-only + engineer self-merge. The CI gate is now meaningful (real eslint/tsc/vitest output expected in the job logs). cc @cpfarhood

Flea Flicker added 1 commit 2026-06-08 11:02:43 +00:00

fix(ci): run api root lint/typecheck/test scripts; remove dead servicesTable (GRO-2197)

CI / Test (pull_request) Successful in 1m20s

Details

CI / Lint & Typecheck (pull_request) Successful in 1m23s

Details

CI / Build & Push Docker Images (pull_request) Successful in 3m43s

Details

e8ef481a11

The api gate ran `pnpm --filter @groombook/api <script>`, but @groombook/api
is the workspace ROOT package and pnpm-workspace.yaml only includes packages/*,
so --filter excluded the root and the lint/typecheck/test steps silently
no-op'd (false-green). Invoke the root scripts directly instead.

Now that the gate actually runs eslint, fix the latent unused-var error in
src/__tests__/petProfileSummary.test.ts: servicesTable was declared and
assigned in resetMock but never enqueued/read. Remove the declaration, the
dead write, and the now-orphaned makeService helper (its only caller).

Verified locally: pnpm run typecheck, pnpm --filter @groombook/db typecheck,
pnpm run lint (0 errors), pnpm run test (602 passed) all green.

Co-Authored-By: Paperclip <noreply@paperclip.ing>

Flea Flicker merged commit eec198a661 into dev

2026-06-08 11:09:34 +00:00

Flea Flicker referenced this pull request

2026-06-08 13:14:36 +00:00

uat → main: portal pet PATCH + photoKey S3 key-hijack fix (GRO-2187) #174

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/api#169