dev → uat: GRO-2154 geocoding endpoints (Phase 1.3) #171

Merged

Flea Flicker merged 2 commits from dev-to-uat-gro-2154 into uat 2026-06-08 12:06:44 +00:00

Conversation 1 Commits 2 Files Changed 7

+555 -22

Flea Flicker commented 2026-06-08 11:45:51 +00:00

Member

Copy Link

Copy Source

dev → uat: GRO-2154 geocoding endpoints (Phase 1.3)

Promotes the GRO-2154 geocoding endpoints + auto-geocode work (merged to dev in #170) to uat.

What's included

• POST /api/clients/:clientId/geocode — single client geocode (manager-only)
• POST /api/clients/geocode-batch?limit= — throttled batch geocode of un-geocoded clients (manager-only), reports remaining
• Auto-geocode on client create/update; clearing the address drops stale coordinates
• Persists latitude/longitude/geocodedAt; structured outcomes (geocoded | no_address | unresolved | error)
• UAT_PLAYBOOK.md §4.2 — new TC-API-2.7 … TC-API-2.17

Verification (on dev PR #170)

• typecheck ✓ · lint ✓ (0 errors) · test ✓ (610 passed, 8 new) · CI green

QA focus

• RBAC: geocode endpoints reject groomer/receptionist (403), allow manager
• Single geocode outcomes: success persists coords; no_address/unresolved → 422; missing client → 404
• Batch: respects ?limit, returns remaining; invalid limit → 400
• Auto-geocode on create/update; address-clear resets coordinates

Refs GRO-2154.

🤖 Generated with Claude Code

## dev → uat: GRO-2154 geocoding endpoints (Phase 1.3) Promotes the GRO-2154 geocoding endpoints + auto-geocode work (merged to `dev` in #170) to `uat`. ### What's included - `POST /api/clients/:clientId/geocode` — single client geocode (manager-only) - `POST /api/clients/geocode-batch?limit=` — throttled batch geocode of un-geocoded clients (manager-only), reports `remaining` - Auto-geocode on client create/update; clearing the address drops stale coordinates - Persists `latitude`/`longitude`/`geocodedAt`; structured outcomes (`geocoded | no_address | unresolved | error`) - `UAT_PLAYBOOK.md` §4.2 — new **TC-API-2.7 … TC-API-2.17** ### Verification (on dev PR #170) - typecheck ✓ · lint ✓ (0 errors) · test ✓ (610 passed, 8 new) · CI green ### QA focus - RBAC: geocode endpoints reject groomer/receptionist (403), allow manager - Single geocode outcomes: success persists coords; no_address/unresolved → 422; missing client → 404 - Batch: respects `?limit`, returns `remaining`; invalid limit → 400 - Auto-geocode on create/update; address-clear resets coordinates Refs GRO-2154. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Flea Flicker added 2 commits 2026-06-08 11:45:52 +00:00

fix(ci): GRO-2197 api lint/typecheck/test run root scripts (de-false-green) (#169) eec198a661

feat(GRO-2154): geocoding endpoints + auto-geocode on client mutations (#170) 582c376df9

Lint Roller approved these changes 2026-06-08 11:53:42 +00:00

Lint Roller left a comment

Member

Copy Link

Copy Source

QA review passed — geocoding endpoints look correct. RBAC guard wired correctly (manager-only before broader POST /clients/* guard), all HTTP status mappings correct, limit validation, auto-geocode hasOwnProperty check, best-effort hook, UAT_PLAYBOOK §4.2 updated TC-API-2.7..2.17. CI green (lint, typecheck, 610 tests). Approved — clear to self-merge dev→uat.

QA review passed — geocoding endpoints look correct. RBAC guard wired correctly (manager-only before broader POST /clients/* guard), all HTTP status mappings correct, limit validation, auto-geocode hasOwnProperty check, best-effort hook, UAT_PLAYBOOK §4.2 updated TC-API-2.7..2.17. CI green (lint, typecheck, 610 tests). Approved — clear to self-merge dev→uat.

Flea Flicker merged commit 8721f0b63c into uat 2026-06-08 12:06:44 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Lint Roller

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/api#171