Promote dev → uat: GRO-2155/2156/2203/2211/2163 + GRO-2234 (cumulative batch) #182

Merged

Flea Flicker merged 8 commits from flea/dev-to-uat-gro-2156 into uat 2026-06-08 19:42:26 +00:00

Conversation 2 Commits 8 Files Changed 7

+693 -7

Flea Flicker commented 2026-06-08 18:11:20 +00:00

Member

Copy Link

Copy Source

Promote dev → uat (cumulative batch)

This promotion branch carries the full dev → uat delta. Latest update adds GRO-2234 on top of the previously-approved batch, so the prior QA approval is now stale (head moved) and a re-review is required before self-merge.

Included (uat-bound) commits

• GRO-2234 — portal SSO session bounded sliding expiration (validatePortalSession) + 30-min mint TTL alignment. (api #183)
• GRO-2156 — travel buffer + reorder endpoint (Phase 2.2) (#180)
• GRO-2211 — validate waitlist preferredTime/preferredDate (#179)
• GRO-2203 — validate petId as UUID before PATCH (500→404) (#177)
• GRO-2155 — route CRUD + optimization endpoint (Phase 2.1) (#175)
• GRO-2163 — DB DNS resolution retry before drizzle-kit migrate (#161)

GRO-2234 review focus

• Sliding scoped to reason="sso-bridge" only (staff impersonation untouched).
• Bounded: 30-min idle, capped at startedAt + 8h; expired sessions never resurrected.
• New tests: src/__tests__/portalSessionSliding.test.ts. Merged tree typecheck + tests green locally.

cc @cpfarhood

## Promote dev → uat (cumulative batch) This promotion branch carries the full `dev → uat` delta. Latest update **adds GRO-2234** on top of the previously-approved batch, so the prior QA approval is now stale (head moved) and a **re-review is required** before self-merge. ### Included (uat-bound) commits - **GRO-2234** — portal SSO session **bounded sliding expiration** (`validatePortalSession`) + 30-min mint TTL alignment. (api #183) - GRO-2156 — travel buffer + reorder endpoint (Phase 2.2) (#180) - GRO-2211 — validate waitlist preferredTime/preferredDate (#179) - GRO-2203 — validate petId as UUID before PATCH (500→404) (#177) - GRO-2155 — route CRUD + optimization endpoint (Phase 2.1) (#175) - GRO-2163 — DB DNS resolution retry before drizzle-kit migrate (#161) ### GRO-2234 review focus - Sliding scoped to `reason="sso-bridge"` only (staff impersonation untouched). - Bounded: 30-min idle, capped at `startedAt + 8h`; expired sessions never resurrected. - New tests: `src/__tests__/portalSessionSliding.test.ts`. Merged tree typecheck + tests green locally. cc @cpfarhood

Flea Flicker added 6 commits 2026-06-08 18:11:24 +00:00

fix(db): wait for/retry DB DNS resolution before drizzle-kit migrate (GRO-2163) (#161) b9fc688769

feat(GRO-2155): route CRUD + optimization endpoint (Phase 2.1) (#175) d0c0b1b646

fix(portal): GRO-2203 validate petId as UUID before PATCH lookup (500→404) (#177) b842237425

fix(portal): validate waitlist preferredTime/preferredDate, return 400 on bad input (GRO-2211) (#179) 29c42e3130

feat(GRO-2156): travel buffer + reorder endpoint (Phase 2.2) (#180) ca62fb8ef6

Merge dev into uat: promote GRO-2156 route travel buffer + reorder (Phase 2.2) ... 6120b96c7c

Resolves UAT_PLAYBOOK.md conflict by unioning uat-only TC-UAT-2/3 (GRO-2100)
with dev's §4.16 update + new §4.17. Code files taken from dev (superset).

Co-Authored-By: Paperclip <noreply@paperclip.ing>

Lint Roller approved these changes 2026-06-08 18:18:51 +00:00

Dismissed

Lint Roller left a comment

Member

Copy Link

Copy Source

LGTM — code review complete (GRO-2237). Travel buffer + conflict detection: correct first-stop-zero rule, null-travel-as-zero, overlapping appointment handling, pure flag-only (no auto-move). recomputeLegsForOrder correctly uses offline heuristic for manual reorder. Two-pass stopOrder update avoids unique-constraint collision. Permutation validation exhaustive. Buffer re-applied correctly across all three endpoints. 7 unit tests cover all edge cases. CI green (Test / Lint & Typecheck / Build). UAT playbook §4.16-4.17 complete.

LGTM — code review complete (GRO-2237). Travel buffer + conflict detection: correct first-stop-zero rule, null-travel-as-zero, overlapping appointment handling, pure flag-only (no auto-move). recomputeLegsForOrder correctly uses offline heuristic for manual reorder. Two-pass stopOrder update avoids unique-constraint collision. Permutation validation exhaustive. Buffer re-applied correctly across all three endpoints. 7 unit tests cover all edge cases. CI green (Test / Lint & Typecheck / Build). UAT playbook §4.16-4.17 complete.

Flea Flicker added 2 commits 2026-06-08 19:17:57 +00:00

fix(GRO-2234): bounded sliding expiration for SSO portal sessions (#183) aabedc8152

Merge dev into uat: add GRO-2234 portal session sliding TTL + re-mint to dev→uat batch 636fa713e1

Flea Flicker changed title from Promote dev → uat: GRO-2156 route travel buffer + reorder (Phase 2.2) to Promote dev → uat: GRO-2155/2156/2203/2211/2163 + GRO-2234 (cumulative batch) 2026-06-08 19:18:33 +00:00

Lint Roller approved these changes 2026-06-08 19:24:58 +00:00

Lint Roller left a comment

Member

Copy Link

Copy Source

QA approved — GRO-2241 review pass. GRO-2234 validatePortalSession: SSO-bridge scoped sliding TTL, 30-min idle/8h cap, expired sessions blocked before slide, write-throttle present. 6 test cases clean. CI green. UAT_PLAYBOOK §8.17 confirmed. Self-merge cleared.

QA approved — GRO-2241 review pass. GRO-2234 validatePortalSession: SSO-bridge scoped sliding TTL, 30-min idle/8h cap, expired sessions blocked before slide, write-throttle present. 6 test cases clean. CI green. UAT_PLAYBOOK §8.17 confirmed. Self-merge cleared.

Flea Flicker merged commit 96dbb8c41d into uat 2026-06-08 19:42:26 +00:00

Flea Flicker referenced this pull request 2026-06-09 00:29:50 +00:00

uat→main (PROD): GRO-2234 portal session fix + validated batch #191

The Dogfather referenced this pull request 2026-06-09 00:34:49 +00:00

uat→main (PROD): GRO-2234 portal session fix + validated batch #191

Sign in to join this conversation.

Reviewers

No Reviewers

Lint Roller

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/api#182