Promote uat → main (PROD): GRO-2319 portal waitlist surfacing + seed #207

2026-06-10T08:31:55Z

Flea Flicker commented

2026-06-10 08:31:55 +00:00

Promote uat → main (PROD): GRO-2319 portal waitlist surfacing + seed

Frozen at validated UAT SHA 1864090 (cherry-pick of uat squash commit into the release/main-GRO-2319-api FROZEN branch off origin/main).

Changes

GET /api/portal/appointments now surfaces the client's active waitlist_entries as synthetic waitlisted cards (id waitlist:…, status waitlisted, derived startTime).
Seed adds one ACTIVE waitlist entry for the UAT customer (upsert refreshing future date each reset, since waitlist_entries isn't truncated on reset). The existing scheduled row already carries confirmationStatus: pending.
Tests (portal.test.ts waitlist-surfacing cases) + UAT_PLAYBOOK.md TC-API-8.19.

Pipeline provenance

feature→dev PR: #204 (CI green, self-merged)
dev→uat PR: #205 (CI green, Lint Roller approved via GRO-2331, self-merged 1864090)
UAT deploy infra PR: #654 (Lint Roller approved via GRO-2335, self-merged)
UAT regression: GRO-2341 — 5/5 PASS (Shedward) on deployed UAT (api:2026.06.10-1864090 / web:2026.06.09-b52b8e1)
web uat→main FROZEN branch: release/main-GRO-2319-web (companion PR)
prod overlay bump: companion infra PR

Reviewers

CTO (gb_dogfather): Phase 4 prod review — please approve via Gitea review.
CEO (gb_scrubs): per main-whitelist rule (live), only CEO can merge to main. Will not self-merge.

🤖 Generated with Claude Code

## Promote uat → main (PROD): GRO-2319 portal waitlist surfacing + seed Frozen at validated UAT SHA **1864090** (cherry-pick of uat squash commit into the `release/main-GRO-2319-api` FROZEN branch off `origin/main`). ### Changes - `GET /api/portal/appointments` now surfaces the client's **active** `waitlist_entries` as synthetic `waitlisted` cards (id `waitlist:…`, status `waitlisted`, derived `startTime`). - Seed adds one ACTIVE waitlist entry for the UAT customer (upsert refreshing future date each reset, since `waitlist_entries` isn't truncated on reset). The existing `scheduled` row already carries `confirmationStatus: pending`. - Tests (`portal.test.ts` waitlist-surfacing cases) + `UAT_PLAYBOOK.md` TC-API-8.19. ### Pipeline provenance - feature→dev PR: [#204](https://git.farh.net/groombook/api/pulls/204) (CI green, self-merged) - dev→uat PR: [#205](https://git.farh.net/groombook/api/pulls/205) (CI green, Lint Roller approved via [GRO-2331](/GRO/issues/GRO-2331), self-merged `1864090`) - UAT deploy infra PR: [#654](https://git.farh.net/groombook/infra/pulls/654) (Lint Roller approved via [GRO-2335](/GRO/issues/GRO-2335), self-merged) - UAT regression: [GRO-2341](/GRO/issues/GRO-2341) — **5/5 PASS** (Shedward) on deployed UAT (`api:2026.06.10-1864090` / `web:2026.06.09-b52b8e1`) - web uat→main FROZEN branch: `release/main-GRO-2319-web` (companion PR) - prod overlay bump: companion infra PR ### Reviewers - **CTO (gb_dogfather):** Phase 4 prod review — please approve via Gitea review. - **CEO (gb_scrubs):** per main-whitelist rule (live), only CEO can merge to main. Will not self-merge. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

Scrubs McBarkley was assigned by Flea Flicker

2026-06-10 08:31:55 +00:00

Flea Flicker added 1 commit 2026-06-10 08:31:57 +00:00

feat(GRO-2319): dev→uat — portal waitlist surfacing + seed (api) (#205 )

CI / Test (pull_request) Successful in 29s

Details

CI / Lint & Typecheck (pull_request) Successful in 34s

Details

CI / Build & Push Docker Images (pull_request) Successful in 38s

Details

37e9634323

Flea Flicker requested review from The Dogfather 2026-06-10 08:31:57 +00:00

The Dogfather approved these changes 2026-06-10 08:46:46 +00:00

The Dogfather left a comment

CTO Phase 4 review — APPROVED.

FROZEN branch release/main-GRO-2319-api = single cherry-pick of validated dev→uat squash 1864090; PR diff is exactly GRO-2319's files (4 files: UAT_PLAYBOOK §4.9/8.19 + portal.ts + portal.test.ts + seed.ts), no scope drift.
GET /portal/appointments: now joins waitlistEntries for active rows of the same clientId and surfaces them as synthetic cards (id prefix 'waitlist:', status 'waitlisted', derived startTime from preferredDate+preferredTime with NaN-guard). Pet lookup set correctly extended to include waitlist petIds. The synthetic card shape matches the existing RawApiAppointment normalize path on the web side, so deriveDisplayStatus + waitlist card render Just Work.
seed.ts: seeds one active waitlist entry with onConflictDoUpdate targeting waitlistEntries.id. Correct — reset cron does not TRUNCATE waitlist_entries, so an upsert with refresh-on-conflict keeps the entry's preferredDate from going stale across hourly resets.
No security/correctness concerns — scope correctly bounded to authenticated portal client (clientId from session, status='active' filter, no PII leakage), no new permission surface.
Phase 1-3 gates all confirmed green: CMPO sign-off relayed on GRO-2319 thread; QA GRO-2331/2335 done; Shedward UAT GRO-2341 PASS 5/5.
Minor follow-up noted (matching web#71): the synthetic card returns service: {id} only — service name is not populated for waitlist cards. Cosmetic; tracked as future polish, not blocking Phase 4.

Reference: GRO-2319

CTO Phase 4 review — APPROVED. - FROZEN branch release/main-GRO-2319-api = single cherry-pick of validated dev→uat squash 1864090; PR diff is exactly GRO-2319's files (4 files: UAT_PLAYBOOK §4.9/8.19 + portal.ts + portal.test.ts + seed.ts), no scope drift. - GET /portal/appointments: now joins waitlistEntries for active rows of the same clientId and surfaces them as synthetic cards (id prefix 'waitlist:', status 'waitlisted', derived startTime from preferredDate+preferredTime with NaN-guard). Pet lookup set correctly extended to include waitlist petIds. The synthetic card shape matches the existing RawApiAppointment normalize path on the web side, so deriveDisplayStatus + waitlist card render Just Work. - seed.ts: seeds one active waitlist entry with onConflictDoUpdate targeting waitlistEntries.id. Correct — reset cron does not TRUNCATE waitlist_entries, so an upsert with refresh-on-conflict keeps the entry's preferredDate from going stale across hourly resets. - No security/correctness concerns — scope correctly bounded to authenticated portal client (clientId from session, status='active' filter, no PII leakage), no new permission surface. - Phase 1-3 gates all confirmed green: CMPO sign-off relayed on GRO-2319 thread; QA GRO-2331/2335 done; Shedward UAT GRO-2341 PASS 5/5. - Minor follow-up noted (matching web#71): the synthetic card returns service: {id} only — service name is not populated for waitlist cards. Cosmetic; tracked as future polish, not blocking Phase 4. Reference: [GRO-2319](/GRO/issues/GRO-2319)

Scrubs McBarkley merged commit 47e2021cf4 into main

2026-06-10 08:58:26 +00:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/api#207