groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

feat(GRO-2425): split CORS_ORIGIN on commas for multiple trusted auth origins #216

Merged
Flea Flicker merged 1 commits from feature/GRO-2425-comma-split-cors-origin into dev 2026-06-18 00:46:30 +00:00
Conversation 0 Commits 1 Files Changed 2
+6 -2
Flea Flicker commented 2026-06-18 00:43:03 +00:00
Member
Copy Link
Copy Source

GRO-2425 — support multiple trusted auth origins (comma-split CORS_ORIGIN)

Follow-up to GRO-2424.

Changes

  • src/lib/auth.ts (lines 121, 311): both trustedOrigins now split CORS_ORIGIN on commas instead of wrapping as a single string. Setting CORS_ORIGIN="https://demo.groombook.dev,https://groombook.farh.net" will trust both hosts.
  • UAT_PLAYBOOK.md §4.1: added TC-API-1.27 and TC-API-1.28 for multi-origin callbackURL coverage.

No-regression contract

Single-value CORS_ORIGIN behaves identically (one-element array after split). BETTER_AUTH_URL stays https://demo.groombook.dev (OAuth callback host unchanged).

## GRO-2425 — support multiple trusted auth origins (comma-split CORS_ORIGIN) Follow-up to [GRO-2424](/GRO/issues/GRO-2424). ### Changes - `src/lib/auth.ts` (lines 121, 311): both `trustedOrigins` now split `CORS_ORIGIN` on commas instead of wrapping as a single string. Setting `CORS_ORIGIN="https://demo.groombook.dev,https://groombook.farh.net"` will trust both hosts. - `UAT_PLAYBOOK.md §4.1`: added TC-API-1.27 and TC-API-1.28 for multi-origin `callbackURL` coverage. ### No-regression contract Single-value `CORS_ORIGIN` behaves identically (one-element array after split). `BETTER_AUTH_URL` stays `https://demo.groombook.dev` (OAuth callback host unchanged).
Flea Flicker self-assigned this 2026-06-18 00:43:03 +00:00
Flea Flicker added 1 commit 2026-06-18 00:43:04 +00:00
feat(GRO-2425): split CORS_ORIGIN on commas for multiple trusted auth origins
CI / Test (pull_request) Successful in 32s
Details
CI / Lint & Typecheck (pull_request) Successful in 38s
Details
CI / Build & Push Docker Images (pull_request) Failing after 1m2s
Details
7f7e908e45 
Changes trustedOrigins from a single-string wrap to a comma-split array
so both demo.groombook.dev and groombook.farh.net can coexist as trusted
Better-Auth origins via a single CORS_ORIGIN env value.

Updated UAT_PLAYBOOK.md §4.1 — added TC-API-1.27 and TC-API-1.28 for
multi-origin callbackURL coverage.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
Flea Flicker merged commit c01e4acf0a into dev 2026-06-18 00:46:30 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees Flea Flicker
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#216
Delete Branch "feature/GRO-2425-comma-split-cors-origin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?