groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(GRO-1441): remove duplicate coatType/petSizeCategory from buildPet #35

Merged
The Dogfather merged 1 commits from fix/gro-1441-remove-duplicate-coat-props into dev 2026-05-23 18:31:01 +00:00
Conversation 0 Commits 1 Files Changed 1
-2
The Dogfather commented 2026-05-21 10:32:24 +00:00
Member
Copy Link
Copy Source

Summary

  • Remove duplicate coatType: null and petSizeCategory: null pairs from buildPet in packages/db/src/factories.ts
  • Lines 108-109 were introduced by the PR #12 merge; lines 102-103 already existed — removing the duplicate resolves TS1117

Acceptance criteria

  • pnpm typecheck passes
  • pnpm test passes (pre-existing seed-uat-credentials failure, unrelated)
  • No duplicate properties in buildPet object literal
  • PR opened to dev

Related

🤖 Generated with Claude Code

## Summary - Remove duplicate `coatType: null` and `petSizeCategory: null` pairs from `buildPet` in `packages/db/src/factories.ts` - Lines 108-109 were introduced by the PR #12 merge; lines 102-103 already existed — removing the duplicate resolves TS1117 ## Acceptance criteria - [x] `pnpm typecheck` passes - [ ] `pnpm test` passes (pre-existing seed-uat-credentials failure, unrelated) - [x] No duplicate properties in `buildPet` object literal - [x] PR opened to `dev` ## Related - Closes [GRO-1441](/GRO/issues/GRO-1441) - Blocks: [GRO-1442](/GRO/issues/GRO-1442) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The Dogfather added 1 commit 2026-05-21 10:32:25 +00:00
fix(GRO-1441): remove duplicate coatType/petSizeCategory from buildPet
CI / Lint & Typecheck (pull_request) Successful in 15s
Details
CI / Test (pull_request) Successful in 20s
Details
CI / Build & Push Docker Image (pull_request) Successful in 25s
Details
9f2809e89b 
Lines 108-109 were duplicates of lines 102-103 from the PR #12 merge.
Removing the duplicate pair resolves the TS1117 error on dev.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
The Dogfather merged commit b5a08a2c7e into dev 2026-05-23 18:31:01 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#35
Delete Branch "fix/gro-1441-remove-duplicate-coat-props"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?