groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

Fix GRO-1118: Auto-create staff records for OAuth users #4

Closed
groombook-engineer[bot] wants to merge 1 commits from flea-flicker/auto-create-staff-oauth-users-v2 into dev
pull from: flea-flicker/auto-create-staff-oauth-users-v2
merge into: groombook:dev
Conversation 1 Commits 1 Files Changed 1
+23 -2
groombook-engineer[bot] commented 2026-05-12 19:19:13 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

Fixes GRO-1118 - uat-tester receives HTTP 403 on all app routes post-login

Problem

When a user authenticates via OAuth (Authentik SSO), Better-Auth creates a user record in the `user` table, but there's no corresponding staff record. The RBAC middleware returns 403 Forbidden when no staff record exists for the authenticated user.

This happened to uat-tester after the GitRepository fix (PR #335) resolved the `email_is_missing` OAuth error. The user could authenticate successfully but couldn't access any routes.

Solution

Modified the RBAC middleware to auto-create staff records for authenticated OAuth users when no corresponding staff record exists. The middleware now checks for staff records in this order:

  1. By `userId` (Better-Auth user ID)
  2. By `oidcSub` (legacy OIDC subject for older records)
  3. By email (auto-link existing staff record with no userId)
  4. NEW: Create new staff record if authenticated user has email and name

New staff records are created with a default `receptionist` role and `active: true`. This allows new OAuth users to access the app immediately.

Changes

  • `apps/api/src/middleware/rbac.ts`: Added auto-create staff record logic
    • Removed duplicate `StaffRole` type (now inferred from `staffRoleEnum`)
    • Added staff record creation for authenticated users with email and name
    • Properly handles the case where insert might return undefined

Testing

  • All existing RBAC tests pass
  • Type checking passes with no errors

Impact

  • New OAuth users can now access the app without manual staff record creation
  • Existing auto-link by email functionality continues to work
  • No breaking changes to existing behavior

cc @cpfarhood

## Summary Fixes GRO-1118 - uat-tester receives HTTP 403 on all app routes post-login ## Problem When a user authenticates via OAuth (Authentik SSO), Better-Auth creates a user record in the \`user\` table, but there's no corresponding staff record. The RBAC middleware returns 403 Forbidden when no staff record exists for the authenticated user. This happened to uat-tester after the GitRepository fix (PR #335) resolved the \`email_is_missing\` OAuth error. The user could authenticate successfully but couldn't access any routes. ## Solution Modified the RBAC middleware to auto-create staff records for authenticated OAuth users when no corresponding staff record exists. The middleware now checks for staff records in this order: 1. By \`userId\` (Better-Auth user ID) 2. By \`oidcSub\` (legacy OIDC subject for older records) 3. By email (auto-link existing staff record with no userId) 4. **NEW**: Create new staff record if authenticated user has email and name New staff records are created with a default \`receptionist\` role and \`active: true\`. This allows new OAuth users to access the app immediately. ## Changes - \`apps/api/src/middleware/rbac.ts\`: Added auto-create staff record logic - Removed duplicate \`StaffRole\` type (now inferred from \`staffRoleEnum\`) - Added staff record creation for authenticated users with email and name - Properly handles the case where insert might return undefined ## Testing - All existing RBAC tests pass - Type checking passes with no errors ## Impact - New OAuth users can now access the app without manual staff record creation - Existing auto-link by email functionality continues to work - No breaking changes to existing behavior cc @cpfarhood
Scrubs McBarkley commented 2026-05-20 12:10:46 +00:00
Owner
Copy Link
Copy Source

Closing as stale and superseded. This PR (GRO-1118: auto-create staff for OAuth) is not mergeable due to conflicts, has no reviews, and the underlying problem (HTTP 403 on authenticated routes post-login) has been addressed by the more complete implementation in PR #19 (GRO-1272: auto-provision staff on OIDC login). Closing per org-wide PR backlog cleanup (GRO-1355).

Closing as stale and superseded. This PR (GRO-1118: auto-create staff for OAuth) is not mergeable due to conflicts, has no reviews, and the underlying problem (HTTP 403 on authenticated routes post-login) has been addressed by the more complete implementation in PR #19 (GRO-1272: auto-provision staff on OIDC login). Closing per org-wide PR backlog cleanup ([GRO-1355](/GRO/issues/GRO-1355)).
Scrubs McBarkley closed this pull request 2026-05-20 12:10:46 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#4
Delete Branch "flea-flicker/auto-create-staff-oauth-users-v2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?