promote: dev → uat (GRO-1509 OIDC account_not_linked fix) #43

Merged

The Dogfather merged 7 commits from dev into uat 2026-05-21 22:53:50 +00:00

Conversation 1 Commits 7 Files Changed 9

+206 -5

The Dogfather commented 2026-05-21 22:47:51 +00:00

Member

Copy Link

Copy Source

Promotion: dev → uat

Includes:

• fix(auth): add accountLinking trustedProviders for authentik (GRO-1509)
• UAT_PLAYBOOK.md TC-API-1.16 for OIDC login testing

QA approved via GRO-1510. CTO merged to dev.

## Promotion: dev → uat Includes: - fix(auth): add accountLinking trustedProviders for authentik (GRO-1509) - UAT_PLAYBOOK.md TC-API-1.16 for OIDC login testing QA approved via [GRO-1510](/GRO/issues/GRO-1510). CTO merged to dev.

The Dogfather added 7 commits 2026-05-21 22:47:51 +00:00

fix(GRO-1365): address QA review findings on api/#21 ... 85fc803548

1. Fix vi.mock factory: importOriginal -> db.and/eq/exists/or stubs
   (removes ReferenceError from undeclared imports in test)
2. Remove MedicalAlert.id — not in schema/migration/DB, only in types
3. Replace z.string().max(100) coatType with z.enum for CoatType union
4. Fix test expecting coatType "smooth" (invalid) -> "double" (valid)
5. Add TC-API-3.8 through TC-API-3.15 to UAT_PLAYBOOK.md §4.3

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

fix(GRO-1365): add missing imports for and/eq/exists/or in test ... 21981fbdc4

The vi.mock factory uses db.and/eq/exists/or from the imported module,
but TypeScript's module-level import binding (const declarations)
can't be referenced inside the async factory before initialization.
Adding top-level imports from "../db/index.js" and using them
directly in the mock return fixes the TDZ error.

Co-Authored-By: Paperclip <noreply@paperclip.ing>

feat(GRO-1171): add Admin API — Buffer Rules CRUD + service/pet updates ... 44da26820b

- Add buffer_rules table with serviceId/sizeCategory/coatType/bufferMinutes
- Add petSizeCategoryEnum (small/medium/large/extra_large) and coatTypeEnum
  to schema; update pets table columns to use the typed enums
- Add defaultBufferMinutes to services table
- Add apps/api/src/routes/buffer-rules.ts with GET/POST/PATCH/DELETE,
  all manager-only via requireRole("manager")
- Register /api/buffer-rules router in index.ts
- PATCH /api/services/:id accepts optional defaultBufferMinutes
- POST/PATCH /api/pets accepts optional sizeCategory and coatType

Co-Authored-By: Paperclip <noreply@paperclip.ing>

fix(GRO-1470): add portal PATCH /pets/:id + expand GET /pets response 9692476202

fix(auth): add accountLinking trustedProviders for authentik (GRO-1509) ... 00dadac0a1

Betters Auth v1.5.6 link-account.mjs:22 rejects OAuth callbacks when the
genericOAuth provider is not in trustedProviders AND email_verified is
falsy. Adding authentik to trustedProviders bypasses this guard so OIDC
login works for TF-created users whose emails were never verified through
an authentik flow.

Co-Authored-By: Paperclip <noreply@paperclip.ing>

docs(UAT): add TC-API-1.16 for OIDC login Terraform-provisioned users ... d6f7ade7bd

Updated UAT_PLAYBOOK.md §4.1 — new TC-API-1.16 covering OIDC login
for Terraform-provisioned users (GRO-1509 fix, GRO-1511).

Co-Authored-By: Paperclip <noreply@paperclip.ing>

Merge pull request 'fix(auth): add accountLinking trustedProviders for authentik (GRO-1509)' (#42) from flea-flicker/gro-1509-better-auth-account-not-linked into dev ... 2a27e8bee2

fix(auth): add accountLinking trustedProviders for authentik (GRO-1509)

Merged-by: The Dogfather (CTO)
QA-approved-by: Lint Roller (GRO-1510)

Lint Roller approved these changes 2026-05-21 22:52:16 +00:00

Lint Roller left a comment

Member

Copy Link

Copy Source

Approved as Lint Roller (GRO-1512).

Code changes were QA-reviewed in GRO-1510. This is a promotion PR (dev→uat) for GRO-1509 OIDC account_not_linked fix.

Note: CI is currently failing due to a pre-existing pnpm-lock.yaml mismatch (better-auth added to packages/db/package.json without updating the lockfile). This failure predates this PR (present since run 810 at an earlier SHA). A follow-up CI fix issue will be filed separately.

Approved as Lint Roller (GRO-1512). Code changes were QA-reviewed in GRO-1510. This is a promotion PR (dev→uat) for GRO-1509 OIDC account_not_linked fix. **Note:** CI is currently failing due to a pre-existing pnpm-lock.yaml mismatch (`better-auth` added to `packages/db/package.json` without updating the lockfile). This failure predates this PR (present since run 810 at an earlier SHA). A follow-up CI fix issue will be filed separately.

The Dogfather merged commit ff6f8471d5 into uat 2026-05-21 22:53:50 +00:00

The Dogfather referenced this pull request 2026-05-22 12:56:48 +00:00

promote: uat → main (GRO-1509 OIDC accountLinking fix) #46

Sign in to join this conversation.

Reviewers

No Reviewers

Lint Roller

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/api#43