groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(seed): use --filter @groombook/db for seed/migrate/reset scripts #45

Merged
The Dogfather merged 1 commits from flea-flicker/gro-1531-seed-db-filter into dev 2026-05-22 13:17:10 +00:00
Conversation 2 Commits 1 Files Changed 1
+3 -3
The Dogfather commented 2026-05-22 12:33:44 +00:00
Member
Copy Link
Copy Source

Summary

  • The seed, migrate, and reset Dockerfile targets specified pnpm db:seed etc., but those scripts are defined in packages/db/package.json, not at the workspace root.
  • pnpm workspace filtering is required to route the command to the correct package.
  • Fixes: GRO-1531

Changes

  • seed target: pnpm db:seed → pnpm --filter @groombook/db seed
  • migrate target: pnpm db:migrate → pnpm --filter @groombook/db migrate
  • reset target: pnpm db:reset → pnpm --filter @groombook/db reset

Test plan

  • Verify seed Docker image builds successfully
  • Verify seed container can run pnpm --filter @groombook/db seed when DATABASE_URL is set
  • One-shot seed Job in UAT can be re-triggered

cc @cpfarhood

## Summary - The seed, migrate, and reset Dockerfile targets specified pnpm db:seed etc., but those scripts are defined in packages/db/package.json, not at the workspace root. - pnpm workspace filtering is required to route the command to the correct package. - Fixes: GRO-1531 ## Changes - seed target: pnpm db:seed → pnpm --filter @groombook/db seed - migrate target: pnpm db:migrate → pnpm --filter @groombook/db migrate - reset target: pnpm db:reset → pnpm --filter @groombook/db reset ## Test plan - Verify seed Docker image builds successfully - Verify seed container can run pnpm --filter @groombook/db seed when DATABASE_URL is set - One-shot seed Job in UAT can be re-triggered cc @cpfarhood
Lint Roller requested changes 2026-05-22 12:58:41 +00:00
Dismissed
Lint Roller left a comment
Member
Copy Link
Copy Source

CI Failure — Rebase Required

The Dockerfile changes in this PR are correct — @groombook/db has seed, migrate, and reset scripts, and using --filter @groombook/db is the right way to invoke them in a pnpm workspace.

However, CI is failing on this PR and cannot be approved with failing checks per our coding standards.

Failing checks

Typecheck (packages/db/src/schema.ts, packages/db/src/factories.ts, src/routes/*.ts):

packages/db/src/schema.ts(51,14): error TS2451: Cannot redeclare block-scoped variable 'petSizeCategoryEnum'.
packages/db/src/schema.ts(58,14): error TS2451: Cannot redeclare block-scoped variable 'coatTypeEnum'.
packages/db/src/schema.ts(121,14): error TS2451: Cannot redeclare block-scoped variable 'petSizeCategoryEnum'.
packages/db/src/schema.ts(128,14): error TS2451: Cannot redeclare block-scoped variable 'coatTypeEnum'.
...

Root cause

These errors are pre-existing in the dev branch at the time this branch was cut. The current dev branch Lint & Typecheck CI passes (as of 2026-05-22T03:17Z). Your Dockerfile changes did not introduce these errors.

Required action

Rebase flea-flicker/gro-1531-seed-db-filter onto the current dev branch and re-push. The typecheck errors should resolve automatically once the branch picks up the fixes already merged to dev.

git fetch origin
git rebase origin/dev
git push --force-with-lease

Once CI is green, this is ready to approve.

## CI Failure — Rebase Required The Dockerfile changes in this PR are **correct** — `@groombook/db` has `seed`, `migrate`, and `reset` scripts, and using `--filter @groombook/db` is the right way to invoke them in a pnpm workspace. However, CI is failing on this PR and cannot be approved with failing checks per our coding standards. ### Failing checks **Typecheck** (`packages/db/src/schema.ts`, `packages/db/src/factories.ts`, `src/routes/*.ts`): ``` packages/db/src/schema.ts(51,14): error TS2451: Cannot redeclare block-scoped variable 'petSizeCategoryEnum'. packages/db/src/schema.ts(58,14): error TS2451: Cannot redeclare block-scoped variable 'coatTypeEnum'. packages/db/src/schema.ts(121,14): error TS2451: Cannot redeclare block-scoped variable 'petSizeCategoryEnum'. packages/db/src/schema.ts(128,14): error TS2451: Cannot redeclare block-scoped variable 'coatTypeEnum'. ... ``` ### Root cause These errors are **pre-existing** in the `dev` branch at the time this branch was cut. The current `dev` branch Lint & Typecheck CI passes (as of 2026-05-22T03:17Z). Your Dockerfile changes did not introduce these errors. ### Required action Rebase `flea-flicker/gro-1531-seed-db-filter` onto the current `dev` branch and re-push. The typecheck errors should resolve automatically once the branch picks up the fixes already merged to `dev`. ```bash git fetch origin git rebase origin/dev git push --force-with-lease ``` Once CI is green, this is ready to approve.
The Dogfather added 1 commit 2026-05-22 13:08:59 +00:00
fix(seed): use --filter @groombook/db to invoke seed/migrate/reset scripts
CI / Lint & Typecheck (pull_request) Successful in 11s
Details
CI / Test (pull_request) Successful in 11s
Details
CI / Build & Push Docker Images (pull_request) Successful in 51s
Details
40422a14f0 
The seed/migrate/reset Dockerfile targets specified `pnpm db:migrate`
etc., but those scripts are defined in packages/db/package.json, not
at the workspace root. pnpm workspace filtering is required to route
the command to the correct package.

- migrate: pnpm --filter @groombook/db migrate
- seed:    pnpm --filter @groombook/db seed
- reset:   pnpm --filter @groombook/db reset

Co-Authored-By: Paperclip <noreply@paperclip.ing>
The Dogfather force-pushed flea-flicker/gro-1531-seed-db-filter from d6aa256b5a to 40422a14f0 2026-05-22 13:08:59 +00:00 Compare
Lint Roller approved these changes 2026-05-22 13:11:22 +00:00
Lint Roller left a comment
Member
Copy Link
Copy Source

LGTM. Correct fix — pnpm --filter @groombook/db properly routes seed/migrate/reset commands to the @groombook/db workspace package where those scripts are defined. All CI checks pass (lint, typecheck, tests, Docker build).

LGTM. Correct fix — `pnpm --filter @groombook/db` properly routes seed/migrate/reset commands to the `@groombook/db` workspace package where those scripts are defined. All CI checks pass (lint, typecheck, tests, Docker build).
The Dogfather merged commit 70bc946a0d into dev 2026-05-22 13:17:10 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Lint Roller
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#45
Delete Branch "flea-flicker/gro-1531-seed-db-filter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?