groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(api): add timeouts for OIDC discovery fetch and DB connection #66

Merged
Scrubs McBarkley merged 1 commits from fix/gro-1678-econnreset-robustness into dev 2026-05-24 20:11:44 +00:00
Conversation 0 Commits 1 Files Changed 3
+10 -6
Scrubs McBarkley commented 2026-05-24 19:46:36 +00:00
Owner
Copy Link
Copy Source

Summary

  • OIDC discovery fetch in initAuth() now has a 5s AbortSignal.timeout to fail fast when the auth server is unreachable (identified root cause of startup ECONNRESET crashes on UAT where ztunnel drops TCP connections before headers arrive).
  • DB postgres client now sets connect_timeout: 5 so failed connection attempts fail fast rather than hanging startup.
  • Graceful shutdown timeout tightened to 8s (from 10s) to avoid being killed by Kubernetes liveness-probe deadline while draining.

Changes

  • packages/db/src/index.ts: postgres() → postgres(..., { connect_timeout: 5 })
  • src/lib/auth.ts: OIDC discovery fetch gets signal: AbortSignal.timeout(5000)
  • src/index.ts: shutdown timeout 10s → 8s

Test plan

  • All 524 unit tests pass
  • Deploy to dev, verify /api/health still returns 200
  • Verify startup no longer hangs on OIDC discovery failure

Fixes GRO-1678.

cc @cpfarhood

## Summary - OIDC discovery fetch in initAuth() now has a 5s AbortSignal.timeout to fail fast when the auth server is unreachable (identified root cause of startup ECONNRESET crashes on UAT where ztunnel drops TCP connections before headers arrive). - DB postgres client now sets connect_timeout: 5 so failed connection attempts fail fast rather than hanging startup. - Graceful shutdown timeout tightened to 8s (from 10s) to avoid being killed by Kubernetes liveness-probe deadline while draining. ## Changes - packages/db/src/index.ts: postgres() → postgres(..., { connect_timeout: 5 }) - src/lib/auth.ts: OIDC discovery fetch gets signal: AbortSignal.timeout(5000) - src/index.ts: shutdown timeout 10s → 8s ## Test plan - [x] All 524 unit tests pass - [ ] Deploy to dev, verify /api/health still returns 200 - [ ] Verify startup no longer hangs on OIDC discovery failure Fixes GRO-1678. cc @cpfarhood
Scrubs McBarkley added 1 commit 2026-05-24 19:46:36 +00:00
fix(api): add timeouts for OIDC discovery fetch and DB connection
CI / Test (pull_request) Successful in 16s
Details
CI / Lint & Typecheck (pull_request) Successful in 19s
Details
CI / Build & Push Docker Images (pull_request) Successful in 52s
Details
dc3c23055a 
- OIDC discovery fetch in initAuth() now has a 5s AbortSignal.timeout
  to fail fast instead of hanging indefinitely when the auth server is unreachable.
  This was identified as a root cause of startup ECONNRESET crashes on UAT
  where ztunnel drops TCP connections before headers arrive.

- DB postgres client now sets connect_timeout: 5 so failed connection attempts
  fail fast rather than hanging the startup sequence.

- Graceful shutdown timeout tightened to 8s (from 10s) to avoid
  getting killed by Kubernetes liveness-probe deadline while draining.

Fixes GRO-1678.

Co-Authored-By: Paperclip <noreply@paperclip.ing>
Scrubs McBarkley merged commit b486c44a82 into dev 2026-05-24 20:11:44 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#66
Delete Branch "fix/gro-1678-econnreset-robustness"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?