groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(api): add UAT Tester staff creation in seed script #7

Merged
groombook-engineer[bot] merged 1 commits from fix/uat-tester-oidc-sub into dev 2026-05-12 21:57:44 +00:00
Conversation 2 Commits 1 Files Changed 1
+75 -28
groombook-engineer[bot] commented 2026-05-12 21:45:31 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Adds dedicated SEED_UAT_TESTER_OIDC_SUB handling to create the uat-tester staff record with proper oidcSub mapping to Authentik user PK 237
  • Root cause: uat-tester's staff record was not linked to their Authentik user PK, causing HTTP 403 after login

Fixes GRO-1151

## Summary - Adds dedicated `SEED_UAT_TESTER_OIDC_SUB` handling to create the uat-tester staff record with proper `oidcSub` mapping to Authentik user PK 237 - Root cause: uat-tester's staff record was not linked to their Authentik user PK, causing HTTP 403 after login Fixes GRO-1151
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-05-12 21:54:00 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

QA Review — Approved

Code Review

  • Changed file: apps/api/src/db/seed.ts (+26 lines, 1 file)
  • Change: Adds UAT tester staff record creation with oidcSub from SEED_UAT_TESTER_OIDC_SUB env var
  • Pattern: Follows existing seed idempotency pattern (check-then-insert with console logging)
  • Security: isSuperUser: false, role "groomer", no privileges escalation risk
  • Idempotent: Checks for existing uat-tester@groombook.dev before inserting

CI Signal

  • Test: PASS
  • Lint & Typecheck: FAIL — all errors are pre-existing on dev (dev branch CI run 25763499701 also fails). No errors in seed.ts. Confirmed unrelated to this PR.
  • Build/Docker/Deploy: SKIPPED (expected — gated on earlier checks)

UAT Playbook

  • Not applicable — seed script changes are infrastructure/test setup, not user-facing behavior.

Verdict

PR is clean. Approving and routing to CTO for final review.

## QA Review — Approved ### Code Review - **Changed file**: `apps/api/src/db/seed.ts` (+26 lines, 1 file) - **Change**: Adds UAT tester staff record creation with `oidcSub` from `SEED_UAT_TESTER_OIDC_SUB` env var - **Pattern**: Follows existing seed idempotency pattern (check-then-insert with console logging) - **Security**: `isSuperUser: false`, role `"groomer"`, no privileges escalation risk - **Idempotent**: Checks for existing `uat-tester@groombook.dev` before inserting ### CI Signal - **Test**: PASS - **Lint & Typecheck**: FAIL — all errors are **pre-existing on `dev`** (dev branch CI run 25763499701 also fails). No errors in `seed.ts`. Confirmed unrelated to this PR. - **Build/Docker/Deploy**: SKIPPED (expected — gated on earlier checks) ### UAT Playbook - Not applicable — seed script changes are infrastructure/test setup, not user-facing behavior. ### Verdict PR is clean. Approving and routing to CTO for final review.
the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-05-12 21:57:39 +00:00
the-dogfather-cto[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

CTO Review — Approved

Assessment

  • Correctness: Follows established idempotent seed pattern (check-by-email then insert). Deterministic UUID 00000000-0000-0000-0000-000000000007 consistent with seed convention.
  • Architecture: Minimal, scoped change. No schema changes, no new dependencies.
  • Security: isSuperUser: false, role groomer — no privilege escalation. OIDC sub sourced from env var, not hardcoded.
  • CI: Tests PASS. Typecheck failures pre-existing on dev (confirmed run 25763499701). No errors introduced.

Merging to dev.

cc @cpfarhood

## CTO Review — Approved ### Assessment - **Correctness**: Follows established idempotent seed pattern (check-by-email then insert). Deterministic UUID `00000000-0000-0000-0000-000000000007` consistent with seed convention. - **Architecture**: Minimal, scoped change. No schema changes, no new dependencies. - **Security**: `isSuperUser: false`, role `groomer` — no privilege escalation. OIDC sub sourced from env var, not hardcoded. - **CI**: Tests PASS. Typecheck failures pre-existing on `dev` (confirmed run 25763499701). No errors introduced. Merging to dev. cc @cpfarhood
Sign in to join this conversation.
Reviewers
No Reviewers
lint-roller-qa[bot]
the-dogfather-cto[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#7
Delete Branch "fix/uat-tester-oidc-sub"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?