groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(db): add missing extended pet profile fields to buildPet factory #75

Closed
Flea Flicker wants to merge 2 commits from fix/gro-1752-extended-pet-profile-fields into dev
pull from: fix/gro-1752-extended-pet-profile-fields
merge into: groombook:dev
Conversation 0 Commits 2 Files Changed 2
+9
Flea Flicker commented 2026-05-25 18:40:09 +00:00
Member
Copy Link
Copy Source

Summary

Fixes packages/db/src/factories.ts buildPet factory to include the 4 fields added to the pets table schema in PR #73:

  • temperamentScore: null
  • temperamentFlags: []
  • medicalAlerts: []
  • preferredCuts: []

These were missing from the factory defaults, causing TypeScript error TS2739 in the Docker build job when the PetRow type was updated.

Test plan

  • CI Build & Push passes (all 3 jobs green)
  • pnpm build completes without TS errors in factories.ts

🤖 Generated with Claude Code

## Summary Fixes `packages/db/src/factories.ts` `buildPet` factory to include the 4 fields added to the `pets` table schema in [PR #73](https://git.farh.net/groombook/api/pulls/73): - `temperamentScore: null` - `temperamentFlags: []` - `medicalAlerts: []` - `preferredCuts: []` These were missing from the factory defaults, causing TypeScript error `TS2739` in the Docker build job when the `PetRow` type was updated. ## Test plan - [ ] CI Build & Push passes (all 3 jobs green) - [ ] `pnpm build` completes without TS errors in factories.ts 🤖 Generated with [Claude Code](https://claude.ai/claude-code)
Flea Flicker added 2 commits 2026-05-25 18:40:10 +00:00
fix(schema): add missing extended pet profile fields to packages/db
CI / Test (pull_request) Successful in 10s
Details
CI / Lint & Typecheck (pull_request) Successful in 12s
Details
CI / Build & Push Docker Images (pull_request) Failing after 24s
Details
8c184dddbd 
Add temperamentScore, temperamentFlags, medicalAlerts, and preferredCuts
to the pets table in packages/db/src/schema.ts to match the API schema.

These columns already exist in the database via migration
0030_extended_pet_profile.sql (confirmed by GRO-1748).

Refs: GRO-1752

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
fix(db): add missing extended pet profile fields to buildPet factory
CI / Lint & Typecheck (pull_request) Successful in 9s
Details
CI / Test (pull_request) Successful in 9s
Details
CI / Build & Push Docker Images (pull_request) Successful in 47s
Details
b3b2113daa 
Lint Roller (QA) flagged that buildPet in factories.ts was missing the
4 fields added to the pets table schema, causing TS2739 in the Docker
build job (run 1701, job 3717).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The Dogfather closed this pull request 2026-05-25 18:44:54 +00:00
Some checks are pending
CI / Lint & Typecheck (pull_request) Successful in 9s
Details
CI / Test (pull_request) Successful in 9s
Details
CI / Build & Push Docker Images (pull_request) Successful in 47s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#75
Delete Branch "fix/gro-1752-extended-pet-profile-fields"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?