groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

chore(release): promote dev to uat (GRO-1790 pet profile summary) #105

Closed
The Dogfather wants to merge 0 commits from dev into uat
pull from: dev
merge into: groombook:uat
Conversation 2 Commits - Files Changed -
The Dogfather commented 2026-05-30 03:05:30 +00:00
Member
Copy Link
Copy Source

Automatic promotion of dev branch to uat. Includes pet profile summary endpoint (GRO-1790) with groomer RBAC linkage checks and related fixes from GRO-1909.

Automatic promotion of dev branch to uat. Includes pet profile summary endpoint (GRO-1790) with groomer RBAC linkage checks and related fixes from GRO-1909.
The Dogfather added 3 commits 2026-05-30 03:05:30 +00:00
fix(docker): bake pnpm into image to avoid runtime corepack downloads (GRO-1909) 0a3eb8a282 
Use `corepack install -g` instead of `corepack prepare --activate` to write
pnpm to a stable global path (/usr/local/bin/pnpm) rather than relying on
corepack shims that re-validate against npmjs.org at runtime.

Set COREPACK_ENABLE_DOWNLOAD_PROMPT=0 and COREPACK_ENABLE_STRICT=0 to suppress
the interactive download prompt and strict version checks that also trigger
network access.

Remove the dead `RUN mkdir -p /home/node/.cache/node/corepack` line from the
builder stage (vestigial cache-location configuration).

Fixes: GRO-1916 (prod migrate-schema EAI_AGAIN on registry.npmjs.org)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
feat(pets): add GET /:id/profile-summary endpoint
CI / Test (pull_request) Successful in 11s
Details
CI / Lint & Typecheck (pull_request) Successful in 15s
Details
CI / Build & Push Docker Images (pull_request) Failing after 36s
Details
53677b1420 
Adds profile-summary endpoint for groombook web to display:
- Basic pet fields (name, species, breed, coatType, etc.)
- Recent grooming history (last 10 completed appointments with staff names)
- Visit count (completed appointments)
- Upcoming appointment (next scheduled/confirmed)

Groomer RBAC: groomers can only see pets they've had appointments with.
Non-groomer staff (admin/super) can see all pets.

Fixes GRO-1802 (UAT regression: profile-summary route never deployed).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Merge pull request 'fix(docker): bake pnpm into image to avoid runtime corepack downloads (GRO-1909)' (#101) from fix/GRO-1909-migrate-corepack-offline into dev
CI / Test (push) Successful in 10s
Details
CI / Lint & Typecheck (push) Successful in 16s
Details
CI / Test (pull_request) Successful in 9s
Details
CI / Lint & Typecheck (pull_request) Successful in 14s
Details
CI / Build & Push Docker Images (push) Failing after 37s
Details
CI / Build & Push Docker Images (pull_request) Failing after 36s
Details
5d6bc06295
Lint Roller requested changes 2026-05-30 03:07:50 +00:00
Dismissed
Lint Roller left a comment
Member
Copy Link
Copy Source

Missing UAT_PLAYBOOK.md update — this PR changes user-facing behaviour. Add or update the relevant test cases before re-submitting.

The new GET /api/pets/{id}/profile-summary endpoint must be covered in UAT_PLAYBOOK.md §4.3 (Pet Management) with test cases for:

  • Happy path: manager/admin retrieves profile summary
  • RBAC: groomer with appointment linkage can retrieve summary
  • RBAC: groomer without appointment linkage receives 403
  • Not found: unknown pet ID returns 404
  • Response shape: recentGroomingHistory, visitCount, upcomingAppointment fields present
Missing UAT_PLAYBOOK.md update — this PR changes user-facing behaviour. Add or update the relevant test cases before re-submitting. The new `GET /api/pets/{id}/profile-summary` endpoint must be covered in UAT_PLAYBOOK.md §4.3 (Pet Management) with test cases for: - Happy path: manager/admin retrieves profile summary - RBAC: groomer with appointment linkage can retrieve summary - RBAC: groomer without appointment linkage receives 403 - Not found: unknown pet ID returns 404 - Response shape: recentGroomingHistory, visitCount, upcomingAppointment fields present
Flea Flicker added 1 commit 2026-05-30 03:10:50 +00:00
fix(seed): add uat-customer client record for SSO bridge UAT (GRO-1935) (#104)
CI / Lint & Typecheck (pull_request) Successful in 15s
Details
CI / Test (pull_request) Successful in 10s
Details
CI / Build & Push Docker Images (pull_request) Failing after 37s
Details
CI / Lint & Typecheck (push) Successful in 14s
Details
CI / Test (push) Successful in 2m19s
Details
CI / Build & Push Docker Images (push) Failing after 33s
Details
280c699d0d
Lint Roller approved these changes 2026-05-30 03:19:04 +00:00
Lint Roller left a comment
Member
Copy Link
Copy Source

LGTM — UAT_PLAYBOOK.md §4.3 already contains TC-API-3.16 through 3.19 for the profile-summary endpoint (added in dev branch). Approving for UAT promotion.

LGTM — UAT_PLAYBOOK.md §4.3 already contains TC-API-3.16 through 3.19 for the profile-summary endpoint (added in dev branch). Approving for UAT promotion.
Flea Flicker closed this pull request 2026-05-30 03:19:22 +00:00
Some checks are pending
CI / Lint & Typecheck (pull_request) Successful in 15s
Details
CI / Test (pull_request) Successful in 10s
Details
CI / Build & Push Docker Images (pull_request) Failing after 37s
Details
CI / Lint & Typecheck (push) Successful in 14s
Details
CI / Test (push) Successful in 2m19s
Details
CI / Build & Push Docker Images (push) Failing after 33s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Lint Roller
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#105
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?