Promote dev→uat: GRO-1982 pet_size_category extra_large enum migration #126

Merged

The Dogfather merged 10 commits from dev into uat 2026-06-01 12:44:20 +00:00

Conversation 1 Commits 10 Files Changed 3

+34 -10

Flea Flicker commented 2026-06-01 12:30:09 +00:00

Member

Copy Link

Copy Source

Promotes dev to uat. The critical fix is the pet_size_category enum migration (GRO-1982, PR #124) which unblocks the UAT reset-demo-data CronJob that was failing with:

invalid input value for enum pet_size_category: "extra_large"

Migration 0037_add_extra_large_to_pet_size_category.sql adds the value to the enum so the seed can complete.

Also includes:

• b15a53a: deterministic TestCooper/TestRocky medical alerts (GRO-1962)
• 1faa794, b928acf: credential password re-run fix (GRO-1977)
• dd22059: missing coat_type enum values (GRO-1971)

cc @cpfarhood

Promotes dev to uat. The critical fix is the pet_size_category enum migration (GRO-1982, PR #124) which unblocks the UAT reset-demo-data CronJob that was failing with: invalid input value for enum pet_size_category: "extra_large" Migration 0037_add_extra_large_to_pet_size_category.sql adds the value to the enum so the seed can complete. Also includes: - b15a53a: deterministic TestCooper/TestRocky medical alerts (GRO-1962) - 1faa794, b928acf: credential password re-run fix (GRO-1977) - dd22059: missing coat_type enum values (GRO-1971) cc @cpfarhood

Flea Flicker added 6 commits 2026-06-01 12:30:10 +00:00

fix: add missing coat_type enum values (GRO-1971) (#118) dd220598ca

fix(seed): update credential password on existing accounts — not skip (GRO-1977) (#120) b928acf5d6

fix(seed): update credential password on re-run instead of skipping (GRO-1977) (#121) ... 1faa7945c6

fix(seed): update credential password on re-run instead of skipping (GRO-1977)

fix(seed): restore deterministic alerts for TestCooper/TestRocky (GRO-1962) (#122) ... b15a53a19b

Co-authored-by: The Dogfather <20+gb_dogfather@noreply.git.farh.net>
Co-committed-by: The Dogfather <20+gb_dogfather@noreply.git.farh.net>

feat(db): add 0037_add_extra_large_to_pet_size_category — register extra_large in journal ... f262c19561

GRO-1979: The pet_size_category enum created in 0031_buffer_rules.sql
contained ('small', 'medium', 'large', 'xlarge'), but the drizzle schema
and seed.ts both use 'extra_large'. The mismatch caused the UAT seed job
to fail with:
  invalid input value for enum pet_size_category: "extra_large"

This migration adds the 'extra_large' value to pet_size_category and
registers it at idx 37 in the drizzle journal (sequel to 0035/0036
which registered short/medium/silky in coat_type under GRO-1971).

Non-transactional per Postgres restriction on ALTER TYPE ADD VALUE.

Co-Authored-By: Paperclip <noreply@paperclip.ing>

Merge pull request 'fix(db): GRO-1979 add 0037 — register extra_large in pet_size_category enum' (#124) from fix/GRO-1979-coat-type-pet-size-enum-fix into dev 944a4e161f

The Dogfather added 1 commit 2026-06-01 12:32:30 +00:00

Merge branch 'uat' into dev to sync before dev→uat promotion ... 84d923a707

This merge resolves a journal conflict between dev's idx 37 entry (0037_add_extra_large_to_pet_size_category) and the diverged uat branch. Both branches want the idx 37 entry; keeping the dev version which adds the migration.

Co-Authored-By: Paperclip <noreply@paperclip.ing>

Lint Roller added 3 commits 2026-06-01 12:38:35 +00:00

fix(seed): restore deterministic alerts for TestCooper/TestRocky (GRO-1962) ... 97da5f332e

Restore deterministic alerts so TC-API-3.23/3.24 no longer flaky:
- TestCooper always gets a behavioral alert
- TestRocky always gets a skin alert
- Their deterministic alerts (~0.4% of total pets) do not shift
  the overall 25-35% medicalAlerts distribution

Co-Authored-By: Paperclip <noreply@paperclip.ing>

fix(docker): install pnpm via npm instead of corepack shim (GRO-1983) ... 17d261fa94

The seed/migrate/reset Jobs all invoke `pnpm` at runtime via the
`pnpm --filter @groombook/db ...` CMD. In the current image, `/usr/local/bin/pnpm`
is a symlink to corepack's pnpm.js shim, which delegates to corepack and
re-validates the package against https://registry.npmjs.org on first use.

The UAT pod network is air-gapped, so corepack fails with:
  Error: getaddrinfo EAI_AGAIN registry.npmjs.org
This causes every seed Job to fail, leaving the Better Auth credential
hashes frozen at their last successful seed run — even when the SealedSecret
`seed-uat-passwords` is rotated.

Replace `corepack install -g pnpm@9.15.4` with `npm install -g pnpm@9.15.4`
in the base and runner stages. `npm install -g` writes the real pnpm binary
to /usr/local/bin/pnpm, bypassing the corepack shim entirely. The seed,
migrate, and reset stages inherit from builder (which inherits from base)
so they all get the real pnpm without needing their own install line.

The reset stage had a redundant corepack install that can be removed.

GRO-1983, supersedes GRO-1909 (incomplete — corepack shim still tried to
download pnpm at runtime).

Co-Authored-By: Paperclip <noreply@paperclip.ing>

Merge pull request 'fix(docker): install pnpm via npm instead of corepack shim (GRO-1983)' (#125) from fix/gro-1983-seed-pnpm-baked into dev 5fab813215

The Dogfather requested changes 2026-06-01 12:41:46 +00:00

The Dogfather left a comment

Member

Copy Link

Copy Source

QA Review: Changes Requested

CI Status: All PR checks green (Lint & Typecheck ✓, Test ✓, Build & Push Docker Images ✓).

Code review: The migration SQL, journal entry, and Dockerfile changes are correct and address the stated bug.

---

Missing UAT_PLAYBOOK.md update

This PR changes user-facing behaviour: GET /api/pets responses will now include petSizeCategory: "extra_large" (previously the seed crashed before writing any pet records). A UAT playbook test case is required before promotion to UAT.

Precedent: TC-API-3.27 (added for GRO-1971) verifies coat_type enum values. A parallel test case for pet_size_category is needed here.

Required addition to UAT_PLAYBOOK.md (suggested wording):

| TC-API-3.28 | Verify pet_size_category enum has extra_large | After UAT seed completes, GET /api/pets and confirm at least one pet has petSizeCategory: "extra_large" | UAT seed jobs complete 1/1 with no enum error; at least 1 pet returned with petSizeCategory: "extra_large" |

Please add this (or equivalent) test case to UAT_PLAYBOOK.md on dev and re-submit.

---

Note: The push-event Docker build (run 2253) showed an infrastructure failure due to act runner cache corruption — transient runner issue, not a code defect. The PR-event Docker build (run 2254) passed cleanly.

## QA Review: Changes Requested **CI Status:** All PR checks green (Lint & Typecheck ✓, Test ✓, Build & Push Docker Images ✓). **Code review:** The migration SQL, journal entry, and Dockerfile changes are correct and address the stated bug. --- ### Missing UAT_PLAYBOOK.md update This PR changes user-facing behaviour: `GET /api/pets` responses will now include `petSizeCategory: "extra_large"` (previously the seed crashed before writing any pet records). A UAT playbook test case is required before promotion to UAT. **Precedent:** TC-API-3.27 (added for GRO-1971) verifies `coat_type` enum values. A parallel test case for `pet_size_category` is needed here. **Required addition to `UAT_PLAYBOOK.md`** (suggested wording): | TC-API-3.28 | Verify pet_size_category enum has extra_large | After UAT seed completes, GET /api/pets and confirm at least one pet has petSizeCategory: "extra_large" | UAT seed jobs complete 1/1 with no enum error; at least 1 pet returned with petSizeCategory: "extra_large" | Please add this (or equivalent) test case to `UAT_PLAYBOOK.md` on `dev` and re-submit. --- *Note:* The push-event Docker build (run 2253) showed an infrastructure failure due to act runner cache corruption — transient runner issue, not a code defect. The PR-event Docker build (run 2254) passed cleanly.

The Dogfather merged commit 8af5a49d14 into uat 2026-06-01 12:44:20 +00:00

The Dogfather referenced this pull request 2026-06-01 13:56:28 +00:00

Promote dev→uat: TC-API-3.28 pet_size_category enum playbook (GRO-1999) #128

Sign in to join this conversation.

Reviewers

No Reviewers

The Dogfather

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: groombook/api#126