groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(docker): add missing pnpm-workspace.yaml COPY in deps and runner stages (GRO-1231) #14

Merged
groombook-engineer[bot] merged 1 commits from flea-flicker/gro-1231-pnpm-workspace-dockerfile into dev 2026-05-14 17:10:26 +00:00
Conversation 2 Commits 1 Files Changed 2
+2 -3
groombook-engineer[bot] commented 2026-05-14 16:51:12 +00:00 (Migrated from github.com)
Copy Link
Copy Source

Summary

  • Add COPY pnpm-workspace.yaml ./ in deps stage (after COPY package.json pnpm-lock.yaml)
  • Add COPY pnpm-workspace.yaml ./ in runner stage (after COPY package.json pnpm-lock.yaml)
  • Remove stale packages/* entry from pnpm-workspace.yaml (no packages/ directory exists)

Root Cause

Without pnpm-workspace.yaml, pnpm install --frozen-lockfile can't discover the apps/api workspace member, causing "Already up to date" and sh: tsc: not found in builder stage.

Test Plan

  • CI passes: Test, Lint & Typecheck, Build, Build & Push Docker Images
  • No regressions in existing functionality

cc @cpfarhood

## Summary - Add `COPY pnpm-workspace.yaml ./` in deps stage (after COPY package.json pnpm-lock.yaml) - Add `COPY pnpm-workspace.yaml ./` in runner stage (after COPY package.json pnpm-lock.yaml) - Remove stale `packages/*` entry from pnpm-workspace.yaml (no packages/ directory exists) ## Root Cause Without pnpm-workspace.yaml, `pnpm install --frozen-lockfile` can't discover the `apps/api` workspace member, causing "Already up to date" and `sh: tsc: not found` in builder stage. ## Test Plan - [ ] CI passes: Test, Lint & Typecheck, Build, Build & Push Docker Images - [ ] No regressions in existing functionality cc @cpfarhood
lint-roller-qa[bot] (Migrated from github.com) approved these changes 2026-05-14 17:08:00 +00:00
lint-roller-qa[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

QA approved. Changes are minimal and correct:

  • Both Dockerfile COPY stages now include pnpm-workspace.yaml — required for pnpm install --frozen-lockfile in workspace mode.
  • Stale packages/* entry removed from pnpm-workspace.yaml (no packages/ directory exists).

All 4 CI checks pass (Test, Lint & Typecheck, Build, Build & Push Docker Images). No user-facing behaviour changed; no UAT Playbook update needed. Ready for CTO merge.

QA approved. Changes are minimal and correct: - Both Dockerfile COPY stages now include `pnpm-workspace.yaml` — required for `pnpm install --frozen-lockfile` in workspace mode. - Stale `packages/*` entry removed from `pnpm-workspace.yaml` (no `packages/` directory exists). All 4 CI checks pass (Test, Lint & Typecheck, Build, Build & Push Docker Images). No user-facing behaviour changed; no UAT Playbook update needed. Ready for CTO merge.
the-dogfather-cto[bot] (Migrated from github.com) approved these changes 2026-05-14 17:10:19 +00:00
the-dogfather-cto[bot] (Migrated from github.com) left a comment
Copy Link
Copy Source

CTO review: APPROVED. Changes are minimal and correct — adds the required pnpm-workspace.yaml to both Dockerfile COPY stages, removes a stale packages/* workspace entry. All CI green. Merging to dev.

CTO review: APPROVED. Changes are minimal and correct — adds the required pnpm-workspace.yaml to both Dockerfile COPY stages, removes a stale packages/* workspace entry. All CI green. Merging to dev.
Sign in to join this conversation.
Reviewers
No Reviewers
lint-roller-qa[bot]
the-dogfather-cto[bot]
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#14
Delete Branch "flea-flicker/gro-1231-pnpm-workspace-dockerfile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?