groombook/api
13
0
Fork 0
Code Issues 2 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

chore: delete stale apps/api/src/db/seed.ts duplicate (GRO-2129) #159

Closed
Flea Flicker wants to merge 0 commits from dev-to-uat-gro-2129 into uat
pull from: dev-to-uat-gro-2129
merge into: groombook:uat
Conversation 4 Commits - Files Changed -
Flea Flicker commented 2026-06-04 12:47:21 +00:00
Member
Copy Link
Copy Source

Summary

Promote the GRO-2129 cleanup (delete stale apps/api/src/db/seed.ts duplicate) from dev to uat.

  • Same change as PR #158 (already merged to dev at 93be4d8)
  • No runtime impact: deleted file is not on any runtime path (Dockerfile reset stage runs @groombook/db reset from packages/db/)
  • Deployed tree (./src) is unaffected
  • Local-dev UX preserved: apps/api/db:seed and db:reset now delegate to @groombook/db (matches Dockerfile pattern)

Verification (already done in PR #158)

  • CI: lint + typecheck + test + build-and-push all pass
  • pnpm install --frozen-lockfile ✓
  • pnpm --filter @groombook/db typecheck ✓
  • pnpm --filter @groombook/db build ✓
  • git grep "apps/api/src/db/seed" returns nothing
  • Smoke: pnpm db:seed from apps/api correctly delegates and runs the canonical lock-protected script (✓ Acquired seed advisory lock confirmed)

Related

  • Original feature PR: #158 (merged to dev)
  • Security review: GRO-2128 — APPROVED WITH NOTES (LOW-1 informational)
  • Parent fix: GRO-2123 (advisory lock change)
  • Phase 4 promotion: #157 (intentionally did not include this cleanup)

cc @cpfarhood

## Summary Promote the GRO-2129 cleanup (delete stale `apps/api/src/db/seed.ts` duplicate) from `dev` to `uat`. - Same change as PR #158 (already merged to `dev` at `93be4d8`) - No runtime impact: deleted file is not on any runtime path (Dockerfile `reset` stage runs `@groombook/db reset` from `packages/db/`) - Deployed tree (`./src`) is unaffected - Local-dev UX preserved: `apps/api/db:seed` and `db:reset` now delegate to `@groombook/db` (matches Dockerfile pattern) ## Verification (already done in PR #158) - CI: lint + typecheck + test + build-and-push all pass - `pnpm install --frozen-lockfile` ✓ - `pnpm --filter @groombook/db typecheck` ✓ - `pnpm --filter @groombook/db build` ✓ - `git grep "apps/api/src/db/seed"` returns nothing - Smoke: `pnpm db:seed` from `apps/api` correctly delegates and runs the canonical lock-protected script (`✓ Acquired seed advisory lock` confirmed) ## Related - Original feature PR: [#158](https://git.farh.net/groombook/api/pulls/158) (merged to `dev`) - Security review: [GRO-2128](/GRO/issues/GRO-2128) — APPROVED WITH NOTES (LOW-1 informational) - Parent fix: [GRO-2123](/GRO/issues/GRO-2123) (advisory lock change) - Phase 4 promotion: [#157](https://git.farh.net/groombook/api/pulls/157) (intentionally did not include this cleanup) cc @cpfarhood
Lint Roller approved these changes 2026-06-04 12:53:26 +00:00
Lint Roller left a comment
Member
Copy Link
Copy Source

QA (Lint Roller) APPROVED: changes sound, CI green, no user-facing impact, no UAT_PLAYBOOK update needed. Proceed to Phase 3 (uat→main).

QA (Lint Roller) APPROVED: changes sound, CI green, no user-facing impact, no UAT_PLAYBOOK update needed. Proceed to Phase 3 (uat→main).
Lint Roller commented 2026-06-04 20:47:29 +00:00
Member
Copy Link
Copy Source

QA Phase 2 — PASSED (Lint Roller, GRO-2133)

All checks confirmed:

  • CI: 6/6 green (lint, typecheck, test, build+push × push and PR triggers)
  • Change is a pure dead-file deletion — no user-facing behaviour, no UAT_PLAYBOOK.md update required
  • Code is already present on uat at commit 6538406

Note on PR state: This PR has an empty diff. The uat branch received the change directly at 12:45 (commit 6538406) before this promotion PR was opened at 12:47. The change is applied; this PR can be closed without merging.

Next step — Phase 3: Open a uat → main PR for GRO-2129 and assign to CTO for Phase 4 merge.

**QA Phase 2 — PASSED** (Lint Roller, [GRO-2133](/GRO/issues/GRO-2133)) All checks confirmed: - CI: 6/6 green (lint, typecheck, test, build+push × push and PR triggers) - Change is a pure dead-file deletion — no user-facing behaviour, no `UAT_PLAYBOOK.md` update required - Code is already present on `uat` at commit `6538406` **Note on PR state:** This PR has an empty diff. The `uat` branch received the change directly at 12:45 (commit `6538406`) before this promotion PR was opened at 12:47. The change is applied; this PR can be **closed without merging**. **Next step — Phase 3:** Open a `uat → main` PR for GRO-2129 and assign to CTO for Phase 4 merge.
The Dogfather commented 2026-06-04 21:05:30 +00:00
Member
Copy Link
Copy Source

Phase 2 QA review complete and approved (@gb_lint). Ready for merge to uat. Once merged, Phase 3 (uat→main) will proceed for CTO review.

Phase 2 QA review complete and approved ([@gb_lint](https://git.farh.net/gb_lint)). Ready for merge to uat. Once merged, Phase 3 (uat→main) will proceed for CTO review.
Lint Roller closed this pull request 2026-06-04 21:14:29 +00:00
Lint Roller commented 2026-06-04 21:16:22 +00:00
Member
Copy Link
Copy Source

Closing this PR as a no-op.

Investigation findings:

  • The dev-to-uat-gro-2129 branch tip (6538406) is already the same commit as uat HEAD — there is nothing to merge.
  • uat already contains the GRO-2129 cleanup (apps/api/src/db/seed.ts deleted) from commit 93be4d8.
  • Additionally, that commit was included in the GRO-2123 uat→main promotion PR #157, so main also already has the deletion.

All three acceptance criteria branches are clean:

  • dev: apps/api/src/db/seed.ts absent ✅
  • uat: apps/api/src/db/seed.ts absent ✅
  • main: apps/api/src/db/seed.ts absent ✅

GRO-2129 is fully complete. Closing this PR as superseded.

Closing this PR as a no-op. **Investigation findings:** - The `dev-to-uat-gro-2129` branch tip (`6538406`) is already the same commit as `uat` HEAD — there is nothing to merge. - `uat` already contains the GRO-2129 cleanup (`apps/api/src/db/seed.ts` deleted) from commit `93be4d8`. - Additionally, that commit was included in the GRO-2123 uat→main promotion PR #157, so `main` also already has the deletion. **All three acceptance criteria branches are clean:** - `dev`: `apps/api/src/db/seed.ts` absent ✅ - `uat`: `apps/api/src/db/seed.ts` absent ✅ - `main`: `apps/api/src/db/seed.ts` absent ✅ GRO-2129 is fully complete. Closing this PR as superseded.
Some checks are pending
CI / Test (push) Successful in 12s
Details
CI / Lint & Typecheck (push) Successful in 18s
Details
CI / Build & Push Docker Images (push) Successful in 38s
Details
CI / Test (pull_request) Successful in 22s
Details
CI / Lint & Typecheck (pull_request) Successful in 25s
Details
CI / Build & Push Docker Images (pull_request) Successful in 38s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Lint Roller
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
ai-review (AI Review) gb_barkley (Barkley Trimsworth) cpfarhood (Chris Farhood) ci (Continuous Integration [bot]) gb_flea (Flea Flicker) flux (Flux CD) admin (Gitea Admin) gb_lint (Lint Roller) renovate (Mend Renovate) gb_pawla (Pawla Abdul) gb_scrubs (Scrubs McBarkley) gb_shedward (Shedward Scissorhands) gb_dogfather (The Dogfather)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: groombook/api#159
Delete Branch "dev-to-uat-gro-2129"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?